From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BA5DECAAD3 for ; Thu, 1 Sep 2022 08:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234342AbiIAI7Z (ORCPT ); Thu, 1 Sep 2022 04:59:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234283AbiIAI65 (ORCPT ); Thu, 1 Sep 2022 04:58:57 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E4A912DA11 for ; Thu, 1 Sep 2022 01:58:46 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id y10so14031751ljq.0 for ; Thu, 01 Sep 2022 01:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=mwYkPkbDpVvKnBCUeAO6SqNihrRVFRauQ3ciXakJntA=; b=cKwqNiIrCuxruPskUUyXVi0JY9nUNWB8yP5ZQhyNNBSUopD4SsK0P8gePIAcydCr7z r4crGQCX9xEDitfqH9Z6UxWKwsc02KM9E3EXGBjDxhJ/U9YJi0znHlHwoseHOaHNqiui z5FuuckuAUnshfoG1UFLG0MIPBJq6sEzM/cPdZDPL7TESLplsAH2ky6hEpuJkNgWPfyp nhGOokE0WMs01y19cc3exxaVmloPYyb//W6rFybNcFd/Y7AWbYNPBJ3OoozvSHzQjoJc RbuI9L+mP6sPKtqx+3EBJKqzFSXH8joq7o6XRrmeh2rpGwQETP24AyyrVOF93bnLkTa9 8Drg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=mwYkPkbDpVvKnBCUeAO6SqNihrRVFRauQ3ciXakJntA=; b=z6qfXVckn79uKj05c3v2dSClk++LC0XQn0Hbe20dx9SG3sTjpQe7d09h675XetuD2k O232T8IpgzFUmzvGuT6mH603ZkgEGBN8lsf+iypfxN3XnkY0yFMLHIlCy6h4oA4mXzec mM1bi3h0YCfmuw9T3vJtSEpIoMiG/2V8yBXLhicCYM9l75kKcesvJpIuhG67lu4kIzUL 0STIVwkKv7ZDCgG6ilLND+szeVRbNyxLgPy/eBQkInro/YX/zQuYHPdKUtQS9/frqijh CcioXYK2yTUTU+m9AgiNPRBxR3YIgUMVBwJUNppkpfTIi1avSfu2pepzrI/8eH1XJLog jNcw== X-Gm-Message-State: ACgBeo0agw0xYcTaOuq/CwFKwSCLVFHY2oscfXcYE8Lpd105rug0SSqH 82+HlR7dHWDpc5orF03Xgpy4bQ== X-Google-Smtp-Source: AA6agR4A/NKeMsV4Ak8gwgmbbPOMBHhorkS3+tj93KcLuvLF0EZl4lxNAvCjmnsb+w611pd+BKfYHg== X-Received: by 2002:a05:651c:4c9:b0:25e:7979:573a with SMTP id e9-20020a05651c04c900b0025e7979573amr9289821lji.445.1662022724895; Thu, 01 Sep 2022 01:58:44 -0700 (PDT) Received: from [192.168.28.124] (balticom-73-99-134.balticom.lv. [109.73.99.134]) by smtp.gmail.com with ESMTPSA id f8-20020a05651c03c800b002663afd079fsm1263777ljp.115.2022.09.01.01.58.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 01:58:44 -0700 (PDT) Message-ID: Date: Thu, 1 Sep 2022 11:58:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v4 3/3] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 (SM-T530) Content-Language: en-US To: =?UTF-8?Q?Matti_Lehtim=c3=a4ki?= , linux-arm-msm@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220831173207.238080-1-matti.lehtimaki@gmail.com> <20220831173207.238080-4-matti.lehtimaki@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220831173207.238080-4-matti.lehtimaki@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/08/2022 20:32, Matti Lehtimäki wrote: > Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T530) wifi tablet > based on the apq8026 platform. > > Currently supported are accelerometer sensor, hall sensor, > internal storage, physical buttons (power & volume), screen > (based on simple-framebuffer set up by the bootloader), sdcard, > touchscreen and USB. > > Signed-off-by: Matti Lehtimäki > --- > Changes in v4: > - Move delete-node to memory-region > - Move usb-switch node to blsp_i2c4 > (...) > +}; > + > +&rpm_requests { > + pm8226-regulators { I don't think this passes bindings. Run `make dtbs_check`. I don't want to keep accepting DTS which does not validate and none of submiters want to fix this... Rebase on top of: https://lore.kernel.org/linux-devicetree/20220901085609.95624-1-krzysztof.kozlowski@linaro.org/T/#t Node name should be "regulators". Be sure your DTS has 0 warning. Best regards, Krzysztof