devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Neuschäfer" <j.ne@posteo.net>
To: Chen-Yu Tsai <wens@csie.org>
Cc: j.ne@posteo.net, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: allwinner: orangepi-zero: Enable audio codec
Date: Mon, 28 Apr 2025 07:26:41 +0000	[thread overview]
Message-ID: <aA8tsao6hhW50k4e@probook> (raw)
In-Reply-To: <CAGb2v67-1tk0uAmYL-y6479itUxBJua76qhjn+0tTsN+Ni_a1w@mail.gmail.com>

On Sun, Apr 27, 2025 at 01:28:58PM +0800, Chen-Yu Tsai wrote:
> On Fri, Apr 18, 2025 at 7:32 AM J. Neuschäfer via B4 Relay
> <devnull+j.ne.posteo.net@kernel.org> wrote:
> >
> > From: "J. Neuschäfer" <j.ne@posteo.net>
> >
> > Line out playback and microphone capture work, after enabling the
> > corresponding ALSA controls. Tested with the Orange Pi Zero interface
> > board, which is a (mostly) passive adapter from the 13-pin header to
> > standard connectors (2x USB A, 1x Audio/Video output, 1x built-in
> > microphone).
> >
> >   https://orangepi.com/index.php?route=product/product&product_id=871
> 
> What about the USB ports?

Good point, I could test these. I have not mentioned them because they
are not related to audio.

> In any case, we don't enable peripherals on "headers" by default. That's
> up to the end user. The description for the whole adapter board could be
> an overlay that users can then apply directly.

For features such as pinmuxed UARTs (already present and disabled in the
dts), I fully agree, because they could as well be used as GPIO, and
that's for the user to decide.

For the audio pins, there's nothing else one can do with them, as far as
I understand it. It is possible to use at the least the Line Out pins
with very minimal setup, e.g. just connecting the pins to headphones or
something else.

I'll clarify the following points in a comment in the next version:

 - The audio signals are exposed on the 1x13 header described in
   https://linux-sunxi.org/Xunlong_Orange_Pi_Zero

 - The pins can't be used for anything else according to section
   3.1. Pin Characteristics of the Allwinner H3 Datasheet.

Although I would prefer to enable the audio pins by default (because
they are present on the Orange Pi Zero board), I would also be ok with
adding them as status = "disabled", as is the case with uart1 and uart2.
Please let me know your opinion.

I will test the USB ports and write a devicetree overlay at
arch/arm/boot/dts/allwinner/orangepi-zero-interface-board.dtso


Best regards,
J. Neuschäfer

  reply	other threads:[~2025-04-28  7:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-17 23:32 [PATCH] ARM: dts: allwinner: orangepi-zero: Enable audio codec J. Neuschäfer via B4 Relay
2025-04-27  5:28 ` Chen-Yu Tsai
2025-04-28  7:26   ` J. Neuschäfer [this message]
2025-04-28  8:37     ` Chen-Yu Tsai
2025-04-28 10:58       ` J. Neuschäfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aA8tsao6hhW50k4e@probook \
    --to=j.ne@posteo.net \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).