Re: [PATCH v2 1/2] mmc: sdhci_am654: Add sdhci_am654_start_signal_voltage_switch

[Francesco Dolcini <francesco@dolcini.it>]

Hello Judith,

On Thu, Apr 17, 2025 at 01:26:51PM -0500, Judith Mendez wrote:
> The sdhci_start_signal_voltage_switch function sets
> V1P8_SIGNAL_ENA by default after switching to 1v8 signaling.
> V1P8_SIGNAL_ENA has a timing component where it determines
> whether to launch cmd/data on neg edge (half cycle timing)
> or pos edge (full cycle timing) of clock. V1P8_SIGNAL_ENA also
> has a voltage switch component where if there exists an internal
> LDO, for SD this bit is used to switch from 3.3V to 1.8V IO
> signal voltage.
> 
> The sequence is to switch to 1.8 IO voltage, set V1P8_SIGNAL_ENA,
> change bus width, then update HIGH_SPEED_ENA & UHS_MODE_SELECT.
> During bus width change is when eMMC failures are seen with
> Kingston eMMC and various types SD cards across Sitara K3 SoCs.
> 
> So, add a quirk to suppress V1P8_SIGNAL_ENA and do not enable by
> default for eMMC since it is anyways optional for this interface
> and parse DT property: ti,fails-without-test-cd to apply the quirk
> for SD cards.
> 
> Signed-off-by: Judith Mendez <jm@ti.com>
> Suggested-by: Hiago De Franco <hiago.franco@toradex.com>

Fixes: ac5a41b472b4 ("Revert "mmc: sdhci_am654: Add sdhci_am654_start_signal_voltage_switch"")
Fixes: 941a7abd4666 ("mmc: sdhci_am654: Add sdhci_am654_start_signal_voltage_switch")
Cc:stable@vger.kernel.org