Re: [PATCH v5 3/3] iio: dac: ad3530r: Add driver for AD3530R and AD3531R

[Andy Shevchenko <andy@kernel.org>]

On Tue, Apr 22, 2025 at 11:37:06AM -0500, David Lechner wrote:
> On 4/22/25 10:11 AM, Andy Shevchenko wrote:
> > On Mon, Apr 21, 2025 at 12:24:54PM +0800, Kim Seer Paller wrote:

...

> >> +#define AD3530R_INTERNAL_VREF_MV		2500
> > 
> > _mV (yes, with Volts and Amperes we use proper spelling).
> 
> When did we start doing that? No one asked me to do this in any of the new
> drivers I did in the last year, so I didn't know this was a thing we should
> be doing.

I remember a discussion for one driver a year or so ago. But I can't find
quickly a reference. The rationale is to be as closer as possible to real
world (physics). And, for instance, regulator framework does that already.
It's a pity not many people aware...

...

> >> +static const char * const ad3530r_powerdown_modes[] = {
> >> +	"1kohm_to_gnd",
> > 
> > kOhm
> > 
> >> +	"7.7kohm_to_gnd",
> > 
> > Ditto.
> > 
> >> +	"32kohm_to_gnd",
> > 
> > Ditto.
> 
> These are defined by sysfs ABI, so can't be changed otherwise it would break
> userspace.

Ah, okay then.

> Comes from...
> What:		/sys/bus/iio/devices/iio:deviceX/out_voltageY_powerdown_mode

> >> +};

-- 
With Best Regards,
Andy Shevchenko