Re: [PATCH v3 04/10] dt-bindings: riscv: Add SiFive HiFive Premier P550 board

Jisheng Zhang
2025-04-26T14:54:32Z

On Thu, Apr 10, 2025 at 08:55:13PM +0530, Pinkesh Vaghela wrote:
> From: Pritesh Patel <pritesh.patel@einfochips.com>
>
> Add DT binding documentation for the ESWIN EIC7700 SoC and
> HiFive Premier P550 Board
>
> Signed-off-by: Pritesh Patel <pritesh.patel@einfochips.com>
> Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
> Signed-off-by: Pinkesh Vaghela <pinkesh.vaghela@einfochips.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@kernel.org>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../devicetree/bindings/riscv/eswin.yaml | 29 +++++++++++++++++++
> MAINTAINERS | 7 +++++
> 2 files changed, 36 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/riscv/eswin.yaml
>
> diff --git a/Documentation/devicetree/bindings/riscv/eswin.yaml b/Documentation/devicetree/bindings/riscv/eswin.yaml
> new file mode 100644
> index 000000000000..c603c45eef22
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/riscv/eswin.yaml
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/riscv/eswin.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ESWIN SoC-based boards
> +
> +maintainers:
> + - Min Lin <linmin@eswincomputing.com>
> + - Pinkesh Vaghela <pinkesh.vaghela@einfochips.com>
> + - Pritesh Patel <pritesh.patel@einfochips.com>
> +
> +description:
> + ESWIN SoC-based boards
> +
> +properties:
> + $nodename:
> + const: '/'
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - sifive,hifive-premier-p550
> + - const: eswin,eic7700
> +
> +additionalProperties: true
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bfcdf2bced61..f90c940f286c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8768,6 +8768,13 @@ L: linux-can@vger.kernel.org
> S: Maintained
> F: drivers/net/can/usb/esd_usb.c
>
> +ESWIN DEVICETREES
> +M: Min Lin <linmin@eswincomputing.com>

IMHO, this series isn's sent by this email, and I didn't find any
Min's commit history in the Linus tree, and even didn't find any
discussions or code reviews in the mailist, so is it suitable to add
to maintainers? I think maintainers doesn't work like this flow.

> +M: Pinkesh Vaghela <pinkesh.vaghela@einfochips.com>
> +M: Pritesh Patel <pritesh.patel@einfochips.com>
> +S: Maintained
> +F: Documentation/devicetree/bindings/riscv/eswin.yaml
> +
> ET131X NETWORK DRIVER
> M: Mark Einon <mark.einon@gmail.com>
> S: Odd Fixes
> --
> 2.25.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv