Re: [PATCH v11 0/3] Add STM32MP25 SPI NOR support

Patrice CHOTARD
2025-05-05T12:19:53Z

On 5/4/25 18:16, Krzysztof Kozlowski wrote:
> On 04/05/2025 15:50, Krzysztof Kozlowski wrote:
>>
>> On Mon, 28 Apr 2025 10:58:29 +0200, Patrice Chotard wrote:
>>> This series adds SPI NOR support for STM32MP25 SoCs from STMicroelectronics.
>>>
>>> On STM32MP25 SoCs family, an Octo Memory Manager block manages the muxing,
>>> the memory area split, the chip select override and the time constraint
>>> between its 2 Octo SPI children.
>>>
>>> Due to these depedencies, this series adds support for:
>>> - Octo Memory Manager driver.
>>> - Octo SPI driver.
>>> - yaml schema for Octo Memory Manager and Octo SPI drivers.
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [1/3] dt-bindings: memory-controllers: Add STM32 Octo Memory Manager controller
>> https://git.kernel.org/krzk/linux-mem-ctrl/c/43eb1b288072641b7de8f5d5c15bde69e6e8589a
>
> And dropped everything - it is full of warnings.

Hi Krzysztof,

What are the warnings you encountered ?

On my side, i double check and found nothing wrong neither on bindings side nor on source code side:

I previously checked that everything was up to date :

pip3 install dtschema --upgrade
Defaulting to user installation because normal site-packages is not writeable
Requirement already satisfied: dtschema in /local/home/nxp11987/.local/lib/python3.8/site-packages (2025.2)
Requirement already satisfied: ruamel.yaml>0.15.69 in /local/home/nxp11987/.local/lib/python3.8/site-packages (from dtschema) (0.17.21)
Requirement already satisfied: jsonschema<4.18,>=4.1.2 in /local/home/nxp11987/.local/lib/python3.8/site-packages (from dtschema) (4.17.3)
Requirement already satisfied: rfc3987 in /local/home/nxp11987/.local/lib/python3.8/site-packages (from dtschema) (1.3.8)
Requirement already satisfied: pylibfdt in /local/home/nxp11987/.local/lib/python3.8/site-packages (from dtschema) (1.6.1)
Requirement already satisfied: attrs>=17.4.0 in /local/home/nxp11987/.local/lib/python3.8/site-packages (from jsonschema<4.18,>=4.1.2->dtschema) (19.3.0)
Requirement already satisfied: importlib-resources>=1.4.0 in /local/home/nxp11987/.local/lib/python3.8/site-packages (from jsonschema<4.18,>=4.1.2->dtschema) (5.7.1)
Requirement already satisfied: pkgutil-resolve-name>=1.3.10 in /local/home/nxp11987/.local/lib/python3.8/site-packages (from jsonschema<4.18,>=4.1.2->dtschema) (1.3.10)
Requirement already satisfied: pyrsistent!=0.17.0,!=0.17.1,!=0.17.2,>=0.14.0 in /local/home/nxp11987/.local/lib/python3.8/site-packages (from jsonschema<4.18,>=4.1.2->dtschema) (0.18.1)
Requirement already satisfied: ruamel.yaml.clib>=0.2.6 in /local/home/nxp11987/.local/lib/python3.8/site-packages (from ruamel.yaml>0.15.69->dtschema) (0.2.6)
Requirement already satisfied: zipp>=3.1.0 in /local/home/nxp11987/.local/lib/python3.8/site-packages (from importlib-resources>=1.4.0->jsonschema<4.18,>=4.1.2->dtschema) (3.20.2)

export CROSS_COMPILE=aarch64-linux- ARCH=arm64 KBUILD_OUTPUT=out/
make defconfig
make[1]: Entering directory '/local/home/nxp11987/projects/community/kernel.org/linux/out'
GEN Makefile
HOSTCC scripts/basic/fixdep
HOSTCC scripts/kconfig/conf.o
HOSTCC scripts/kconfig/confdata.o

HOSTCC scripts/kconfig/expr.o
LEX scripts/kconfig/lexer.lex.c
YACC scripts/kconfig/parser.tab.[ch]
HOSTCC scripts/kconfig/lexer.lex.o
HOSTCC scripts/kconfig/menu.o
HOSTCC scripts/kconfig/parser.tab.o
HOSTCC scripts/kconfig/preprocess.o
HOSTCC scripts/kconfig/symbol.o
HOSTCC scripts/kconfig/util.o
HOSTLD scripts/kconfig/conf
*** Default configuration is based on 'defconfig'
#
# configuration written to .config
#
make[1]: Leaving directory '/local/home/nxp11987/projects/community/kernel.org/linux/out'

Then i applied this series https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=957628
above the current series to check DTB against bindings:

make CHECK_DTBS=y st/stm32mp257f-ev1.dtb

make[1]: Entering directory '/local/home/nxp11987/projects/community/kernel.org/linux/out'
HOSTCC scripts/dtc/dtc.o
HOSTCC scripts/dtc/flattree.o
HOSTCC scripts/dtc/fstree.o
HOSTCC scripts/dtc/data.o
HOSTCC scripts/dtc/livetree.o
HOSTCC scripts/dtc/treesource.o
HOSTCC scripts/dtc/srcpos.o
HOSTCC scripts/dtc/checks.o
HOSTCC scripts/dtc/util.o
LEX scripts/dtc/dtc-lexer.lex.c
YACC scripts/dtc/dtc-parser.tab.[ch]
HOSTCC scripts/dtc/dtc-lexer.lex.o
HOSTCC scripts/dtc/dtc-parser.tab.o
HOSTLD scripts/dtc/dtc
HOSTCC scripts/dtc/libfdt/fdt.o
HOSTCC scripts/dtc/libfdt/fdt_ro.o
HOSTCC scripts/dtc/libfdt/fdt_wip.o
HOSTCC scripts/dtc/libfdt/fdt_sw.o
HOSTCC scripts/dtc/libfdt/fdt_rw.o
HOSTCC scripts/dtc/libfdt/fdt_strerror.o
HOSTCC scripts/dtc/libfdt/fdt_empty_tree.o
HOSTCC scripts/dtc/libfdt/fdt_addresses.o
HOSTCC scripts/dtc/libfdt/fdt_overlay.o
HOSTCC scripts/dtc/fdtoverlay.o
HOSTLD scripts/dtc/fdtoverlay
SCHEMA Documentation/devicetree/bindings/processed-schema.json
/local/home/nxp11987/projects/community/kernel.org/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml: mac-mode: missing type definition
UPD include/config/kernel.release
DTC [C] arch/arm64/boot/dts/st/stm32mp257f-ev1.dtb
make[1]: Leaving directory '/local/home/nxp11987/projects/community/kernel.org/linux/out'

and finally :

make CHECK_DTBS=y DT_SCHEMA_FILES=st,stm32mp25-omm.yaml st/stm32mp257f-ev1.dtb
make[1]: Entering directory '/local/home/nxp11987/projects/community/kernel.org/linux/out'
DTC [C] arch/arm64/boot/dts/st/stm32mp257f-ev1.dtb
make[1]: Leaving directory '/local/home/nxp11987/projects/community/kernel.org/linux/out'

Thanks
Patrice

>
> Best regards,
> Krzysztof