Re: [PATCH] arm64: dts: ti: k3-am625-sk: Add power/temperature sensors

[Sascha Hauer <s.hauer@pengutronix.de>]

Hi Nishanth,

On Wed, May 07, 2025 at 07:01:04AM -0500, Nishanth Menon wrote:
> On 15:24-20250505, Sascha Hauer wrote:
> > The AM625-SK has six power sensors and two temperature sensors connected
> > to I2C. Add them to the device tree.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > The AM625-SK has six power sensors and two temperature sensors connected
> > to I2C. Add them to the device tree.
> 
> Sascha,
> 
> I suggest making this as overlay. The reason is as follows: AM625-SK
> among other TI evms do have automated power measurement capability from
> XDS110 (accessible via USB port for jtag - appears as a rudimentary
> menu option). The way this works is that it uses TM4C1294NCPDT to use
> I2C commands to control the INA226/231 depending on the evm.
> 
> This firmware should be flashed by default on production boards (if
> not, starting up CCS[1], autodetects older firmware and updates - at
> least to my understanding) - by the way, this firmware also does test
> automation, such as boot mode switch control, reset control etc.
> 
> This is the primary framework meant to be used by test automation and
> indeed it is the default inside TI.
> 
> Challenge here is this: if we make this default in Linux, the test
> automation system configures the INA226/231 in a different sampling
> mode depending on usecase etc Vs what Linux does (even though the
> shunt and the bus voltage for a given INA is the same). And just like
> Linux, the firmware power measurement logic has changed over the
> years.
> 
> Anyways, while I know that the SoC and TM4C can both handle
> multi-master, the challenge is the same INA controlled and
> mix-configured by two masters (and there is no synchronization between
> the two).
> 
> To avoid this entire conflict and headache, I suggest adding it as
> overlay that can be applied depending on the preference of measurement
> desired.

Thanks for this explanation. I'll go for the overlay then.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |