From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5F08231830 for ; Wed, 30 Apr 2025 09:39:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746005959; cv=none; b=sJJyaaFDhTm9R+v7w4gqf9PiYSFma2oWD9vscdoulPD1mAaghlqAyHybWjhL6WQi2HXan7WJIxa5ucbifM6dkG1u9sTLJYAnEuuJ6LBJ8CrKiyyWalXNEQ0qHADlk0f06FM2LeSciS+11PLMXy+PaUsI3V03GiRM3Xy9v2u/2gI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746005959; c=relaxed/simple; bh=AUDJd4dz5XyC/N6fEGt5cYH/J0DmYOyJCqcdAnsYAcw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GwCdC/PVs/r3ghTfnMEZ6uA+3u2zDB9yrsMzVKx2N9W+4wI5KQubfB98Y0Dluw0EIJ9cTqBWViMmyvB4Tsx9P85t7nTIQ/VBoeRnxXhDPtga0JYiO0bN8gkKs8gSjNFZtvcomt3cB7/xrVNKM05QbWMvbQiRlRU85MP+RuojrBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uO3SaQvM; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uO3SaQvM" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-ace3b03c043so1116251366b.2 for ; Wed, 30 Apr 2025 02:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746005956; x=1746610756; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6OGMbcMEkhBmGqs5Z3YtgBQ6Hwa1jUmstb0M0+KK0Nc=; b=uO3SaQvMg2uYB5lOtoFBdyDcAipupleaSdHMd14tWmPxYRsMP0RVbfRhnuW7lMa+Jq oAmLd2va15V7SUtqz90aKf3EWd/xWqEd0xWoeQsBCy9saIyy44cxEBOe4uhg9rAKzvwV qNIXo7Swfnf9PS6tWrptvpRJjL6RizDJw3AR1RlpDPwgB897bn4f8peMWw1963xnxUAr HhyrJG+qR/xoMsJ2Hq050qymPzMiuq6ETz1smE+Iwgixdb2vIMSIrlEQza6SnriZQBtz IN7dl7qdMbAYFq7MSxSuydv5PgSwjN/w7djsXMs8axi4tOaUajgvJaiZTHgiNP2tAt8R nMGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746005956; x=1746610756; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6OGMbcMEkhBmGqs5Z3YtgBQ6Hwa1jUmstb0M0+KK0Nc=; b=ZY/KEpW8MyrnUW8VcY4kao52/VQwHqrdYpU6ENPz2sVdcWpuSGPvcj2cX+ZCKBpszG ZuNhro1I3aTiht1RJAzTe+OojJylxbaBeQ92J8tH/LOZXlsHOhtSv45t1RSuRppAnlyw 5YJKtL6doQOsn6wRXVY93BAIJ9KDfhYjGqyu0jydSGD6ZGbgHKbNB57XzXRKfJu4v3Uk p2ART2TxiIAD3QpklHn4m9wu7LpZqHQoRf1Gf4bSFaWHiQ5XRn/42v9qjcEGr9dHLXAg gw3/3PpN/CDUyfedq/CsbCh30hkEsDCi5n/l+/bVP3VBnT5nx9N75D+cX93cnOoqPb63 lJaQ== X-Forwarded-Encrypted: i=1; AJvYcCWHDd839HHdi2wDGLCx3APS2nQgOt8pQPGTx3J7ZkKdWTRCjM7u4FgIXXCdAIuS8/xzWMXQus7FG/Qj@vger.kernel.org X-Gm-Message-State: AOJu0YwgWW+n3KgZPCPJsK4oNiMjTpGUGEQ1xF+VFdyvE/0WAN0L2qUX sRiiJYx6Zcn9kbbr/OIQOwliwAQdN7kE5JULR9/lCmKGBFhAYSj84qWCD3xcaYs= X-Gm-Gg: ASbGnctNPD3M9FPD7WR+PKeXhdzqqnD/Kc05SpZW9KiLAi1MlHW3hVH7nzPIdCLXLz+ LVsr5OdpMQuzRjHz0bp6CWFmbHkdtEKSlaioYHTpbtkePH4Y9W4Mh2R8lA2QjsDolK3J1/EGlmW 1vCuRAg9LUFrky400+3HgzWytMyQEDvBxGEjF825AIuzmhyASd1G9p4grgQb/P/FzvBenfcwta5 Jgt01tDvBfA8NX89q7T9qlsEM8jBxd5+oKbfkqzOstkGpX1lgEDZIPubXHsOE66MVeB3YEVY3pB mUw4gCDYAnUtxvMEJO/8GcG96yTjhGGyq/OLsg== X-Google-Smtp-Source: AGHT+IFdTIvskANcQfZgyrnhvSLOX/uhDZK8XOpbGmgtU0SafrRwMbwRPtiX/Z0dHI+9ZICQQQNkbA== X-Received: by 2002:a17:907:d17:b0:aca:a347:c050 with SMTP id a640c23a62f3a-acedc029a40mr272914266b.0.1746005955819; Wed, 30 Apr 2025 02:39:15 -0700 (PDT) Received: from linaro.org ([62.231.96.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ace6e4f841fsm902286966b.72.2025.04.30.02.39.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 02:39:15 -0700 (PDT) Date: Wed, 30 Apr 2025 12:39:13 +0300 From: Abel Vesa To: Sebastian Reichel , Bjorn Andersson , Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sibi Sankar , Rajendra Nayak , Xilin Wu , Jens Glathe , Srinivas Kandagatla , Johan Hovold , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Konrad Dybcio Subject: Re: [PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3 compatible override Message-ID: References: <20250429-x1e80100-dts-drop-useless-dp-compatible-override-v1-0-058847814d70@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 25-04-30 01:26:13, Sebastian Reichel wrote: > Hi, > > On Tue, Apr 29, 2025 at 10:42:28AM +0300, Abel Vesa wrote: > > It all started with the support for CRD back when we had different > > compatibles for eDP and DP. Meanwhile, that has been sorted out and it > > is now figured out at runtime while using only the DP compatible. > > > > It's almost funny how this got copied over from CRD and spread to all > > X Elite platforms. > > > > TBH, the best reason to drop it ASAP is to make sure this doesn't spread > > beyond X Elite to newer platforms. > > > > Functionally nothing changes. > > Looking at the diff I wonder if this part should also be simplified: > > /delete-property/ #sound-dai-cells; > > This is done by all upstream X1E boards, so maybe just drop the > #sound-dai-cells directly in x1e80100.dtsi? Yeah, I'm not sure about that. Though the DP3 PHY is currently used as eDP, I think it could be used as DP. So I think it makes more sense to keep the DP3 controller as is in the SoC dtsi and delete the #sound-dai-cells property in each board specific dts. Don't know if it will ever be the case with this SoC, but maybe someone will use DP3 with the PHY configured as DP rather than eDP. Not sure if I'm 100% right about this though. Dmitry, Bjorn, do you think that is accurate enough? > > Greetings, > > -- Sebastian