Re: [PATCH] dt-bindings: interrupt-controller: Convert opencores,or1k-pic to DT schema

Stafford Horne
2025-05-06T16:18:26Z

On Mon, May 05, 2025 at 09:48:02AM -0500, Rob Herring (Arm) wrote:
> Convert the OpenRISC PIC interrupt controller binding to schema
> format. It's a straight-forward conversion of the typical interrupt
> controller.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../opencores,or1k-pic.txt | 23 -----------
> .../opencores,or1k-pic.yaml | 38 +++++++++++++++++++
> 2 files changed, 38 insertions(+), 23 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/opencores,or1k-pic.txt
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/opencores,or1k-pic.yaml
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/opencores,or1k-pic.txt b/Documentation/devicetree/bindings/interrupt-controller/opencores,or1k-pic.txt
> deleted file mode 100644
> index 55c04faa3f3f..000000000000
> --- a/Documentation/devicetree/bindings/interrupt-controller/opencores,or1k-pic.txt
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -OpenRISC 1000 Programmable Interrupt Controller
> -
> -Required properties:
> -
> -- compatible : should be "opencores,or1k-pic-level" for variants with
> - level triggered interrupt lines, "opencores,or1k-pic-edge" for variants with
> - edge triggered interrupt lines or "opencores,or1200-pic" for machines
> - with the non-spec compliant or1200 type implementation.
> -
> - "opencores,or1k-pic" is also provided as an alias to "opencores,or1200-pic",
> - but this is only for backwards compatibility.
> -
> -- interrupt-controller : Identifies the node as an interrupt controller
> -- #interrupt-cells : Specifies the number of cells needed to encode an
> - interrupt source. The value shall be 1.
> -
> -Example:
> -
> -intc: interrupt-controller {
> - compatible = "opencores,or1k-pic-level";
> - interrupt-controller;
> - #interrupt-cells = <1>;
> -};
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/opencores,or1k-pic.yaml b/Documentation/devicetree/bindings/interrupt-controller/opencores,or1k-pic.yaml
> new file mode 100644
> index 000000000000..995b68c3aed4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/opencores,or1k-pic.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/opencores,or1k-pic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OpenRISC 1000 Programmable Interrupt Controller
> +
> +maintainers:
> + - Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> +
> +properties:
> + compatible:
> + enum:
> + - opencores,or1k-pic-level
> + - opencores,or1k-pic-edge
> + - opencores,or1200-pic
> + - opencores,or1k-pic
> +
> + interrupt-controller: true
> +
> + '#interrupt-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - interrupt-controller
> + - '#interrupt-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + interrupt-controller {
> + compatible = "opencores,or1k-pic-level";
> + interrupt-controller;
> + #interrupt-cells = <1>;
> + };

This looks ok to me, I will queue via the OpenRISC queue.

-Stafford