Re: [PATCH v2 4/9] dt-bindings: mfd: add pf1550

Samuel Kayode
2025-05-21T16:16:48Z

On Sat, May 17, 2025 at 01:16:38PM +0200, Krzysztof Kozlowski wrote:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + regulators:
> > + $ref: /schemas/regulator/pf1550.yaml
> > +
> > + charger:
> > + $ref: /schemas/power/supply/pf1550_charger.yaml
> > +
> > + onkey:
> > + $ref: /schemas/input/pf1550_onkey.yaml
>
> This makes merging via separate trees not possible...
>
> Just fold everything here, drop compatibles and then put binding in the
> regulator. Unless children are re-usable which would justify
> compatibles, but then please provide arguments for that.

Yes, compatibles are not needed for the children. For adding binding to the
regulator, did you mean for all children: charger and onkey included? So,
replacing the separate yaml for all children with bindings in the mfd yaml?

Thanks,
Sam