From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBD6025A343 for ; Mon, 12 May 2025 08:42:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747039368; cv=none; b=q57HP7nJMox1fNBIKFCRcZWg0IQLO2zwjYbuaim54P+JIqLZhovPurYDwuPPb3jjBVMU/YJCm7urDoQhlf+QmU3AU135B0dcUW1V1s7fPz0fiZPzKYr0fsJs1dW416t+RfVpK2Xa+pWLIu/GcYLQB7H/05e18zVWy5yZNRz68JY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747039368; c=relaxed/simple; bh=1B5dgztH11GB21THwBIVK8ZGrtwBfTuLl4JLE5N72O8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DcBT8FJxlY53r4ulsUrRuE2vTbn9eVdfTEIOg5EJailCOiW+Ot5Z8kVnUPKqzGDNSI8Vh5pb0/58EWhCC//Qf2QgsMjR3XksGmvB+e4iaTk/ojB3w7XboUPe3l6pwDhdCwqQ/ihOVSlLC1NA6YrLoE+BLtRGo3raUiwtzMrwQoQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=CnwiY725; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="CnwiY725" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-b07d607dc83so3247656a12.1 for ; Mon, 12 May 2025 01:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1747039366; x=1747644166; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X+5YGsytKao/1xj60NvbEzUS05YJXuIqDnMKPWIykv4=; b=CnwiY725l/8rn3/SmX8jstVgTl0mcsK5ub+7f+XBgtEUMWwalseINQtAyayW9hPPaM lsd/otVFrSGXlrY656RrhDOoiou8oCf5Z55M+8otDkB85ILhSAw6nGMQAbVaUY+1KSDa NYkZQPNFAfufsbLtj8IFQerAcCoGMUxV+NPF/ubTAatdMxl5n/qNlujxDYwbJTJCLMHQ u9g9nwjLG76pNzK1usqlXHD018uYWXqbl5ADXdY9rTUFiAapBCScEh6kTZRrcsnUQ44Q i1eltUbncTej76UhQRltg8i99x3+HE4oD8OJO0VUKPoQWFr/SaDTDjl46XBfqihlQQBb SUYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747039366; x=1747644166; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X+5YGsytKao/1xj60NvbEzUS05YJXuIqDnMKPWIykv4=; b=Z/FiPPkzvHwWnwZDs0UsLW6Ms9wLV0rBJ07NhWShGVCWTN/aojUvTr2iT+k3XroHv6 Bq2owHffxuE2lTaX9JHz751npOZcy+5EticUOF4MCe+2cXje63k383BD+kZznuVlGPyI 6vwYCE1QrwW9Sj3QNmvfU5Ta7Hx29nDnDaDnSk6dIBB55O9RNeKglRIWVRDjTeqBUnm3 7NPpvwvI4/6Xk/xPKxMK9wvyDWpKnRFWjoUI7b5qp/sMaPgUatbsXLu+jEDbJ4WVnNxv SnADoPP7DmrwRFXd8dTMSC2mLhO7flLTXy39d3Jx+NCgoTWLDS8X81cJ9N/NlXkPZGY3 2O2w== X-Forwarded-Encrypted: i=1; AJvYcCUaVAVdV6k/ICMMUb0kYpPQHpefBhv6xaxgEjh7qem+H4nEBmd38DT7BsNoPGUlcF2/aeIFjjWeTQbB@vger.kernel.org X-Gm-Message-State: AOJu0YwOWU/LQfQlfg6BnUoUhtT4RFd+JPH0vdC2XzQcuXlaO3iu7Bfy yULC+B6/aLRu3+u//gO7geINX/+J7TMu513U44LJ21rFMkSMy7A5JWM+CnVzRbk= X-Gm-Gg: ASbGnct5tHasc6JuTSzSdoFfEOPBdCo42BeDqbMU7TUV/Mv1J1BWpfXeMNFNQejDnyw gk1Ust7INJ9MSGqeFVgHxDNeII38VUifL3oat2qVgB65VSiItmSB/UnLv+qvPDGWbKUlgQZOyLC ZTZl/lhjk0sdEV5lycrQPU1MxVLpZRA7u/VQrULArQHiI2GISWZgNDxZvfdlvWE/TCiWqzuDCuF dP5HHmstEALVu1t1RhTjoZhiFCVEGxWPML9rrspgWUKg5TqmaSJ5JtRUj2htjDMi16TDN3KMpX4 42nSQz9PGdzFNgopmH1EoG1PqbB8rPkbelkH/oR2+sJSQzyzOR6EQbnwe/oofxnYWao+HA== X-Google-Smtp-Source: AGHT+IEz7Q7VathijLmBODr/a+xLNbkuuG9lsRlC6Htr1xO5LtaIVMh8ToMMpvZPxZ7MXgvORUvBzQ== X-Received: by 2002:a17:903:166b:b0:224:c47:b6c3 with SMTP id d9443c01a7336-22fc8b0fa27mr146195415ad.6.1747039365955; Mon, 12 May 2025 01:42:45 -0700 (PDT) Received: from sunil-laptop ([103.97.166.196]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22fc7546aefsm58573605ad.37.2025.05.12.01.42.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 01:42:45 -0700 (PDT) Date: Mon, 12 May 2025 14:12:31 +0530 From: Sunil V L To: Andy Shevchenko Cc: Anup Patel , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jassi Brar , Thomas Gleixner , "Rafael J . Wysocki" , Mika Westerberg , Linus Walleij , Bartosz Golaszewski , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Palmer Dabbelt , Paul Walmsley , Len Brown , Rahul Pathak , Leyfoon Tan , Atish Patra , Andrew Jones , Samuel Holland , Anup Patel , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 21/23] irqchip/riscv-rpmi-sysmsi: Add ACPI support Message-ID: References: <20250511133939.801777-1-apatel@ventanamicro.com> <20250511133939.801777-22-apatel@ventanamicro.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, May 12, 2025 at 10:34:14AM +0300, Andy Shevchenko wrote: > On Sun, May 11, 2025 at 07:09:37PM +0530, Anup Patel wrote: > > > > Add ACPI support for the RISC-V RPMI system MSI based irqchip driver. > > ... > > struct fwnode_handle *fwnode; > ... > fwnode = dev_fwnode(dev); > > > + if (is_acpi_node(dev_fwnode(dev))) { > > + u32 nr_irqs; > > + > > + rc = riscv_acpi_get_gsi_info(dev_fwnode(dev), &priv->gsi_base, &id, > > + &nr_irqs, NULL); > > ...(fwnode, ...) > > ...and so on... > Sure. > > + if (rc) { > > + dev_err(dev, "failed to find GSI mapping\n"); > > + return rc; > > + } > > + > > + /* Update with actual GSI range */ > > + if (nr_irqs != priv->nr_irqs) > > + riscv_acpi_update_gsi_range(priv->gsi_base, priv->nr_irqs); > > + } > > > - if (is_of_node(dev_fwnode(dev))) > > + if (is_of_node(dev_fwnode(dev))) { > > of_msi_configure(dev, to_of_node(dev_fwnode(dev))); > > + } else { > > } else if (is_acpi_..._node(...)) { > Okay. > > + msi_domain = irq_find_matching_fwnode(imsic_acpi_get_fwnode(dev), > > + DOMAIN_BUS_PLATFORM_MSI); > > + dev_set_msi_domain(dev, msi_domain); > > + } > > ... > > > +#ifdef CONFIG_ACPI > > + if (!acpi_disabled) > > Why? > Same code as in the other patch. I will update this in the next version in case any change required. Thanks, Sunil