Re: [PATCH v8 02/11] mfd: Add max7360 support

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Fri, May 09, 2025 at 11:14:36AM +0200, mathieu.dubois-briand@bootlin.com wrote:
> 
> Add core driver to support MAX7360 i2c chip, multi function device
> with keypad, GPIO, PWM, GPO and rotary encoder submodules.

...

> + * Author: Kamel Bouhara <kamel.bouhara@bootlin.com>
> + * Author: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>

 * Authors:
	 Person A <...>
	 Person B <...>

?

...

> +	for (unsigned int i = 0; i < MAX7360_PORT_PWM_COUNT; i++) {
> +		ret = regmap_write_bits(regmap, MAX7360_REG_PWMCFG(i),
> +					MAX7360_PORT_CFG_INTERRUPT_MASK,
> +					MAX7360_PORT_CFG_INTERRUPT_MASK);
> +		if (ret)
> +			return dev_err_probe(dev, ret,
> +					     "Failed to write MAX7360 port configuration");

I think I already pointed out the missing '\n'.

> +	}

...

> +	/* Read GPIO in register, to ACK any pending IRQ. */
> +	ret = regmap_read(regmap, MAX7360_REG_GPIOIN, &val);
> +	if (ret)
> +		return dev_err_probe(dev, ret, "Failed to read GPIO values: %d\n", ret);

Double ret in the message. Check all of the usages of dev_err_probe() in your code.

> +	return 0;

...

> +#define MAX7360_REG_GPIO_LAST		0x5F

> +#define MAX7360_FIFO_EMPTY		0x3f
> +#define MAX7360_FIFO_OVERFLOW		0x7f

Please, be consistent in style of the values.

-- 
With Best Regards,
Andy Shevchenko