Re: [PATCH v2 1/3] arm64: dts: fvp: Add system timer for broadcast during CPU idle

[Liviu Dudau <liviu.dudau@arm.com>]

On Fri, May 09, 2025 at 04:46:38PM +0100, Sudeep Holla wrote:
> Introduce a system-level timer node in the FVP device tree to act as
> a broadcast timer when CPUs are in context losing idle states where
> the local timer stops on entering such low power states.
> 
> This change complements recent CPU idle state additions.
> 
> Tested-by: Leo Yan <leo.yan@arm.com>
> Message-Id: <20250508103225.354925-2-sudeep.holla@arm.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

For the whole series:

Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>

Best regards,
Liviu

> ---
>  arch/arm64/boot/dts/arm/fvp-base-revc.dts | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> v1->v2:
> 	- Dropped clock-frequency property
> 	- Fixed #size-cell to 1 as expected by the schema
> 	- Also update the ranges property and the frame reg property
> 
> diff --git a/arch/arm64/boot/dts/arm/fvp-base-revc.dts b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
> index 9e10d7a6b5a2..50b5993a2460 100644
> --- a/arch/arm64/boot/dts/arm/fvp-base-revc.dts
> +++ b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
> @@ -217,6 +217,19 @@ timer {
>  			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
>  	};
>  
> +	timer@2a810000 {
> +		compatible = "arm,armv7-timer-mem";
> +		reg = <0x0 0x2a810000 0x0 0x10000>;
> +		ranges = <0 0x0 0x2a820000 0x20000>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		frame@2a830000 {
> +			frame-number = <1>;
> +			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> +			reg = <0x10000 0x10000>;
> +		};
> +	};
> +
>  	pmu {
>  		compatible = "arm,armv8-pmuv3";
>  		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> -- 
> 2.34.1
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯