Re: [PATCH v3] ARM: dts: renesas: r9a06g032-rzn1d400-db: describe Debug LEDs

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]

Hi all,

thank you for providing all this input. I appreciate this a lot. And
please excuse the slow response. I am currently at the EmbeddedRecipes
conference which needed a bit of preparation on my side.

> So the node would look like this, for the pca1 LED:
> 
> led-1 {
> 	function = "pca1";
> 	color = <LED_COLOR_GREEN>;
> 	default-state = "keep";
> };

This looks optimal to me, if this is acceptable. I totally understand
the advantages and desire to unify LED naming. The main problem for me
here is that the GPIO-driven LEDs have no 'device' part in the generic
name. And only 'function:color' seems suboptimal for the board here in
question. I kinda arranged with the option of using "LED_FUNCTION_DEBUG"
for the above LEDs and some other function for the LED on the carrier
board. This seems OK enough for a development board, but ideal would be
the above solution. So, if you can live with the above, I'll happily
make use of it. If you want me to live with the different
LED_FUNCTION_* solution, I will survive this as well...

Happy hacking and greetings from Nice,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]