From: Niklas Cassel <cassel@kernel.org>
To: Shradha Todi <shradha.t@samsung.com>
Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.or, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org, manivannan.sadhasivam@linaro.org,
lpieralisi@kernel.org, kw@linux.com, robh@kernel.org,
bhelgaas@google.com, jingoohan1@gmail.com, krzk+dt@kernel.org,
conor+dt@kernel.org, alim.akhtar@samsung.com, vkoul@kernel.org,
kishon@kernel.org, arnd@arndb.de, m.szyprowski@samsung.com,
jh80.chung@samsung.com
Subject: Re: [PATCH 09/10] PCI: exynos: Add support for Tesla FSD SoC
Date: Mon, 19 May 2025 12:26:12 +0200 [thread overview]
Message-ID: <aCsHRJL3vP17FzZo@ryzen> (raw)
In-Reply-To: <20250518193152.63476-10-shradha.t@samsung.com>
On Mon, May 19, 2025 at 01:01:51AM +0530, Shradha Todi wrote:
> Add host and endpoint controller driver support for FSD SoC.
>
> Signed-off-by: Shradha Todi <shradha.t@samsung.com>
> ---
(snip)
> +static int fsd_pcie_raise_irq(struct dw_pcie_ep *ep, u8 func_no,
> + unsigned int type, u16 interrupt_num)
> +{
> + struct dw_pcie *pci = to_dw_pcie_from_ep(ep);
> +
> + switch (type) {
> + case PCI_IRQ_INTX:
> + case PCI_IRQ_MSIX:
> + dev_err(pci->dev, "EP does not support legacy IRQs\n");
Here you will print the same message for both INTX and MSIX.
Perhaps MSIX should have a separate print?
In fact, perhaps you want to call dw_pcie_ep_raise_intx_irq()
for case PCI_IRQ_INTX, since that function already has an error print.
Kind regards,
Niklas
next prev parent reply other threads:[~2025-05-19 10:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250518193219epcas5p24b442233b3e2bc2a92f43b71a126062f@epcas5p2.samsung.com>
2025-05-18 19:31 ` [PATCH 00/10] Add PCIe support for Tesla FSD SoC Shradha Todi
2025-05-18 19:31 ` [PATCH 01/10] PCI: exynos: Change macro names to exynos specific Shradha Todi
2025-05-18 19:31 ` [PATCH 02/10] PCI: exynos: Remove unused MACROs in exynos PCI file Shradha Todi
2025-05-21 9:41 ` Krzysztof Kozlowski
2025-05-27 10:42 ` Shradha Todi
2025-05-18 19:31 ` [PATCH 03/10] PCI: exynos: Reorder MACROs to maintain consistency Shradha Todi
2025-05-21 9:45 ` Krzysztof Kozlowski
2025-05-27 10:42 ` Shradha Todi
2025-05-18 19:31 ` [PATCH 04/10] PCI: exynos: Add platform device private data Shradha Todi
2025-05-21 9:44 ` Krzysztof Kozlowski
2025-05-27 10:43 ` Shradha Todi
2025-06-13 9:04 ` Manivannan Sadhasivam
2025-05-18 19:31 ` [PATCH 05/10] PCI: exynos: Add structure to hold resource operations Shradha Todi
2025-05-21 9:42 ` Krzysztof Kozlowski
2025-05-27 10:44 ` Shradha Todi
2025-05-18 19:31 ` [PATCH 06/10] dt-bindings: PCI: Add bindings support for Tesla FSD SoC Shradha Todi
2025-05-21 9:37 ` Krzysztof Kozlowski
2025-05-27 10:44 ` Shradha Todi
2025-05-18 19:31 ` [PATCH 07/10] dt-bindings: phy: Add PHY bindings support for " Shradha Todi
2025-05-21 9:33 ` Krzysztof Kozlowski
2025-05-27 10:44 ` Shradha Todi
2025-05-18 19:31 ` [PATCH 08/10] phy: exynos: Add PCIe PHY " Shradha Todi
2025-05-21 9:40 ` Krzysztof Kozlowski
2025-05-27 10:45 ` Shradha Todi
2025-05-28 7:21 ` Krzysztof Kozlowski
2025-05-18 19:31 ` [PATCH 09/10] PCI: exynos: Add support for Tesla " Shradha Todi
2025-05-19 10:26 ` Niklas Cassel [this message]
2025-05-21 9:48 ` Krzysztof Kozlowski
2025-05-27 10:45 ` Shradha Todi
2025-05-28 7:25 ` Krzysztof Kozlowski
2025-05-29 10:24 ` Shradha Todi
2025-05-18 19:31 ` [PATCH 10/10] misc: pci_endpoint_test: Add driver data for FSD PCIe controllers Shradha Todi
2025-05-19 9:59 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCsHRJL3vP17FzZo@ryzen \
--to=cassel@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.or \
--cc=lpieralisi@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=shradha.t@samsung.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox