Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses

Krzysztof Kozlowski
2025-05-19T15:05:46Z

On 19/05/2025 16:45, Wolfram Sang wrote:
>
>> You did not paste the warning in commit msg, so I don't know the
>> rationale, but at first glance this is not correct. "-0" is the
>> preferred suffix. "0" is not.
>
> Here is an example:
>
> .../Kernel/linux/arch/arm/boot/dts/microchip/usb_a9g20.dtb: i2c-gpio-0 (i2c-gpio): $nodename:0: 'i2c-gpio-0' does not match '^i2c(@.+|-[a-z0-9]+)?$'
> from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#
>

... so clearly the suffix is "-foo" or "-0", as we usually prefer. This
should be replaced into i2c-X, by dropping "gpio", instead of using less
favored suffixing (one without -).

Best regards,
Krzysztof