From: Andy Shevchenko <andy@kernel.org>
To: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Sergiu Cuciurean" <sergiu.cuciurean@analog.com>,
"Dragos Bogdan" <dragos.bogdan@analog.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Olivier Moysan" <olivier.moysan@foss.st.com>,
"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Tobias Sperling" <tobias.sperling@softing.com>,
"Alisa-Dariana Roman" <alisadariana@gmail.com>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Thomas Bonnefille" <thomas.bonnefille@bootlin.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 5/5] iio: adc: ad7405: add ad7405 driver
Date: Mon, 2 Jun 2025 18:01:18 +0300 [thread overview]
Message-ID: <aD28vs2_NA1jyPCE@smile.fi.intel.com> (raw)
In-Reply-To: <20250602134349.1930891-6-pop.ioan-daniel@analog.com>
On Mon, Jun 02, 2025 at 04:43:43PM +0300, Pop Ioan Daniel wrote:
> Add support for the AD7405/ADUM770x, a high performance isolated ADC,
> 1-channel, 16-bit with a second-order Σ-Δ modulator that converts an
> analog input signal into a high speed, single-bit data stream.
...
> +#include <linux/clk.h>
> +#include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/platform_device.h>
> +#include <linux/property.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/util_macros.h>
> +#include <linux/mutex.h>
You need to follow IFYU (Include What You Use) principle, at a glance there are
a few missing. Also make them ordered. I guess I have commented on this already
and my comment was ignored for no reason.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-02 15:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 13:43 [PATCH v5 0/5] Add support for AD7405/ADUM770x Pop Ioan Daniel
2025-06-02 13:43 ` [PATCH v5 1/5] iio: adc: ad4851: ad4851_set_oversampling_ratio parameters update Pop Ioan Daniel
2025-06-02 13:43 ` [PATCH v5 2/5] iio: backend: update iio_backend_oversampling_ratio_set Pop Ioan Daniel
2025-06-02 14:58 ` Andy Shevchenko
2025-06-02 13:43 ` [PATCH v5 3/5] iio: adc: adi-axi-adc: add axi_adc_oversampling_ratio_set Pop Ioan Daniel
2025-06-02 13:43 ` [PATCH v5 4/5] dt-bindings: iio: adc: add ad7405 Pop Ioan Daniel
2025-06-02 14:05 ` Krzysztof Kozlowski
2025-06-04 13:05 ` Ioan-daniel, Pop
2025-06-04 14:03 ` Krzysztof Kozlowski
2025-06-02 13:43 ` [PATCH v5 5/5] iio: adc: ad7405: add ad7405 driver Pop Ioan Daniel
2025-06-02 15:01 ` Andy Shevchenko [this message]
2025-06-02 16:59 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aD28vs2_NA1jyPCE@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alisadariana@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dragos.bogdan@analog.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=pop.ioan-daniel@analog.com \
--cc=robh@kernel.org \
--cc=sergiu.cuciurean@analog.com \
--cc=thomas.bonnefille@bootlin.com \
--cc=tobias.sperling@softing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).