From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57E4314E2F2 for ; Thu, 29 May 2025 11:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748517670; cv=none; b=JiVV9mVd091ktG1VANvhl4BRpiJlqhD7CAQpqnq4EeM8zPAmCNqMDTZRgs5UyYDrLkuWrS4o5K5FaeyTpiqESNIy8DORQ/5z6oXHLfqorO3MwCVRsyMrt6reAO4FaQAQr9acDyBNKhxT9QVW3hKhWT3iJdiP1hbkXs9UiIse6uQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748517670; c=relaxed/simple; bh=vShDvPk9+kZ+VCTHxgHNzgcGR8RHuX9zZUoWFOCLXxs=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F9CfVxCuR8cuyJtUyQbjwBEcAZGQT+U0jfMut15Og69iYZxfm4R9zs42f+IIcIr+QVJC91Q0zXdRcTdpWYE4600QneocKc6rE3rUE6uv+4GsXWvvIHdAc2fzVMvygAzwlHlfRihNWGhs11NiiRL3znegDaxQCzxhZlVS5875ST4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=gc5xKezy; arc=none smtp.client-ip=209.85.218.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="gc5xKezy" Received: by mail-ej1-f68.google.com with SMTP id a640c23a62f3a-acbb85ce788so142784066b.3 for ; Thu, 29 May 2025 04:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1748517666; x=1749122466; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=rgxPKVq6wwZTho8Z5w88rjxN+cD9bfwQRNHyzTFMlas=; b=gc5xKezy+JtGb+Mgob7PNk4l8ExuavrXvJSGef/+vfjXSvdEwuIrzjyMoPQ4jmlMfd xcnb9PLWXErsgnup7mW6xAZDX1SYqgl70IPtGLxWrX65O+VpNoJi8Ylj+l9odIpYzHCu +NRiCDkdtEVS/rsHIUgBzQvscdq8X5pJRB9GokGSzn1/DHJjOh8cRkSRSYSH7GPPRuYM au18y+e3N1sS+kJpCJDCHupopcp7GwNMmfi1Zjog5BXJuL+Wf9FGjBMR/qEknlbHJRUK 3S5M0FVrMi84GgeeHcvCKHwzA7n5kNBTgvdSYd2IFC6w6W2EuBqMVGugToXDgnqN/FRU h53A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748517666; x=1749122466; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rgxPKVq6wwZTho8Z5w88rjxN+cD9bfwQRNHyzTFMlas=; b=MfWc+BONPY9c3Gnb40RYZgeFlaMgBEN42dLW4lI0NaVQI3gU8rZX4G1/fvGrbFLf/N 2UV9ez/e2R/2YzYT4nqHX9RoHPZXjpXGjvbkgVqNUri9yXSd0wyHTt4m8WpUvh6ljwJo G0XnY15Qzwc5Mf2Q3IiZw043Thtp5w/dFLnLE1Q3wqn0XswoXOs3L49+6m35/UwnUeLT Sq84eUL4GRnupi1GPxcfuVfxRw3B/opQx+o90XRC+3Vev/Ye03QUAkedAELiEgSEYEun oRQxjXMiMpn7z7thfHa/PX+fBYUJxM4zQtcysfMyd5KoR5/v9jMK/M9GmMDrfQ+cVKhh 0ZkQ== X-Forwarded-Encrypted: i=1; AJvYcCV4dxNNrkKE+3eM/gmR4Pw1oKsoJQwSw85nUBwyACoPBmfZR5ySXREnxM50WEUySbpaVubJiP3kBQM6@vger.kernel.org X-Gm-Message-State: AOJu0YzPW46e8QMb7G7R/ikM/HhIqj3Nbun87ybC4XvZX5rQOBbc/TiF cenislcLLMj7mARNYsIxzji94Qa9hOQSN1nQamfFyvcYJbsjUM8RagPFsMw9RhUGXd4= X-Gm-Gg: ASbGnct0J/cEdzK8FSygRq8NwRVUSJabmcUXJ3X1qCMMLsXPK27gFIg+5GeNR9w7cYF 0au2eJSBUSdNNQ8T6UzhljtQl4iQ4B0gs5eZbKZvsf4yDXHUiM3TX2AxZX3N8iZeqYy5XB9/Tbm 880ODZzX3UESPAzi/TgQJo/p/YvJWJ3MpanrRIYPCQZlbGwT98iUJLMxDbpnA/8JnRhaqRWbuoF uydsSThDlgFlbnClgpLrbnf/8SgtjOG1icrnVoaIN5lzFot7u1/6QV911TKaQ7SHf+nGNd+TJxt nxGc/VBfKC0tQ08H5Kl/yaDTrLpYHIP1YXLKNlhzfBzq3yMvr881df4p618f1CNSZyLsjO9mrZm B5KKgmwvCixHbHT4zYBn6uuu/frGS1ix6 X-Google-Smtp-Source: AGHT+IHkWFZgWfVC3wsduslv1JW97TLkP+ID17A3dJTf4p7mD0EKIiXxaa5IifbRmSh1qLG7Wy61mg== X-Received: by 2002:a17:907:2d9e:b0:ad8:8efe:3206 with SMTP id a640c23a62f3a-adadeeb9748mr168671666b.42.1748517665519; Thu, 29 May 2025 04:21:05 -0700 (PDT) Received: from localhost (host-87-21-228-106.retail.telecomitalia.it. [87.21.228.106]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ada5d82d95bsm125977666b.57.2025.05.29.04.21.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 04:21:05 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 29 May 2025 13:22:40 +0200 To: Andrea della Porta Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn , Phil Elwell , Dave Stevenson , kernel-list@raspberrypi.com, Matthias Brugger Subject: Re: [PATCH v10 0/13] Add support for RaspberryPi RP1 PCI device using a DT overlay Message-ID: References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Please ignore this set since it has clobbered sequence number in subject. I'll resend it in a moment. Apologies for the inconvenience, Andrea On 12:49 Thu 29 May , Andrea della Porta wrote: > RP1 is an MFD chipset that acts as a south-bridge PCIe endpoint sporting > a pletora of subdevices (i.e. Ethernet, USB host controller, I2C, PWM, > etc.) whose registers are all reachable starting from an offset from the > BAR address. The main point here is that while the RP1 as an endpoint > itself is discoverable via usual PCI enumeraiton, the devices it contains > are not discoverable and must be declared e.g. via the devicetree. > > This patchset is an attempt to provide a minimum infrastructure to allow > the RP1 chipset to be discovered and perpherals it contains to be added > from a devictree overlay loaded during RP1 PCI endpoint enumeration. To > ensure compatibility with downstream, a devicetree already comprising the > RP1 node is also provided, so it's not strictly necessary to use the > dynamically loaded overlay if the devicetree is already fully defined at > the origin. > To achieve this modularity, the RP1 node DT definitions are arranged by > file inclusion as per following schema (the arrow points to the includer, > see also [9]): > > rp1-pci.dtso rp1.dtso > ^ ^ > | | > rp1-common.dtsi ----> rp1-nexus.dtsi ----> bcm2712-rpi-5-b.dts > ^ > | > bcm2712-rpi-5-b-ovl-rp1.dts > > Followup patches should add support for the several peripherals contained > in RP1. > > This work is based upon dowstream drivers code and the proposal from RH > et al. (see [1] and [2]). A similar approach is also pursued in [3]. > > The patches are ordered as follows: > > -PATCHES 1 to 3: add binding schemas for clock, gpio and RP1 peripherals. > They are needed to support the other peripherals, e.g. the ethernet mac > depends on a clock generated by RP1 and the phy is reset through the > on-board gpio controller. > > -PATCH 4 and 5: add clock and gpio device drivers. > > -PATCH 6: the devicetree node describing the RP1 chipset. > > -PATCH 7: this is the main patch to support RP1 chipset. It can work > either with a fully defined devicetree (i.e. one that already included > the rp1 node since boot time) or with a runtime loaded dtb overlay > which is linked as binary blob in the driver obj. This duality is > useful to comply with both downstream and upstream needs (see [9]). > The real dtso is in devicetree folder while the dtso in driver folder is > just a placeholder to include the real dtso. > In this way it is possible to check the dtso against dt-bindings. > The reason why drivers/misc has been selected as containing folder > for this driver can be seen in [6], [7] and [8]. > > -PATCH 8: add the external clock node (used by RP1) to the main dts. > > -PATCH 9: the fully fledged devictree containing also the rp1 node. > This devicetree is functionally similar to the one downstream is using. > > -PATCH 10 (OPTIONAL): this patch introduces a new scenario about how > the rp1 node is specified and loaded in DT. On top of the base DT > (without rp1 node), the fw loads this overlay and the end result is > the same devicetree as in patch 9, which is then passed to the next > stage (either the kernel or u-boot/bootloader). > While this patch is not strictly necessary and can therefore be dropped > (see [10]), it's not introducing much extra work and maybe can come > in handy while debugging. > > -PATCH 11: add the relevant kernel CONFIG_ options to defconfig. > > -PATCH 12: enable CONFIG_OF_OVERLAY in order for 'make defconfig' > to produce a configuration valid for the RP1 driver. Without this > patch, the user has to explicitly enable it since the misc driver > depends on OF_OVERLAY. > > -PATCH 13: collect all changes for MAINTAINERS file. > > This patchset is also a first attempt to be more agnostic wrt hardware > description standards such as OF devicetree and ACPI, where 'agnostic' > means "using DT in coexistence with ACPI", as been already promoted > by e.g. AL (see [4]). Although there's currently no evidence it will also > run out of the box on purely ACPI system, it is a first step towards > that direction. > > Many thanks, > Andrea della Porta > > Links: > - [1]: https://lpc.events/event/17/contributions/1421/attachments/1337/2680/LPC2023%20Non-discoverable%20devices%20in%20PCI.pdf > - [2]: https://lore.kernel.org/lkml/20230419231155.GA899497-robh@kernel.org/t/ > - [3]: https://lore.kernel.org/all/20240808154658.247873-1-herve.codina@bootlin.com/#t > - [4]: https://lore.kernel.org/all/73e05c77-6d53-4aae-95ac-415456ff0ae4@lunn.ch/ > - [5]: https://lore.kernel.org/all/20240626104544.14233-1-svarbanov@suse.de/ > - [6]: https://lore.kernel.org/all/20240612140208.GC1504919@google.com/ > - [7]: https://lore.kernel.org/all/83f7fa09-d0e6-4f36-a27d-cee08979be2a@app.fastmail.com/ > - [8]: https://lore.kernel.org/all/2024081356-mutable-everyday-6f9d@gregkh/ > - [9]: https://lore.kernel.org/all/Z87wTfChRC5Ruwc0@apocalypse/ > - [10]: https://lore.kernel.org/all/CAMEGJJ0f4YUgdWBhxvQ_dquZHztve9KO7pvQjoDWJ3=zd3cgcg@mail.gmail.com/#t > > CHANGES IN V10 > > > PATCH RELATED ------------------------------------------------- > > - Patch 10,11,12: Added: Reviewed-by: Reviewed-by: Florian Fainelli > > - Patches reworked to apply cleanly on broadcom/stblinux branches: > patch 1,2,3,6,8,9,10 -> devicetree/next > patch 11,12 -> defconfig/next > patch 4,5,7 -> drivers/next > patch 13 -> maintainers/next > > - Patch 13: new patch gathering all changes for MAINTAINERS > > > RP1 CLOCK DRIVER ------------------------------------ > > - Dropped some WARN_ONCE() lines that are basically useless > > - rp1_clock_set_parent() now returns EINVAL in case the parent check > is failing. As a result, rp1_clock_set_rate_and_parent() has also > been adapted to return rp1_clock_set_parent() retcode. > > - Return an ERR_PTR from rp1_register_clock() instead of just NULL > > - Dropped some unaesthetic blank lines > > - Disabled the builtin locking in regmap since we're already dealing > with concurrency in the code > > - rp1_clk_probe(): dropped dev_err_probe() as redundant due to commit > 12a0fd23e870 ("clk: Print an error when clk registration fails") >