public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Drew Fustini <drew@pdp7.com>
To: Michal Wilczynski <m.wilczynski@samsung.com>
Cc: Guo Ren <guoren@kernel.org>, Fu Wei <wefu@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Frank Binns <frank.binns@imgtec.com>,
	Matt Coster <matt.coster@imgtec.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 5/8] riscv: dts: thead: th1520: Add missing reset controller header include
Date: Sun, 1 Jun 2025 10:40:38 -0700	[thread overview]
Message-ID: <aDyQlqXhdgBAoR8D@x1> (raw)
In-Reply-To: <20250530-apr_14_for_sending-v3-5-83d5744d997c@samsung.com>

On Fri, May 30, 2025 at 12:23:52AM +0200, Michal Wilczynski wrote:
> TH1520_RESET_ID_GPU_CLKGEN and TH1520_RESET_ID_GPU are required for GPU
> power sequencing to work.  To make these symbols available, add the
> necessary include for the T-HEAD TH1520 reset controller bindings.
> 
> This change was dropped during conflict resolution [1].
> 
> [1] - https://lore.kernel.org/all/aAvfn2mq0Ksi8DF2@x1/
> 
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
> ---
>  arch/riscv/boot/dts/thead/th1520.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> index 1db0054c4e093400e9dbebcee5fcfa5b5cae6e32..bdbb1b985b0b76cf669a9bf40c6ec37258329056 100644
> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> @@ -7,6 +7,7 @@
>  #include <dt-bindings/interrupt-controller/irq.h>
>  #include <dt-bindings/clock/thead,th1520-clk-ap.h>
>  #include <dt-bindings/power/thead,th1520-power.h>
> +#include <dt-bindings/reset/thead,th1520-reset.h>
>  
>  / {
>  	compatible = "thead,th1520";
> 
> -- 
> 2.34.1
> 

Thanks for adding the header back now that there is no longer a
conflict. I'll look at the rest of this series and the rust pwm series
soon, but I just want to send a quick Rb on this patch right now.

Reviewed-by: Drew Fustini <drew@pdp7.com>

  reply	other threads:[~2025-06-01 17:40 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250529222402eucas1p1c9e0ddd3efd62e078e5de2cf71655f58@eucas1p1.samsung.com>
2025-05-29 22:23 ` [PATCH v3 0/8] Add TH1520 GPU support with power sequencing Michal Wilczynski
2025-05-29 22:23   ` [PATCH v3 1/8] dt-bindings: power: Add T-HEAD TH1520 GPU power sequencer Michal Wilczynski
2025-06-02 14:46     ` Bartosz Golaszewski
2025-06-02 20:29       ` Michal Wilczynski
2025-06-03 13:19         ` Krzysztof Kozlowski
2025-06-03 13:35           ` Bartosz Golaszewski
2025-06-03 14:49             ` Bartosz Golaszewski
2025-06-03 20:07               ` Michal Wilczynski
2025-06-03 18:24             ` Michal Wilczynski
2025-06-04  6:36               ` Bartosz Golaszewski
2025-05-29 22:23   ` [PATCH v3 2/8] power: sequencing: Add T-HEAD TH1520 GPU power sequencer driver Michal Wilczynski
2025-05-29 22:23   ` [PATCH v3 3/8] drm/imagination: Use pwrseq for TH1520 GPU power management Michal Wilczynski
2025-06-03 13:28     ` Krzysztof Kozlowski
2025-06-03 19:43       ` Michal Wilczynski
2025-06-04  6:36         ` Krzysztof Kozlowski
2025-06-04 11:53           ` Michal Wilczynski
2025-06-04 12:07             ` Krzysztof Kozlowski
2025-06-05  7:47               ` Michal Wilczynski
2025-06-05  8:10                 ` Bartosz Golaszewski
2025-06-05  9:07                   ` Krzysztof Kozlowski
2025-06-11 12:01                   ` Michal Wilczynski
2025-06-11 12:32                     ` Bartosz Golaszewski
2025-06-13  6:47                       ` Krzysztof Kozlowski
2025-06-13  6:44                     ` Krzysztof Kozlowski
2025-06-13  8:25                       ` Michal Wilczynski
2025-06-13  9:49                         ` Michal Wilczynski
2025-06-13 10:01                           ` Krzysztof Kozlowski
2025-06-13 10:41                         ` Bartosz Golaszewski
2025-05-29 22:23   ` [PATCH v3 4/8] dt-bindings: gpu: Add TH1520 GPU compatible to Imagination bindings Michal Wilczynski
2025-06-03 13:16     ` Krzysztof Kozlowski
2025-05-29 22:23   ` [PATCH v3 5/8] riscv: dts: thead: th1520: Add missing reset controller header include Michal Wilczynski
2025-06-01 17:40     ` Drew Fustini [this message]
2025-06-03 13:20     ` Krzysztof Kozlowski
2025-06-03 18:26       ` Michal Wilczynski
2025-06-03 18:49         ` Krzysztof Kozlowski
2025-05-29 22:23   ` [PATCH v3 6/8] riscv: dts: thead: Add GPU power sequencer node Michal Wilczynski
2025-06-03 13:22     ` Krzysztof Kozlowski
2025-06-03 18:45       ` Michal Wilczynski
2025-06-04 12:33         ` Bartosz Golaszewski
2025-05-29 22:23   ` [PATCH v3 7/8] riscv: dts: thead: th1520: Add IMG BXM-4-64 GPU node Michal Wilczynski
2025-06-03 12:27     ` Ulf Hansson
2025-06-04 12:40       ` Michal Wilczynski
2025-06-04 13:57         ` Ulf Hansson
2025-06-04 16:47       ` Matt Coster
2025-06-05  9:57         ` Ulf Hansson
2025-06-05 10:34           ` Matt Coster
2025-05-29 22:23   ` [PATCH v3 8/8] drm/imagination: Enable PowerVR driver for RISC-V Michal Wilczynski
2025-06-01 23:05   ` [PATCH v3 0/8] Add TH1520 GPU support with power sequencing Drew Fustini
2025-06-02  8:03     ` Michal Wilczynski
2025-06-02 17:33       ` Drew Fustini
2025-06-02 21:39         ` Drew Fustini
2025-06-03 12:25   ` Ulf Hansson
2025-06-03 18:29     ` Michal Wilczynski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDyQlqXhdgBAoR8D@x1 \
    --to=drew@pdp7.com \
    --cc=airlied@gmail.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frank.binns@imgtec.com \
    --cc=guoren@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=m.wilczynski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matt.coster@imgtec.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=ulf.hansson@linaro.org \
    --cc=wefu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox