From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAEC51FF5EC for ; Sun, 15 Jun 2025 11:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749986347; cv=none; b=cBTu75/obbw7dt793ICsQwEJB/UtxRzbRfZC1IQGFpGCySg5yYCQ0kPFAOlTqDFQquljhKSIG/+2Gu7UGLwMMsLRiG1j1TudjDWFIFyvynXle8Jw+xqzLH8+s9sRBhZRgf9qEAfpb66siupSbZiLxekFQUrU89vQkxp1gYlcpZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749986347; c=relaxed/simple; bh=gF1GA3PNMrglaz1x7lSK9qHYhHlMi5EIMwx9rYePviQ=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XIE08+35PZrD+QYr1WhvUuvtgeqOEssGcLanZp6qIDpAUyQ5+sTLgpNlG/vv+vsl6HSHlZH8tPcGynMkji1DlDfYW5OMQ67WSB803sr52rFgBOyPkfcAO2cYzFwFPIeuPO2C+iUiVtlgygQ77/uwzMbhypve67slhPQKsZQ3f/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NBLKidKM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NBLKidKM" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55F7WG8k009081 for ; Sun, 15 Jun 2025 11:19:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=nE42jDeZV4kQLeDasg3to65Y wacqdxTZYGetgGfNDoc=; b=NBLKidKM5EH5ybsjyd8wi0yty8kooDEv+8xTbz+h /7gXYgtHBXbwK4+3tgys6rVEB9QIrCQzLyFYP9gFR3dZxBpdLUZWtLv/14WJgJ53 8LecHek7U3W73nvA1eExXMKGnkRzMneUkDjQy4/Oh1w0JF1+rXOJ3Vuv/y0xmD45 y6j/pcp6H5y+wcmJgXTtyc+5BTmACOq9Af5tObOpVY0FJvd3H59fBb5PJey+HDRh M68rCUcSB7flweGX0OckX24qqANHJoKCiM7Ec1tP5zMq/5j8IbgUEZjoFbqp2ClE Pyk+YJoPZPQOozpvHJsHwLZ2nWUYWNTq2Y3HD3Dj+Wrc0g== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4792c9sr3g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 15 Jun 2025 11:19:03 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6fb1c6b5ea7so61298556d6.0 for ; Sun, 15 Jun 2025 04:19:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749986342; x=1750591142; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nE42jDeZV4kQLeDasg3to65YwacqdxTZYGetgGfNDoc=; b=TjFQqHUQFm+SqyEq7CpjJHPt0dMRBdemW8UKXBjtsCOTexmyptQk6nWlDyKAtiM5lV xAa2nbFsvBrHDQLeyLr9S0FuFMiRWmXc8ZA5QwXMwc6RYg3bYN7B4t4xbc/CwPZFxnnt kP2R2xZW0C+O4HaN4QW7MDvVplnATuBRyFj38ldH1KrBXVErWQLvYC49NiNkz5VCI7uy CeAl009aIKLlzF3L8CDHp7CZRWY+aVE+/eY8zxgfEPlJ09wDcf1Sn94p8PDMuv0pAeTt spzqL5abLWZouihIA8tdtZnrUjeIXeb7Iu3uMDHRfdHU+8vtugVNkYm06Hcy+QhFTkt/ 7YHA== X-Forwarded-Encrypted: i=1; AJvYcCVOdJELiKQuKK8mCaLOX5o3TPh7EnzZG60xSSoDCdzCxU6flLH01jaO8cwYd0x5b0+rNIQICuV7Py/Z@vger.kernel.org X-Gm-Message-State: AOJu0Yz74v4EU4bQHL94fae7UnJ131JST3PWx0WlYgxwGnfWs5Km3tb2 /DETMRj8FQe+gS46FdH77r+AQI2SZshLQ/JLDblfhoNZxAXnf+qGcByRMuQFbss3zGgW6CSu/HQ zLOZmVtm3oBuqT9db/yCe2FkhM4rQO4TVYiULo0god6UlIlosJij9wt1BR6RZAo6J X-Gm-Gg: ASbGncv5WYQWhd+VLNPKhf+HwBxh+Tf57UZ6u4EEl9YRRGAs8AIKIRfdUo3XPAliEHT jp13zYaAe+aFHamN2w97sVJph+vQ61mKA9rJU7ft9vWvevp5Ge7kbI6aAZTL/XbNZfP9pniZ53k iCRwDhLyAj4sRQ5Zxz/Vmhg2fqwy2R3Kx9uR5AeYkN9ptSc4Mh2kMfZFpuFtqPxIhZd+p200ATb h9KYak6xhEtN1fCoBfIy7Cajz7LA/Bo7lW+03w5JRQCgeD4ygFg4EX2yLvk1hgW0iDIz6p1RVBt MQWZWHzCfVHm6aCebUu8QtdHP40dsPvSqt85HJQmNwB5esZNlmTkzA9K2A== X-Received: by 2002:a05:6214:2422:b0:6fa:b980:8b01 with SMTP id 6a1803df08f44-6fb47737e2emr85660076d6.11.1749986342439; Sun, 15 Jun 2025 04:19:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtylU7MqmyhywN0wcxPac2FQB0KQyiAg+GFW2kr4hd3+fpGkWFId0S6/5eMvN1QXsfwA913g== X-Received: by 2002:a05:6214:2422:b0:6fa:b980:8b01 with SMTP id 6a1803df08f44-6fb47737e2emr85659736d6.11.1749986342023; Sun, 15 Jun 2025 04:19:02 -0700 (PDT) Received: from trex (132.red-79-144-190.dynamicip.rima-tde.net. [79.144.190.132]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532de8c2d2sm109836335e9.1.2025.06.15.04.19.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Jun 2025 04:19:01 -0700 (PDT) From: Jorge Ramirez X-Google-Original-From: Jorge Ramirez Date: Sun, 15 Jun 2025 13:18:55 +0200 To: Bryan O'Donoghue Cc: Jorge Ramirez-Ortiz , quic_vgarodia@quicinc.com, quic_dikshita@quicinc.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, stanimir.varbanov@linaro.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] arch: arm64: dts: qcom: qcm2290: Add venus video node Message-ID: References: <20250613140402.3619465-1-jorge.ramirez@oss.qualcomm.com> <20250613140402.3619465-3-jorge.ramirez@oss.qualcomm.com> <81a65ea6-2f46-4d11-9a3f-50664da78eea@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81a65ea6-2f46-4d11-9a3f-50664da78eea@linaro.org> X-Proofpoint-GUID: 42cBGhNJCj_CP-5e4fvsXMJnFxYBmGoM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE1MDA4NCBTYWx0ZWRfX2Tr23AdAjeO9 LrW1Bbi6JG+g5t2Ew9reYlHeb3oTIY1Xigex2/eE8SJ8clW/NOQ2m+yx6bZ2vYvtfaEhOCPzaBB ryjRhpaP3XurBav4ThaNUnx8NGakK9FlUoaCDhHe8w/zwWk3TbeDsAyJzSjK03nXENAz8MKL+q2 RLxTYtbiZ/+fkaIdCscg0nq9JBOkiwaMcrUVD/FTqHokgZ3JYb0/bf1IMKf0gV1M9DFs4XjKKWX mUprKYax5R53Gw5k+Fso/7uK14HVIYEyRKQzs0LNGXoTxJdKCRSqPBErB6RMxbq5IshExZrq21D VhVd5L9TiKbvDQORK6K/4iXcPvs5Ajvg0GFueZTjD1KKJXk6VINb9ODWZLsUfmIlpM4hU7kg0jr SaLUENiNsZCB6GV8H8Q85vfWfTbuZHAeiD2qIeJqz/AI87TcLZxqZ7Y5V45vNMaSSnKm0vMa X-Proofpoint-ORIG-GUID: 42cBGhNJCj_CP-5e4fvsXMJnFxYBmGoM X-Authority-Analysis: v=2.4 cv=etffzppX c=1 sm=1 tr=0 ts=684eac27 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=wjE3nLva0YkvARyJ+Gfmxg==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=EUspDBNiAAAA:8 a=Llyb1ICWO3Llu68erG4A:9 a=CjuIK1q_8ugA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-15_06,2025-06-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506150084 On 13/06/25 15:06:23, Bryan O'Donoghue wrote: > On 13/06/2025 15:03, Jorge Ramirez-Ortiz wrote: > > Add DT entries for the qcm2290 venus encoder/decoder. > > > > Signed-off-by: Jorge Ramirez-Ortiz > > --- > > arch/arm64/boot/dts/qcom/qcm2290.dtsi | 53 +++++++++++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi > > index f49ac1c1f8a3..af2c1f66fe07 100644 > > --- a/arch/arm64/boot/dts/qcom/qcm2290.dtsi > > +++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi > > @@ -1628,6 +1628,59 @@ adreno_smmu: iommu@59a0000 { > > #iommu-cells = <2>; > > }; > > + venus: video-codec@5a00000 { > > + compatible = "qcom,qcm2290-venus"; > > + reg = <0 0x5a00000 0 0xff000>; > > + interrupts = ; > > + > > + power-domains = <&gcc GCC_VENUS_GDSC>, > > + <&gcc GCC_VCODEC0_GDSC>, > > + <&rpmpd QCM2290_VDDCX>; > > + power-domain-names = "venus", "vcodec0", "cx"; > > + operating-points-v2 = <&venus_opp_table>; > > + > > + clocks = <&gcc GCC_VIDEO_VENUS_CTL_CLK>, > > + <&gcc GCC_VIDEO_AHB_CLK>, > > + <&gcc GCC_VENUS_CTL_AXI_CLK>, > > + <&gcc GCC_VIDEO_THROTTLE_CORE_CLK>, > > + <&gcc GCC_VIDEO_VCODEC0_SYS_CLK>, > > + <&gcc GCC_VCODEC0_AXI_CLK>; > > + clock-names = "core", "iface", "bus", "throttle", > > + "vcodec0_core", "vcodec0_bus"; > > + > > + memory-region = <&pil_video_mem>; > > + iommus = <&apps_smmu 0x860 0x0>, > > + <&apps_smmu 0x880 0x0>, > > + <&apps_smmu 0x861 0x04>, > > + <&apps_smmu 0x863 0x0>, > > + <&apps_smmu 0x804 0xE0>; > > + > > + interconnects = <&mmnrt_virt MASTER_VIDEO_P0 0 &bimc SLAVE_EBI1 0>, > > + <&bimc MASTER_APPSS_PROC 0 &config_noc SLAVE_VENUS_CFG 0>; > > + interconnect-names = "video-mem", "cpu-cfg"; > > + > > + venus_opp_table: opp-table { > > + compatible = "operating-points-v2"; > > + opp-133000000 { > > + opp-hz = /bits/ 64 <133000000>; > > + required-opps = <&rpmpd_opp_low_svs>; > > + }; > > + > > + opp-240000000 { > > + opp-hz = /bits/ 64 <240000000>; > > + required-opps = <&rpmpd_opp_svs>; > > + }; > > + }; > > + > > + video-decoder { > > + compatible = "venus-decoder"; > > + }; > > + > > + video-encoder { > > + compatible = "venus-encoder"; > > + }; > > These should be dropped in favour of static config in the driver. > OK > > + }; > > + > > mdss: display-subsystem@5e00000 { > > compatible = "qcom,qcm2290-mdss"; > > reg = <0x0 0x05e00000 0x0 0x1000>; > > --- > bod