devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Jain, Harsh (AECG-SSW)" <h.jain@amd.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	kernel test robot <lkp@intel.com>,
	"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Botcha, Mounika" <Mounika.Botcha@amd.com>,
	"Savitala, Sarat Chand" <sarat.chand.savitala@amd.com>,
	"Dhanawade, Mohan" <mohan.dhanawade@amd.com>,
	"Simek, Michal" <michal.simek@amd.com>
Subject: Re: [PATCH v2 5/6] crypto: xilinx: Fix missing goto in probe
Date: Tue, 10 Jun 2025 11:00:57 +0300	[thread overview]
Message-ID: <aEfmOQm0FtqtP22v@stanley.mountain> (raw)
In-Reply-To: <DS0PR12MB93454C9316C3C54E45BFD65B976AA@DS0PR12MB9345.namprd12.prod.outlook.com>

On Tue, Jun 10, 2025 at 06:28:22AM +0000, Jain, Harsh (AECG-SSW) wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
> 
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: Tuesday, June 10, 2025 11:48 AM
> > To: Jain, Harsh (AECG-SSW) <h.jain@amd.com>; herbert@gondor.apana.org.au;
> > davem@davemloft.net; linux-crypto@vger.kernel.org; devicetree@vger.kernel.org;
> > Botcha, Mounika <Mounika.Botcha@amd.com>; Savitala, Sarat Chand
> > <sarat.chand.savitala@amd.com>; Dhanawade, Mohan
> > <mohan.dhanawade@amd.com>; Simek, Michal <michal.simek@amd.com>
> > Cc: kernel test robot <lkp@intel.com>; Dan Carpenter <dan.carpenter@linaro.org>
> > Subject: Re: [PATCH v2 5/6] crypto: xilinx: Fix missing goto in probe
> >
> > Caution: This message originated from an External Source. Use proper caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > On 09/06/2025 06:51, Harsh Jain wrote:
> > > Add goto to clean up allocated cipher on reseed failure.
> > >
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > > Closes: https://lore.kernel.org/r/202505311325.22fIOcCt-lkp@intel.com/
> >
> > Please stop adding bugs and fixing them afterwards. Fix your patch first.
> 
> Hi Kozlowski,
> 
> After squashing this fix, Do I need to add "Reported-by, Closes" tag in original patch?
> 

Nope.

regards,
dan carpenter


  reply	other threads:[~2025-06-10  8:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09  4:51 [PATCH v2 0/6] Add Versal TRNG driver Harsh Jain
2025-06-09  4:51 ` [PATCH v2 1/6] dt-bindings: crypto: Add node for True Random Number Generator Harsh Jain
2025-06-09  6:37   ` Rob Herring (Arm)
2025-06-09 13:15   ` Rob Herring
2025-06-11  4:23     ` Jain, Harsh (AECG-SSW)
2025-06-09  4:51 ` [PATCH v2 2/6] crypto: xilinx: Add TRNG driver for Versal Harsh Jain
2025-06-09  4:51 ` [PATCH v2 3/6] crypto: drbg: Export CTR DRBG DF functions Harsh Jain
2025-06-09  4:51 ` [PATCH v2 4/6] crypto: xilinx: Select dependant Kconfig option for CRYPTO_DRBG_CTR Harsh Jain
2025-06-10  6:17   ` Krzysztof Kozlowski
2025-06-10  6:25     ` Jain, Harsh (AECG-SSW)
2025-06-09  4:51 ` [PATCH v2 5/6] crypto: xilinx: Fix missing goto in probe Harsh Jain
2025-06-10  6:18   ` Krzysztof Kozlowski
2025-06-10  6:28     ` Jain, Harsh (AECG-SSW)
2025-06-10  8:00       ` Dan Carpenter [this message]
2025-06-09  4:51 ` [PATCH v2 6/6] crypto: xilinx: Use min_t macro to compare value Harsh Jain
2025-06-10  6:18   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEfmOQm0FtqtP22v@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=Mounika.Botcha@amd.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=h.jain@amd.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=krzk@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=michal.simek@amd.com \
    --cc=mohan.dhanawade@amd.com \
    --cc=sarat.chand.savitala@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).