From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0541F24679B for ; Tue, 10 Jun 2025 18:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749581008; cv=none; b=WTlJxzC07edMvvZpHnsQlnQ7DWHnCbE6/j5ZP+SOC238zP4glue2373NRvgBbTgtJ5qIZbOQECx2oUK0h3Mvm4Y7GcnC+LGYk8teV3LDRfGDdBrbxpTqcdIrlIMgo36HzAK6C+PelD7bEVhEVhBDTFanR/sOXzy/jufgGg1Gq8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749581008; c=relaxed/simple; bh=H0nK1yRH6Fa3Tpm4vRAHHO9zV6GTdkLWgIgRr2wQc7w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I4TGZuMkUKsLY0qZGRZE86gIVnaVxs5md8Xxa0Nqx2OjlHdM3PkuwrO+SOHwEHaZcvhOU/uFFp7Jqpcyi4gPU7JOVf7W587oi+iC5vLdMHw+A8eb/eBSJnptC6HRjDg6F+QyzZBDJUKPdjuVvwacsh8myi7FdWsDETFdnvjbSV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com; spf=none smtp.mailfrom=pdp7.com; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b=LD3JVty0; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=pdp7.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b="LD3JVty0" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-235f9ea8d08so47152225ad.1 for ; Tue, 10 Jun 2025 11:43:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pdp7-com.20230601.gappssmtp.com; s=20230601; t=1749581005; x=1750185805; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+lDJBueIA7ygqvnNMLa8xo7uOqi0/yR422aJm+FXmc0=; b=LD3JVty0lsBLuy+zhnsT0bIMIanQeynuH7h20UEjG7957+twFBvXQ1FCG747DP7007 EYY2ZC09Xw/OAme9HWMzvYgCi5FSti1/IZXz/U20/7SU+4tAB6QrP7Dun5r0AnQ6pL/g 24Y1PZThmqrgj+VLJKCU0LSq6GNdlb8Z459lqV2oYIFeqStXNE377ysONghrHbu/LDvX t9zP4tlVnNQKs1C40dJVnn5/scHXOCQ/zWFi7getxDW9i+PJr2pfboz5uLgfJNZIUc1h 8Wwj55mZ/i4NIqA36c945RbmysTp7DjQTbN/VTgeZL55ezCBBmAeeAkdtVRQDy9mFBJt XJng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749581005; x=1750185805; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+lDJBueIA7ygqvnNMLa8xo7uOqi0/yR422aJm+FXmc0=; b=DHn272olFZ8aa6lwiU43H5PDuVMM0tI/f/re2hTwdE+DmtT7KZTn3kSOTinSyEq8XV OEj5NWVdTweCmVrwevKUw1qdPm57F0uNryCvxO6tK/xBMFxuTO+EDxhZB3k0G7cmC9Tz 9er+LxM9qQDAhJyWWQStO6tA5ft0jMuXIbmaIK1qOSaUX4nPNH8Mcjwb06UeSD406gY/ awFSQsytDcUXH955rcCinf4jv5Z8QNPlp5RO3Za0x1bu81NcISEDenxt6SBiTa5YNJLX iAgz2ibEY2DZru/GKDsAKiOPAlMW3J6UAXhXbGmPv6NixIEyRqeVYa9yijJZbMyFahsl vS4A== X-Forwarded-Encrypted: i=1; AJvYcCXwp+Ip5FiDNgDBDEKxVJ8g0WO0PsF1URZtM7BW6W4rmIg3yALsGqlasOtU/qFXlpNuG1SkrTl3YKYT@vger.kernel.org X-Gm-Message-State: AOJu0Yw/drzJNcqaJzhllzv6ze3GBQ6DoqOaGWf1PJ8QuJfAABNgXS4P wFMI3VYsh3v7ADg1Tzj6U5NEAUWwjbjSHTZGclNqwvhEMZBtD6EHYON/TDLofzyUW/s= X-Gm-Gg: ASbGncvYs6zUlqD6j4tsGHPNodgn9X9G4smSc1uWO7+GFnjufME0whY5hmwFuTwxgF9 1eMle2PkdB/yr4eL4CKrfbAvKRSlP1FZ0RepchGBUdG8mBoervzTlnT87QlZjQ/ssJKFK7nnGsW r3F815LyQEIyrh9XRjP+wyeJMKpaIFGuRy2ApVgUdIxR1FcY/ONywUTDmDkHFp8fUsBSD02yqeO AQst3pOiITt2zyYOu0gVPZ3vlNe6KvD5j3PC+L27aQQiqCp+7bDrvmvd83rKpSWZQxpSxFtmM+b 2HhicKDKbpuKymIIfyzVbjvoTWPpzo+c68NmgBlnVB0P0JmXWdDygEbHuPwohsEme+UY3c4xvQ= = X-Google-Smtp-Source: AGHT+IFsZ6Fe4BO0DoFerKCZiwMbhqQEYzPjvBgPPWjLKuOTaxg2oQ5N+H6uSTtx1zCOgQ7bs75qKg== X-Received: by 2002:a17:902:d586:b0:234:d7b2:2aa9 with SMTP id d9443c01a7336-23641b1aa38mr4058485ad.29.1749581004938; Tue, 10 Jun 2025 11:43:24 -0700 (PDT) Received: from x1 (97-120-245-201.ptld.qwest.net. [97.120.245.201]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b2f5f66a977sm7190114a12.43.2025.06.10.11.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 11:43:24 -0700 (PDT) Date: Tue, 10 Jun 2025 11:43:22 -0700 From: Drew Fustini To: Ira Weiny Cc: Dan Williams , Vishal Verma , Dave Jiang , nvdimm@lists.linux.dev, Oliver O'Halloran , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Conor Dooley Subject: Re: [PATCH v3] dt-bindings: pmem: Convert binding to YAML Message-ID: References: <20250606184405.359812-4-drew@pdp7.com> <6843a4159242e_249110032@dwillia2-xfh.jf.intel.com.notmuch> <6846f03e7b695_1a3419294dc@iweiny-mobl.notmuch> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 09, 2025 at 07:10:42PM -0700, Drew Fustini wrote: > On Mon, Jun 09, 2025 at 09:31:26AM -0500, Ira Weiny wrote: > > Dan Williams wrote: > > > [ add Ira ] > > > > > > Drew Fustini wrote: > > > > Convert the PMEM device tree binding from text to YAML. This will allow > > > > device trees with pmem-region nodes to pass dtbs_check. > > > > > > > > Acked-by: Conor Dooley > > > > Acked-by: Oliver O'Halloran > > > > Signed-off-by: Drew Fustini > > > > --- > > > > Dan/Dave/Vishal: does it make sense for this pmem binding patch to go > > > > through the nvdimm tree? > > > > > > Ira has been handling nvdimm pull requests as of late. Oliver's ack is > > > sufficient for me. > > > > > > Acked-by: Dan Williams > > > > > > @Ira do you have anything else pending? > > > > > > > I don't. I've never built the device tree make targets to test. > > > > The docs[1] say to run make dtbs_check but it is failing: > > > > $ make dtbs_check > > make[1]: *** No rule to make target 'dtbs_check'. Stop. > > make: *** [Makefile:248: __sub-make] Error 2 > > I believe this is because the ARCH is set to x86 and I don't believe > dtbs_check is valid for that. I work on riscv which does use device tree > so I use this command: > > make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- dtbs_check > > > > > > > > dt_binding_check fails too. > > > > $ make dt_binding_check > > SCHEMA Documentation/devicetree/bindings/processed-schema.json > > Traceback (most recent call last): > > File "/usr/bin/dt-mk-schema", line 8, in > > sys.exit(main()) > > ~~~~^^ > > File "/usr/lib/python3.13/site-packages/dtschema/mk_schema.py", line 28, in main > > schemas = dtschema.DTValidator(args.schemas).schemas > > ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^ > > File "/usr/lib/python3.13/site-packages/dtschema/validator.py", line 373, in __init__ > > self.make_property_type_cache() > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^ > > File "/usr/lib/python3.13/site-packages/dtschema/validator.py", line 460, in make_property_type_cache > > self.props, self.pat_props = get_prop_types(self.schemas) > > ~~~~~~~~~~~~~~^^^^^^^^^^^^^^ > > File "/usr/lib/python3.13/site-packages/dtschema/validator.py", line 194, in get_prop_types > > del props[r'^[a-z][a-z0-9\-]*$'] > > ~~~~~^^^^^^^^^^^^^^^^^^^^^^^ > > KeyError: '^[a-z][a-z0-9\\-]*$' > > make[2]: *** [Documentation/devicetree/bindings/Makefile:63: Documentation/devicetree/bindings/processed-schema.json] Error 1 > > make[2]: *** Deleting file 'Documentation/devicetree/bindings/processed-schema.json' > > make[1]: *** [/home/iweiny/dev/linux-nvdimm/Makefile:1522: dt_binding_schemas] Error 2 > > make: *** [Makefile:248: __sub-make] Error 2 > > > > How do I test this? > > dt_binding_check should work on x86. Maybe you don't have dtschema and > yamllint installed? > > You should be able to install with: > > pip3 install dtschema yamllint > > And run the binding check with: > > make dt_binding_check DT_SCHEMA_FILES=pmem-region.yaml > > You should see the following output: > > SCHEMA Documentation/devicetree/bindings/processed-schema.json > CHKDT ./Documentation/devicetree/bindings > LINT ./Documentation/devicetree/bindings > DTEX Documentation/devicetree/bindings/pmem/pmem-region.example.dts > DTC [C] Documentation/devicetree/bindings/pmem/pmem-region.example.dtb > > Thanks, > Drew I'm also on libera.chat [1] irc as drewfustini. There is a #devicetree channel where we should be able to get things sorted quickly if you are still getting those errors. Thanks, Drew [1] https://libera.chat/