Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses

Krzysztof Kozlowski
2025-05-19T13:54:52Z

On 19/05/2025 14:15, Wolfram Sang wrote:
> There shall not be a '-' before the number.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 8f02de8480b6..197de398dd9b 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -85,7 +85,7 @@ homepage-key {
> };
> };
>
> - i2c_max98504: i2c-gpio-0 {
> + i2c_max98504: i2c-gpio0 {

You did not paste the warning in commit msg, so I don't know the
rationale, but at first glance this is not correct. "-0" is the
preferred suffix. "0" is not.

Best regards,
Krzysztof