From: Danilo Krummrich <dakr@kernel.org>
To: Remo Senekowitsch <remo@buenzli.dev>
Cc: "Rob Herring" <robh@kernel.org>,
"Saravana Kannan" <saravanak@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Dirk Behme" <dirk.behme@de.bosch.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v8 0/9] More Rust bindings for device property reads
Date: Fri, 13 Jun 2025 01:31:04 +0200 [thread overview]
Message-ID: <aEtjONTgqDikCoB6@cassiopeiae> (raw)
In-Reply-To: <20250611102908.212514-1-remo@buenzli.dev>
On Wed, Jun 11, 2025 at 12:28:59PM +0200, Remo Senekowitsch wrote:
> Remo Senekowitsch (9):
> rust: device: Create FwNode abstraction for accessing device
> properties
> rust: device: Enable accessing the FwNode of a Device
> rust: device: Move property_present() to FwNode
> rust: device: Enable printing fwnode name and path
> rust: device: Introduce PropertyGuard
> rust: device: Implement accessors for firmware properties
> samples: rust: platform: Add property read examples
Applied to driver-core-testing, thanks!
Once the patches passed 0-day testing they will be merged into driver-core-next.
> rust: device: Add child accessor and iterator
> rust: device: Add property_get_reference_args
I did drop those two patches for now, because:
(1) They're basically dead code.
(2) It seems that FwNode::property_get_reference_args() leaks a struct
fwnode_handle reference. property_get_reference_args() explicitly says
that the caller is responsible "for calling fwnode_handle_put() on the
returned @args->fwnode pointer", which doesn't seem to happen.
Can you please fix the leak and resend those two patches with an additional one
that adds a sample usage of the introduced methods to the platform sample
driver?
next prev parent reply other threads:[~2025-06-12 23:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 10:28 [PATCH v8 0/9] More Rust bindings for device property reads Remo Senekowitsch
2025-06-11 10:29 ` [PATCH v8 1/9] rust: device: Create FwNode abstraction for accessing device properties Remo Senekowitsch
2025-06-11 10:29 ` [PATCH v8 2/9] rust: device: Enable accessing the FwNode of a Device Remo Senekowitsch
2025-06-11 10:29 ` [PATCH v8 3/9] rust: device: Move property_present() to FwNode Remo Senekowitsch
2025-06-11 12:08 ` Danilo Krummrich
2025-06-12 3:13 ` Viresh Kumar
2025-06-11 10:29 ` [PATCH v8 4/9] rust: device: Enable printing fwnode name and path Remo Senekowitsch
2025-06-11 10:29 ` [PATCH v8 5/9] rust: device: Introduce PropertyGuard Remo Senekowitsch
2025-06-11 10:29 ` [PATCH v8 6/9] rust: device: Implement accessors for firmware properties Remo Senekowitsch
2025-06-11 10:29 ` [PATCH v8 7/9] rust: device: Add child accessor and iterator Remo Senekowitsch
2025-06-11 10:29 ` [PATCH v8 8/9] rust: device: Add property_get_reference_args Remo Senekowitsch
2025-06-11 10:29 ` [PATCH v8 9/9] samples: rust: platform: Add property read examples Remo Senekowitsch
2025-06-11 12:06 ` [PATCH v8 0/9] More Rust bindings for device property reads Danilo Krummrich
2025-06-12 23:31 ` Danilo Krummrich [this message]
2025-06-13 7:45 ` Remo Senekowitsch
2025-06-13 8:50 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEtjONTgqDikCoB6@cassiopeiae \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dirk.behme@de.bosch.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=remo@buenzli.dev \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=saravanak@google.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).