From: Johan Hovold <johan@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Maximilian Luz <luzmaximilian@gmail.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
Steev Klimaszewski <steev@kali.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-efi@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v4 8/8] arm64: dts: qcom: sdm850-lenovo-yoga-c630: fix RTC offset info
Date: Thu, 26 Jun 2025 12:16:49 +0200 [thread overview]
Message-ID: <aF0eEWK8d-l1Mxma@hovoldconsulting.com> (raw)
In-Reply-To: <20250625-more-qseecom-v4-8-aacca9306cee@oss.qualcomm.com>
On Wed, Jun 25, 2025 at 01:53:27AM +0300, Dmitry Baryshkov wrote:
> Lenovo Yoga C630 as most of the other WoA devices stores RTC offset in
> the UEFI variable. Add corresponding property to the RTC device in order
> to make RTC driver wait for UEFI variables to become available and then
> read offset value from the corresponding variable.
This is not a fix so please drop that word from Subject.
I'd also expect you to mention that the RTC would be heavily crippled on
this machine as the efi variables cannot be updated.
Is there even a UEFI setup setting for this so that users that have
blown away Windows can ever set the time (which may become totally off
due to drift)?
I'm still not convinced that this is something we want, especially since
you could have a fully functional RTC by providing an SDAM offset
instead like we do on the sc8280xp CRD.
Johan
next prev parent reply other threads:[~2025-06-26 10:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 22:53 [PATCH v4 0/8] firmware: qcom: enable UEFI variables on Lenovo Yoga C630 Dmitry Baryshkov
2025-06-24 22:53 ` [PATCH v4 1/8] efi: efivars: don't crash in efivar_set_variable{,_locked} in r/o case Dmitry Baryshkov
2025-06-26 10:04 ` Johan Hovold
2025-06-26 11:03 ` Dmitry Baryshkov
2025-06-26 12:51 ` Johan Hovold
2025-06-26 12:54 ` Dmitry Baryshkov
2025-06-27 12:27 ` Johan Hovold
2025-06-28 15:05 ` Dmitry Baryshkov
2025-06-30 12:15 ` Johan Hovold
2025-06-24 22:53 ` [PATCH v4 2/8] firmware: qcom: scm: allow specifying quirks for QSEECOM implementations Dmitry Baryshkov
2025-06-24 22:53 ` [PATCH v4 3/8] firmware: qcom: uefisecapp: add support for R/O UEFI vars Dmitry Baryshkov
2025-07-16 19:13 ` Bjorn Andersson
2025-07-16 21:07 ` Dmitry Baryshkov
2025-06-24 22:53 ` [PATCH v4 4/8] firmware: qcom: enable QSEECOM on Lenovo Yoga C630 Dmitry Baryshkov
2025-06-24 22:53 ` [PATCH v4 5/8] firmware; qcom: scm: enable QSEECOM on SC8280XP CRD Dmitry Baryshkov
2025-06-26 23:34 ` Konrad Dybcio
2025-06-26 23:48 ` Dmitry Baryshkov
2025-06-26 23:54 ` Konrad Dybcio
2025-06-27 12:23 ` Johan Hovold
2025-06-27 12:26 ` Konrad Dybcio
2025-06-27 12:50 ` Johan Hovold
2025-06-28 14:50 ` Dmitry Baryshkov
2025-06-30 12:16 ` Johan Hovold
2025-07-16 19:02 ` Bjorn Andersson
2025-06-24 22:53 ` [PATCH v4 6/8] firmware: qcom: scm: add modparam to control QSEECOM enablement Dmitry Baryshkov
2025-06-26 10:11 ` Johan Hovold
2025-06-26 11:08 ` Dmitry Baryshkov
2025-06-26 12:58 ` Johan Hovold
2025-06-26 23:33 ` Dmitry Baryshkov
2025-06-27 12:46 ` Johan Hovold
2025-06-28 15:03 ` Dmitry Baryshkov
2025-06-30 12:42 ` Johan Hovold
2025-07-01 11:10 ` Dmitry Baryshkov
2025-07-10 9:40 ` Johan Hovold
2025-06-24 22:53 ` [PATCH v4 7/8] firmware: qcom: scm: rework QSEECOM allowlist Dmitry Baryshkov
2025-06-26 9:56 ` Johan Hovold
2025-06-26 11:09 ` Dmitry Baryshkov
2025-06-26 13:02 ` Johan Hovold
2025-06-24 22:53 ` [PATCH v4 8/8] arm64: dts: qcom: sdm850-lenovo-yoga-c630: fix RTC offset info Dmitry Baryshkov
2025-06-26 10:16 ` Johan Hovold [this message]
2025-06-26 11:10 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF0eEWK8d-l1Mxma@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=ardb@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=robh@kernel.org \
--cc=steev@kali.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).