From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Kamil Horák - 2N" <kamilh@axis.com>
Cc: florian.fainelli@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, andrew@lunn.ch,
hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, krzk+dt@kernel.org,
conor+dt@kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
f.fainelli@gmail.com, robh@kernel.org, andrew+netdev@lunn.ch
Subject: Re: [PATCH 3/3] net: phy: bcm54811: Fix the PHY initialization
Date: Thu, 26 Jun 2025 14:05:28 +0100 [thread overview]
Message-ID: <aF1FmEBzO1_-HOfD@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250626115619.3659443-4-kamilh@axis.com>
On Thu, Jun 26, 2025 at 01:56:19PM +0200, Kamil Horák - 2N wrote:
> + /* BCM54811 is not capable of LDS but the corresponding bit
> + * in LRESR is set to 1 and marked "Ignore" in the datasheet.
> + * So we must read the bcm54811 as unable to auto-negotiate
> + * in BroadR-Reach mode.
> + */
> + aneg = (BRCM_PHY_MODEL(phydev) != PHY_ID_BCM54811) ?
> + (val & LRESR_LDSABILITY) : 0;
Wouldn't:
if (BRCM_PHY_MODEL(phydev) == PHY_ID_BCM54811)
aneg = 0;
else
aneg = val & LRESR_LDSABILITY;
be more readable?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2025-06-26 13:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 11:56 [PATCH net 0/3] net: phy: bcm54811: Fix the PHY initialization Kamil Horák - 2N
2025-06-26 11:56 ` [PATCH 1/3] net: phy: MII-Lite PHY interface mode Kamil Horák - 2N
2025-06-26 13:02 ` Russell King (Oracle)
2025-06-26 11:56 ` [PATCH 2/3] dt-bindings: ethernet-phy: add MII-Lite phy interface type Kamil Horák - 2N
2025-06-26 11:58 ` Krzysztof Kozlowski
2025-06-26 11:56 ` [PATCH 3/3] net: phy: bcm54811: Fix the PHY initialization Kamil Horák - 2N
2025-06-26 13:05 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF1FmEBzO1_-HOfD@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=kamilh@axis.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).