From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B52441925AF for ; Mon, 16 Jun 2025 16:59:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750093148; cv=none; b=PwKoUXQysqkfIwI+vEzvS28y7vzCqGE+KaWgc0/gWNX//oDPu05Fc5OjGmna76k3dhtRFOr/yaWewjCuzNR3wJYX+xYLvkbQek0TEB+ADQM75FRgvc77l5+bpOS9vog5ZGoLVRSsspWHV6CO46hmwdhy25tZio/7jfo8PQCEy2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750093148; c=relaxed/simple; bh=MIOBf3dEjXwXgUhVNb7gUlmJhcwXvYUtCQF6Yhi/5k0=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NZnyOcEew5L5NCMjqOtSQwrgd77hhzFJF5OyAKdFH3ngg8By1ZP5p1qmGoqsGLmgso6FrNSevwEvIYdaz9QvIr4C4ZRonRgamrb/dg4f+10PHChKa8bC8kuoR2c3O8uwmVBmR7uwF7ccXzoI72k1G7SjK6kuv6D39y4QxK/1aO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bkMqISkQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bkMqISkQ" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55GGdDGV010074 for ; Mon, 16 Jun 2025 16:59:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=FJdkMaQ1ReNpm3CpJp7RD0NH vTLNJiLODdXF3EvzYqk=; b=bkMqISkQHPs6Qy2/EoBlx/hNdGSps472kLNnzYL2 Jbrhzvk0jefTxbNq/R1CFeUMXeqIJwAdn/Kpo/wqTOtjvW7tW1jIJDH/RpvFe1gt GkUNBT6mMUEksFy07eN8vzrl1PxJ3+3/Hynr9U1jRpl3blv45/Cqyp5f4253IsIq Tqd1vZ6lBilYRSe6yMI7If/Aw2Bbyra4Z91nQm/UP7/PdSXNjl3HiY1HUtYS/9Ee hDvfe9916LeIIH4EGA6/eno/ytTnh2s0zEHBSkUqt+MAOiU0HmD4mLjzmkAaHyaU vft6OhHvNZyD9BeWNIMw64IHdvTmZXeGnd7gHjTz39W2oQ== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4791hfdccb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 16 Jun 2025 16:59:05 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6fab979413fso92318026d6.2 for ; Mon, 16 Jun 2025 09:59:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750093144; x=1750697944; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FJdkMaQ1ReNpm3CpJp7RD0NHvTLNJiLODdXF3EvzYqk=; b=Etfv+QcLkeZsOMv/waeCtkPNBRWBVSpUSAIY5qQWLJvKJNMOs0A3QFeZ7pQC2cempx krWryG0+y1gI47WP2tihKhSKB30Y2hF7MRyqGE5WgEnVlfoVML11Ab65CgY6xBcTCzbS 6EAr1k1Hwl4CoHtR4QA+DDopdBKlZK47TqebYkFH0x4zduDEsoyA+p75SH0EFeinl8yj /CTDXXSJTLkuWI46ZZvddqMzAYDX/pbnq5GwjSfFNr5Oxo1A0MqOH3PSUZJKbHvVCh/x x6lSoaMw+gmNiUwLjhojTpHQU1oJ9xxAvkCiwLaqioxuN6BuBVGurIP8GtT5UQUDtbTl kOIw== X-Forwarded-Encrypted: i=1; AJvYcCXNxIAMa2i0zsaaStxv37aVLaEEHr1pAlztDVkw8TlWKqOTIK4jhaLNiRyM7uNgOlv+l8LhZxhZLj1c@vger.kernel.org X-Gm-Message-State: AOJu0YyC227fmSndYm7GczIa+IWw8YLAMyerqmGrMxiv3IQpl9IeOo30 YvEJjcl+66VwEZvvzK4uo12F1sxkjimIdkQlxsffjyKsqUE76UHtQ0zjn5C8I1druZMkkzvUVXi Xgi8zE/ff6lUPQbOjGkgLnRVCdqSWOnU76tfnUe34P+rScgRM8aQFhBYyKxU0lgbJ X-Gm-Gg: ASbGncsK/HIojFbfFEM2XTzcFOkegUt7g7PcMco+6eCkhFhZwMnxFDSM9+iuj06UIi6 whsB8tUXnyKeE3rQHl6GR76aTnBv9pNPRoIy2lnoQIOgumOXGlYzm0l0NR7xHNxh653qv9/I33x KlRHU8b2nGPm6cYrj/VKXqlb24vxRSKKmMumoZOjw6MdMLmwK4AzCBFTwU6E5vNBnsjQVcnkmLe l+I1017MsuG00FvswIfmmnVVSgXhZHzT/iMEXJPIONULOUonAHCZ9mEy0tG9O1Zz8nWKFZVKf0A DOab8Rf0Zy13GB7H5FY8ZsBj313EjGMTazK701pkwxXouV69KjRAsqXirw== X-Received: by 2002:a05:6214:27c5:b0:6fa:c6c0:47da with SMTP id 6a1803df08f44-6fb477a727bmr178575966d6.42.1750093144375; Mon, 16 Jun 2025 09:59:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8U5C8QhpEC4KdiGlgGaaVVFIxxyTSoWxHWPCgyJSirN8Hl1LiLepE8Okozp2BZa+B3WqlBg== X-Received: by 2002:a05:6214:27c5:b0:6fa:c6c0:47da with SMTP id 6a1803df08f44-6fb477a727bmr178575296d6.42.1750093143917; Mon, 16 Jun 2025 09:59:03 -0700 (PDT) Received: from trex (132.red-79-144-190.dynamicip.rima-tde.net. [79.144.190.132]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e2324c6sm147831535e9.12.2025.06.16.09.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 09:59:03 -0700 (PDT) From: Jorge Ramirez X-Google-Original-From: Jorge Ramirez Date: Mon, 16 Jun 2025 18:59:02 +0200 To: Krzysztof Kozlowski Cc: Jorge Ramirez , quic_vgarodia@quicinc.com, quic_dikshita@quicinc.com, bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, stanimir.varbanov@linaro.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] dt-bindings: media: venus: Add qcm2290 dt schema Message-ID: References: <20250613140402.3619465-1-jorge.ramirez@oss.qualcomm.com> <20250613140402.3619465-2-jorge.ramirez@oss.qualcomm.com> <6f4e715f-1c73-450e-b7eb-92781b7fa050@kernel.org> <48e6cc62-ffb0-4ca7-80c8-9e510db505db@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48e6cc62-ffb0-4ca7-80c8-9e510db505db@kernel.org> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE2MDExMSBTYWx0ZWRfX02aetPicbILJ ty15j3opjt5/Zn2WD+m66+fcfpUkmmpFknzXEs0oXgRT5BsUV+XPOb17dsJ39GNtcQTE5ScBII0 nLc2sL4Xx5uKLFRiORfygGdES90cByHlZM1ZtzPSoVOu9dFC0AJTeim4H9+9LWUNQ7vM9DfmdDm tCShdpOObbzkmvutItXG1ZmGrAWCgjAav8zkNtWqWzb783To9PUUM2WDNAaxkzvmT1tY/iCYEkk vh0FGX3y0KIj/nPVzY8oqhtt9W1mMsW+0SLfEVB2pJlhcuCsTPjKrBuJVQdtDqYfG4yd3FF51Ll jRTAcAbZoRPW4XJzsC5JmxlSFjYYIDyQJ7uuUFDivKNDFCmMFk3ILbZ3Yp0w6fQmNVjtc+qlGlh uaP2ym4lA248FTRnSLpW6VYCLHLpu+EIZMhFm1PzEY7T2FTDFCh1elvOMpnJMhlziIMS9xoR X-Authority-Analysis: v=2.4 cv=VvEjA/2n c=1 sm=1 tr=0 ts=68504d59 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=wjE3nLva0YkvARyJ+Gfmxg==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=3XfI71V93UcfWaPxk40A:9 a=CjuIK1q_8ugA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-GUID: 4HiQ9VOkpD2aR5b4k4XKmJiV5JxutfzZ X-Proofpoint-ORIG-GUID: 4HiQ9VOkpD2aR5b4k4XKmJiV5JxutfzZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-16_08,2025-06-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 lowpriorityscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 impostorscore=0 clxscore=1015 bulkscore=0 suspectscore=0 priorityscore=1501 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506160111 On 16/06/25 18:23:18, Krzysztof Kozlowski wrote: > On 16/06/2025 18:18, Jorge Ramirez wrote: > > On 16/06/25 16:41:44, Krzysztof Kozlowski wrote: > >> On 16/06/2025 14:52, Jorge Ramirez wrote: > >>>> > >>>>> + The Venus AR50_LITE IP is a video encode and decode accelerator present > >>>>> + on Qualcomm platforms > >>>>> + > >>>>> +allOf: > >>>>> + - $ref: qcom,venus-common.yaml# > >>>>> + > >>>>> +properties: > >>>>> + compatible: > >>>>> + const: qcom,qcm2290-venus > >>>>> + > >>>>> + power-domains: > >>>>> + minItems: 2 > >>>>> + maxItems: 3 > >>>>> + > >>>>> + power-domain-names: > >>>>> + minItems: 2 > >>>> > >>>> Why is this flexible? Either you have two or three. Not mixed. > >>> > >>> please check 5b380f242f360256c96e96adabeb7ce9ec784306 > >> > >> This does not explain why this is optional HERE. You cannot use for a > >> new platform an argument that some existing platform was changed in > >> ABI-preserving way. > > > > thanks for quick the follow up. > > > > but bear with me please because I dont follow - why can the same logic > > be used - it being applicable - and therefore result in a definition > > similar to those other platforms? > > Because this platform either has 2 or 3, not both. Unless that's not > true, but then please share some arguments. as with every other venus schema with more than 1 power domain, the argument is the same one that I have shared with you a couple of messages back (DVFS). verbatim: Venus needs to vote for the performance state of a power domain (cx) to be able to support DVFS. This 'cx' power domain is controlled by rpm and is a common power domain (scalable) not specific to venus alone. This is optional in the sense that, leaving this power domain out does not really impact the functionality but just makes the platform a little less power efficient. Seeing all these venus schemas follow the same pattern, it seems to me that this is the correct way of implementing the above. You seem to disagree. please could you explain? > > Best regards, > Krzysztof