From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B662257D for ; Thu, 19 Jun 2025 02:50:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750301421; cv=none; b=EI3eAiUA29hwtLNaGWyE3BTNM7Ivbe8FO9UwXWRhz/isDRPYlOv6dzTA/9F0QazthTNiM1K8FPazW6chkBHspxVbNNBrK6ujwPCI8CUj9lpm/W1dNIISH9yDv0CTjcx8arZyM39GxtVSiwNM5F6HgDZdUKW5aCtF+k+XrfQTZn4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750301421; c=relaxed/simple; bh=iJcBSfG+nm1MBrPhYrWZUr0TYe4Yf60WLTUAK/r6mlw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ESUetTOOlRV0L0ZeI6d0H/tHpTq7y+tT5liggTJ4S344OqXFzm8NvF+hNvjKhIexqllcw70LYzTW6znvJQGXhxW1fkpQsKlvetZGWpZLVEYejEsF6FyzGgOlmma1rWIspbr3T3wUhHeb7OD56cqD0GmAxqMoya3WfSmzBcRsMIc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com; spf=none smtp.mailfrom=pdp7.com; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b=zClKA5Nd; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=pdp7.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b="zClKA5Nd" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-b2f1032e1c4so386909a12.3 for ; Wed, 18 Jun 2025 19:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pdp7-com.20230601.gappssmtp.com; s=20230601; t=1750301419; x=1750906219; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tB8e1qVEfhuTIR6cCezHfjL1333Oy60fxLgjuSXst14=; b=zClKA5NdFcZ7xzosWBVTfvmjeZPelkG4jwrzZbQyED0OmTl33fOCymfsbml1aK8kpS 9RPQQi47CRyXeiYOKxKUtzgRn6kp+42sc0jRVTyMZbk/YyOmzAIXJpGFtjcmiYMpwSFg BpiiDip0wgt4aHHg4ylo4fPxR/0PpQpo1px11+/UNF5KnxbPfVhqNNv8bfISlgrj8K0m T6nyAKD8jXiZK9YWJbNk+GM2uMjlBpqqNaWfETMCwX+Nt+lI1FP0c0MkCyDLY3+90LAt yexXJsaieGoEt/z+o8QCYZk2u6GppGJJf9v+5bJmXyxKTk05cEy0VVjJrhK7VZLBAYW8 ZqAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750301419; x=1750906219; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tB8e1qVEfhuTIR6cCezHfjL1333Oy60fxLgjuSXst14=; b=Tgieh2DUT5CDLLfXCMRXF3rmrnGLdUGf1kAJpCGT1fPM+C8D7edXlK7CXYuEH2XrLf CEusigMHk9mF1Tn0+g9+lNY8SztLtjFl1xgoXAdMuJcL7JXt2ZTNkKkLKHoOg71ceIMR CDotfYa8MzxprwXEOSEqFdW2zDO0tH87bwXnNlAZYV3xv3CsJSpvGxDOU/P/n5rx/SKK KhKsUqc6zEaA0MicckQxY29g2rm0aQosuhrbgNASQMFdr24HQq6OsSQEBc2gkdDT8Xcq IrtIymqPzZegtgGxlvKj8OmSEZ30HwUxjvozrbbia0Z3hqr16GApXzsQ1hafpR3UGCxw QMGA== X-Forwarded-Encrypted: i=1; AJvYcCVXqNGnGie/A7VuBZnKqO3IyYkpZePo1E9BS9CL7+TE7QPIGxAEG7wUsS/oIqa50Yd1qnU7B2hfXuHD@vger.kernel.org X-Gm-Message-State: AOJu0YwC3TLd4Cq8Sd2MKeRK4Mo59lKRgWZNf/18Fl0CRuMqZaBu6iQV lxIxmB/PFLXD+NcUoV4CApt+OuApZO/lG0hy22zaHBi3ft3tJZF5nkhSBoHy5Farxus= X-Gm-Gg: ASbGncuKABGSZjA7CyJ+DmUHVVeDOCCtf17EtIsN06rIw6gvj9sMb/WSOzml6CgSgai tLqDlCp6RaPBduDi9FJS3QAAd+fv2z32Tqiymax2KgzMuaVS3UDe5kdIQxnE/hagZMq0LF1W9I6 w323mSvvY6/vs3OsWCEniLCFs73IoL9/zG0o+qrFzUdxZDmAyk1cBySrrWQoXKiR3itAE5E0hwm bUA52foUZQe4yDjp6pX+5jPcDQIm8k2YztHr7eyFpA3mvA0sw48YRu57MuGCRoTokUu/SvaIWCR xi3mlzKLtf4bjzDCJoUSTCcQuRQKKWMl2Zc0qhrpNhdF+E5PYeuONLBuT9qLozkOGMl6FKA= X-Google-Smtp-Source: AGHT+IFubn9Xjjn7fmMto+xZqblm2yd0WPXfa0iuVG1BkV+6lAGb7+2YAe7yAyYCgSsbecVsjsPVIw== X-Received: by 2002:a17:90b:524b:b0:311:ab20:159a with SMTP id 98e67ed59e1d1-313f1d1c00cmr26840306a91.29.1750301418839; Wed, 18 Jun 2025 19:50:18 -0700 (PDT) Received: from x1 (97-120-250-80.ptld.qwest.net. [97.120.250.80]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3158a25617asm985583a91.33.2025.06.18.19.50.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jun 2025 19:50:18 -0700 (PDT) Date: Wed, 18 Jun 2025 19:50:16 -0700 From: Drew Fustini To: Michal Wilczynski Cc: Guo Ren , Fu Wei , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Philipp Zabel , Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Ulf Hansson , Marek Szyprowski , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v5 7/8] riscv: dts: thead: th1520: Add IMG BXM-4-64 GPU node Message-ID: References: <20250618-apr_14_for_sending-v5-0-27ed33ea5c6f@samsung.com> <20250618-apr_14_for_sending-v5-7-27ed33ea5c6f@samsung.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250618-apr_14_for_sending-v5-7-27ed33ea5c6f@samsung.com> On Wed, Jun 18, 2025 at 12:22:13PM +0200, Michal Wilczynski wrote: > Add a device tree node for the IMG BXM-4-64 GPU present in the T-HEAD > TH1520 SoC used by the Lichee Pi 4A board. This node enables support for > the GPU using the drm/imagination driver. > > By adding this node, the kernel can recognize and initialize the GPU, > providing graphics acceleration capabilities on the Lichee Pi 4A and > other boards based on the TH1520 SoC. > > Add fixed clock gpu_mem_clk, as the MEM clock on the T-HEAD SoC can't be > controlled programatically. > > Reviewed-by: Ulf Hansson > Signed-off-by: Michal Wilczynski > --- > arch/riscv/boot/dts/thead/th1520.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi > index f3f5db0201ab8c0306d4d63072a1573431e51893..c8447eef36c3a6e92d768658b6b19dfeb59a47c4 100644 > --- a/arch/riscv/boot/dts/thead/th1520.dtsi > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi > @@ -225,6 +225,13 @@ aonsys_clk: clock-73728000 { > #clock-cells = <0>; > }; > > + gpu_mem_clk: mem-clk { > + compatible = "fixed-clock"; > + clock-frequency = <0>; > + clock-output-names = "gpu_mem_clk"; > + #clock-cells = <0>; > + }; > + > stmmac_axi_config: stmmac-axi-config { > snps,wr_osr_lmt = <15>; > snps,rd_osr_lmt = <15>; > @@ -500,6 +507,21 @@ clk: clock-controller@ffef010000 { > #clock-cells = <1>; > }; > > + gpu: gpu@ffef400000 { > + compatible = "thead,th1520-gpu", "img,img-bxm-4-64", > + "img,img-rogue"; > + reg = <0xff 0xef400000 0x0 0x100000>; > + interrupt-parent = <&plic>; > + interrupts = <102 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk_vo CLK_GPU_CORE>, > + <&gpu_mem_clk>, > + <&clk_vo CLK_GPU_CFG_ACLK>; > + clock-names = "core", "mem", "sys"; > + power-domains = <&aon TH1520_GPU_PD>; > + power-domain-names = "a"; > + resets = <&rst TH1520_RESET_ID_GPU>; > + }; > + > rst: reset-controller@ffef528000 { > compatible = "thead,th1520-reset"; > reg = <0xff 0xef528000 0x0 0x4f>; > > -- > 2.34.1 > Reviewed-by: Drew Fustini