From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Victor.Duicu@microchip.com, dlechner@baylibre.com,
nuno.sa@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, robh@kernel.org, andy@kernel.org,
krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
Marius.Cristea@microchip.com, conor+dt@kernel.org
Subject: Re: [PATCH v3 2/2] iio: temperature: add support for MCP998X
Date: Mon, 23 Jun 2025 09:45:36 +0300 [thread overview]
Message-ID: <aFj4EI5CEIIQ8adl@smile.fi.intel.com> (raw)
In-Reply-To: <20250621181946.28d831ac@jic23-huawei>
On Sat, Jun 21, 2025 at 06:19:46PM +0100, Jonathan Cameron wrote:
> On Thu, 19 Jun 2025 11:29:30 +0300
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Thu, Jun 19, 2025 at 10:22 AM <Victor.Duicu@microchip.com> wrote:
> > > On Sat, 2025-06-14 at 00:50 +0300, Andy Shevchenko wrote:
> > > > On Fri, Jun 13, 2025 at 4:02 PM <victor.duicu@microchip.com> wrote:
...
> > > > > +MICROCHIP MCP9982 TEMPERATURE DRIVER
> > > > > +M: Victor Duicu <victor.duicu@microchip.com>
> > > > > +L: linux-iio@vger.kernel.org
> > > > > +S: Supported
> > > > > +F:
> > > > > Documentation/devicetree/bindings/iio/temperature/microchip,mcp9982
> > > > > .yaml
> > > > > +F: drivers/iio/temperature/mcp9982.c
> > > >
> > > > So, with the first patch only the dangling file will be present
> > > > without record in MAINTAINERS. Please, make sure that your DT schema
> > > > file is in MAINTAINERS.
> > >
> > > Are you referring here to the file sysfs-bus-iio-temperature-mcp9982?
> > > This file was in v2 where there were a few custom attributes. In v3
> > > I removed them, so the driver currently doesn't have custom attributes.
> > > Should I had added it to the files in MAINTAINERS?
> >
> > You should have added the file to the MAINTAINERS in the same patch it
> > appears. Not in some arbitrary change afterwards.
>
> Perhaps the confusion here is that Andy is talking about 2 lines above, not
> the immediate line above this feedback. So the one with the dt-binding
> file. If Victor was reading it as being about the .c file then
> this whole cross discussion makes more sense!
Yep, sorry for the confusion. My point is that the first patch in the series
added a file, it should start a MAINTAINERS at the same time.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-23 6:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 13:02 [PATCH v3 0/2] add support for MCP998X victor.duicu
2025-06-13 13:02 ` [PATCH v3 1/2] dt-bindings: iio: temperature: " victor.duicu
2025-06-13 14:40 ` Conor Dooley
2025-06-23 13:07 ` Victor.Duicu
2025-07-28 13:01 ` Victor.Duicu
2025-07-29 16:27 ` David Lechner
2025-06-13 13:02 ` [PATCH v3 2/2] " victor.duicu
2025-06-13 21:50 ` Andy Shevchenko
2025-06-19 7:22 ` Victor.Duicu
2025-06-19 8:29 ` Andy Shevchenko
2025-06-21 17:19 ` Jonathan Cameron
2025-06-23 6:45 ` Andy Shevchenko [this message]
2025-06-14 13:18 ` Jonathan Cameron
2025-06-14 13:27 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFj4EI5CEIIQ8adl@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Marius.Cristea@microchip.com \
--cc=Victor.Duicu@microchip.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).