* [PATCH 1/2] arm64: dts: imx8mm: Configure DMA on UART2
@ 2025-06-21 11:23 Adam Ford
2025-06-21 11:23 ` [PATCH 2/2] arm64: dts: imx8mn: " Adam Ford
2025-06-21 17:07 ` [PATCH 1/2] arm64: dts: imx8mm: " Fabio Estevam
0 siblings, 2 replies; 4+ messages in thread
From: Adam Ford @ 2025-06-21 11:23 UTC (permalink / raw)
To: linux-arm-kernel
Cc: aford, Adam Ford, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
devicetree, imx, linux-kernel
UART2 is often used as the console, so the DMA was likely left
off on purpose, since it's recomended to not use the DMA on the
console. Beacause, the driver checks to see if the UART is used for
the console when determining if it should initialize DMA, it
should be safe to enable DMA on UART2 for all users.
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index cfebaa01217e..ded89b046970 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -915,6 +915,8 @@ uart2: serial@30890000 {
clocks = <&clk IMX8MM_CLK_UART2_ROOT>,
<&clk IMX8MM_CLK_UART2_ROOT>;
clock-names = "ipg", "per";
+ dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>;
+ dma-names = "rx", "tx";
status = "disabled";
};
};
--
2.48.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] arm64: dts: imx8mn: Configure DMA on UART2
2025-06-21 11:23 [PATCH 1/2] arm64: dts: imx8mm: Configure DMA on UART2 Adam Ford
@ 2025-06-21 11:23 ` Adam Ford
2025-06-21 17:07 ` [PATCH 1/2] arm64: dts: imx8mm: " Fabio Estevam
1 sibling, 0 replies; 4+ messages in thread
From: Adam Ford @ 2025-06-21 11:23 UTC (permalink / raw)
To: linux-arm-kernel
Cc: aford, Adam Ford, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
devicetree, imx, linux-kernel
UART2 is often used as the console, so the DMA was likely left
off on purpose, since it's recomended to not use the DMA on the
console. Beacause, the driver checks to see if the UART is used for
the console when determining if it should initialize DMA, it
should be safe to enable DMA on UART2 for all users.
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index 848ba5e46ee6..b98b3d0ddf25 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -860,6 +860,8 @@ uart2: serial@30890000 {
clocks = <&clk IMX8MN_CLK_UART2_ROOT>,
<&clk IMX8MN_CLK_UART2_ROOT>;
clock-names = "ipg", "per";
+ dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>;
+ dma-names = "rx", "tx";
status = "disabled";
};
};
--
2.48.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8mm: Configure DMA on UART2
2025-06-21 11:23 [PATCH 1/2] arm64: dts: imx8mm: Configure DMA on UART2 Adam Ford
2025-06-21 11:23 ` [PATCH 2/2] arm64: dts: imx8mn: " Adam Ford
@ 2025-06-21 17:07 ` Fabio Estevam
2025-06-23 15:29 ` Frank Li
1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2025-06-21 17:07 UTC (permalink / raw)
To: Adam Ford
Cc: linux-arm-kernel, aford, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
devicetree, imx, linux-kernel
On Sat, Jun 21, 2025 at 8:23 AM Adam Ford <aford173@gmail.com> wrote:
>
> UART2 is often used as the console, so the DMA was likely left
> off on purpose, since it's recomended to not use the DMA on the
Typo: recommended
> console. Beacause, the driver checks to see if the UART is used for
Typo: Because
> the console when determining if it should initialize DMA, it
> should be safe to enable DMA on UART2 for all users.
The same comment applies to the other patch.
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8mm: Configure DMA on UART2
2025-06-21 17:07 ` [PATCH 1/2] arm64: dts: imx8mm: " Fabio Estevam
@ 2025-06-23 15:29 ` Frank Li
0 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2025-06-23 15:29 UTC (permalink / raw)
To: Fabio Estevam
Cc: Adam Ford, linux-arm-kernel, aford, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, devicetree, imx, linux-kernel
On Sat, Jun 21, 2025 at 02:07:56PM -0300, Fabio Estevam wrote:
> On Sat, Jun 21, 2025 at 8:23 AM Adam Ford <aford173@gmail.com> wrote:
> >
> > UART2 is often used as the console, so the DMA was likely left
> > off on purpose, since it's recomended to not use the DMA on the
>
> Typo: recommended
>
>
> > console. Beacause, the driver checks to see if the UART is used for
>
> Typo: Because
>
> > the console when determining if it should initialize DMA, it
> > should be safe to enable DMA on UART2 for all users.
>
> The same comment applies to the other patch.
Please run below command to check spell error before post patches.
./scripts/checkpatch.pl --codespell --strict
Frank
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-06-23 15:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-21 11:23 [PATCH 1/2] arm64: dts: imx8mm: Configure DMA on UART2 Adam Ford
2025-06-21 11:23 ` [PATCH 2/2] arm64: dts: imx8mn: " Adam Ford
2025-06-21 17:07 ` [PATCH 1/2] arm64: dts: imx8mm: " Fabio Estevam
2025-06-23 15:29 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).