[PATCH v1 0/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

[PATCH v1 0/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

[Aleksandrs Vinarskis]

Follow up to previous discussion [1].

Disable camera specific PMIC pm8010 by default, as some X1E/X1 devices
do not have one. Platform that utilize it should enable it.

Affected upstream devices:
- none
Affected devices submitted upstream (did not land yet):
- CRD, as part of CAMSS series by Bryan [2]

[1] https://lore.kernel.org/linux-arm-msm/519f9e21-466f-4e8b-9bd0-dfe0448920bb@oss.qualcomm.com/
[2] https://lore.kernel.org/all/20250417-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v7-5-3fd4124cf35a@linaro.org/

Aleksandrs Vinarskis (1):
  arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

 arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.48.1

[PATCH v1 1/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

[Aleksandrs Vinarskis]

pm8010 is a camera specific PMIC, and may not be present on some
devices. These may instead use a dedicated vreg for this purpose (Dell
XPS 9345, Dell Inspiron..) or use USB webcam instead of a MIPI one
alltogether (Lenovo Thinbook 16, Lenovo Yoga..).

Disable pm8010 by default, let platforms that actually have one onboard
enable it instead.

This fixes dmesg errors of PMIC failing to probe, and on Dell XPS 9345
fixes the issue of power button not working as power off/suspend (only
long press cuts the power).

Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")

Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
---
 arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
index e3888bc143a0..621890ada153 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
@@ -475,6 +475,8 @@ pm8010: pmic@c {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		status = "disabled";
+
 		pm8010_temp_alarm: temp-alarm@2400 {
 			compatible = "qcom,spmi-temp-alarm";
 			reg = <0x2400>;
-- 
2.48.1

Re: [PATCH v1 1/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

[Bryan O'Donoghue]

On 24/06/2025 23:41, Aleksandrs Vinarskis wrote:
> pm8010 is a camera specific PMIC, and may not be present on some
> devices. These may instead use a dedicated vreg for this purpose (Dell
> XPS 9345, Dell Inspiron..) or use USB webcam instead of a MIPI one
> alltogether (Lenovo Thinbook 16, Lenovo Yoga..).
> 
> Disable pm8010 by default, let platforms that actually have one onboard
> enable it instead.
> 
> This fixes dmesg errors of PMIC failing to probe, and on Dell XPS 9345
> fixes the issue of power button not working as power off/suspend (only
> long press cuts the power).
> 
> Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
> 
> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> ---
>   arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> index e3888bc143a0..621890ada153 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> @@ -475,6 +475,8 @@ pm8010: pmic@c {
>   		#address-cells = <1>;
>   		#size-cells = <0>;
>   
> +		status = "disabled";
> +
>   		pm8010_temp_alarm: temp-alarm@2400 {
>   			compatible = "qcom,spmi-temp-alarm";
>   			reg = <0x2400>;
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Re: [PATCH v1 1/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

[Johan Hovold]

On Wed, Jun 25, 2025 at 12:41:20AM +0200, Aleksandrs Vinarskis wrote:
> pm8010 is a camera specific PMIC, and may not be present on some
> devices. These may instead use a dedicated vreg for this purpose (Dell
> XPS 9345, Dell Inspiron..) or use USB webcam instead of a MIPI one
> alltogether (Lenovo Thinbook 16, Lenovo Yoga..).
> 
> Disable pm8010 by default, let platforms that actually have one onboard
> enable it instead.
> 
> This fixes dmesg errors of PMIC failing to probe, and on Dell XPS 9345
> fixes the issue of power button not working as power off/suspend (only
> long press cuts the power).
> 
> Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
> 

Nit: There shouldn't be a new line here after the Fixes tag.

Not sure how this breaks the power button on the XPS, but sounds like
this one should be marked for stable backport:

Cc: stable@vger.kernel.org

> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>

Johan

Re: [PATCH v1 1/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

[Aleksandrs Vinarskis]

On Wed, 25 Jun 2025 at 09:52, Johan Hovold <johan@kernel.org> wrote:
>
> On Wed, Jun 25, 2025 at 12:41:20AM +0200, Aleksandrs Vinarskis wrote:
> > pm8010 is a camera specific PMIC, and may not be present on some
> > devices. These may instead use a dedicated vreg for this purpose (Dell
> > XPS 9345, Dell Inspiron..) or use USB webcam instead of a MIPI one
> > alltogether (Lenovo Thinbook 16, Lenovo Yoga..).
> >
> > Disable pm8010 by default, let platforms that actually have one onboard
> > enable it instead.
> >
> > This fixes dmesg errors of PMIC failing to probe, and on Dell XPS 9345
> > fixes the issue of power button not working as power off/suspend (only
> > long press cuts the power).
> >
> > Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
> >
>
> Nit: There shouldn't be a new line here after the Fixes tag.

Thanks, will fix it next time,

>
> Not sure how this breaks the power button on the XPS, but sounds like
> this one should be marked for stable backport:

I suspect it's because the power button "pmic_pwrkey" is coming from
one of the PMICs (..spmi-0/...pmic@0). As pm8010 is on the same spmi
bus, it appears failing to probe breaks communication on the entire
bus? pm8010 is the last one in the list, so it could be that other
PMICs were already initialized to correct voltage, that would explain
why everything else still works. Just a theory though.

>
> Cc: stable@vger.kernel.org

Did not think of that, but you are probably right.

Alex

>
> > Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
>
> Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
>
> Johan

Re: [PATCH v1 1/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

[Johan Hovold]

On Wed, Jun 25, 2025 at 11:49:08AM +0200, Aleksandrs Vinarskis wrote:
> On Wed, 25 Jun 2025 at 09:52, Johan Hovold <johan@kernel.org> wrote:
> >
> > On Wed, Jun 25, 2025 at 12:41:20AM +0200, Aleksandrs Vinarskis wrote:
> > > pm8010 is a camera specific PMIC, and may not be present on some
> > > devices. These may instead use a dedicated vreg for this purpose (Dell
> > > XPS 9345, Dell Inspiron..) or use USB webcam instead of a MIPI one
> > > alltogether (Lenovo Thinbook 16, Lenovo Yoga..).
> > >
> > > Disable pm8010 by default, let platforms that actually have one onboard
> > > enable it instead.
> > >
> > > This fixes dmesg errors of PMIC failing to probe, and on Dell XPS 9345
> > > fixes the issue of power button not working as power off/suspend (only
> > > long press cuts the power).
> > >
> > > Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")

> > Not sure how this breaks the power button on the XPS, but sounds like
> > this one should be marked for stable backport:
> 
> I suspect it's because the power button "pmic_pwrkey" is coming from
> one of the PMICs (..spmi-0/...pmic@0). As pm8010 is on the same spmi
> bus, it appears failing to probe breaks communication on the entire
> bus? pm8010 is the last one in the list, so it could be that other
> PMICs were already initialized to correct voltage, that would explain
> why everything else still works. Just a theory though.

Ouch, would be good to confirm that for the future, but definitely
sounds like a fix we should backport in any case.

Johan

Re: [PATCH v1 1/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

[Konrad Dybcio]

On 6/25/25 12:41 AM, Aleksandrs Vinarskis wrote:
> pm8010 is a camera specific PMIC, and may not be present on some
> devices. These may instead use a dedicated vreg for this purpose (Dell
> XPS 9345, Dell Inspiron..) or use USB webcam instead of a MIPI one
> alltogether (Lenovo Thinbook 16, Lenovo Yoga..).
> 
> Disable pm8010 by default, let platforms that actually have one onboard
> enable it instead.
> 
> This fixes dmesg errors of PMIC failing to probe, and on Dell XPS 9345
> fixes the issue of power button not working as power off/suspend (only
> long press cuts the power).
> 
> Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
> 
> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad