From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 334913F9FB for ; Sat, 28 Jun 2025 23:09:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751152167; cv=none; b=nDFpNzyeR2SoAqkas2Osz/Jk5fC4sL9uv2uT/TXLPzFS054QA2gKA76F9uvvJZx1usCclCNzGFOXuy0LLeO3OquidnXYpy4rxbT3uqF6aHNo3DR0vbaP/iyI77BtCUyaE7DarIwCic8wyCYT3GupNZtrxdY5UAPFz32T3xTTApI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751152167; c=relaxed/simple; bh=MRVUCRgUFnRXsc4X+ViqiuHCZ39s/cTZH9WQss8R5oM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DC3MwS3kLGzVaLEf4omUkTG0C/P8Lan5H5qN2ulGzm1boFn8vdLQYCH1XF2qRDUtb3cSrnhFCErfRfyyTEJtcA8dzev+z2zfFOvWRgYRZJQzaU66ATK3qbtcTQxh9AD//zEhmjQD9ToM8Ufb2AGa8gxwpok+Qbw9/Q9Cjiauasg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=aB+VBA84; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="aB+VBA84" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-747fc7506d4so923952b3a.0 for ; Sat, 28 Jun 2025 16:09:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1751152164; x=1751756964; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+RghmK7bwNQ0kQhbtW4wZXNGWIk0IsY2NIzalhOt1CU=; b=aB+VBA84RtbtKhyqUkWegdf7BAmKr13bI4PrAxXtcsP04iHe3QzGOtq4uzS9n//fiG yOQ8zYK3EUw5b1evRDMBl+D5wlGFOafop9Fq/Qs1VVMR26TeaqPG+ur7x0cpGJfECA/q lpyT7wTx1jiP9HufZySfmk+XzOIZBFZykzjUqTUaN8b0m/GMhrxs+WJvJ2r+I9ICV2vl IpAcgvX74ysMJcgXL6C4AGg/lCvtZytsBL6gMXY9iGNZuCa+6d+dg+w/Iufn9rCaM1dX gg//InLgNl6pMfNOpvAwUtvZp1TcmiQ4hvmqTsSSqqW0ogbf2p1DxQ2NlHI0kNTZ8znU 6Yew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751152164; x=1751756964; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+RghmK7bwNQ0kQhbtW4wZXNGWIk0IsY2NIzalhOt1CU=; b=R5kdK+Y6KO2imvNhmR7ysMLN941VBNn3WkXwZiIlinsOyV7p2cH2PFL1sSa0huNf1X 1EppnwuHLiif0rk6cfxkSEmHjtAdWlBP3Y7prEuxGIKYsR872VT1Gp4WEQb3N9y/+eD/ rt9HV7vGhHsjMXq8EYKVewTnP/5UVzDuCoW0RT3ENzI1CSYiTJuFs5u2g+GhwQTXH4sx RddHby0ohqizdxeEy76jo2wtNvd3/+KiJ/GGrY1G5T+qTsiShjk1uTSpx2+YXqSQDVbi nA151KOwYt+xGOtoRn5Aq31wQzKJiJ8cNIl7mnEv/jC1hddNhXbNOkURrXoKley018X4 uXyQ== X-Forwarded-Encrypted: i=1; AJvYcCWPjLL8ZUqNgsz6OwVdNuOfSL9lhb6B0S2a8OVhNCij1LvRgo9kUXO/wIh/e1x5RgNgGuvoCT9pP3QL@vger.kernel.org X-Gm-Message-State: AOJu0Yzmfju7xsE9ylraTtWOwzXj6AoNThsQ9zn247B5JCIFhik4IzRX L9mU/uQfYc0ah/gDyyj+2SIUoIw5gUUiQxEZ3deIf8W6fwSgvPXMg36OcbfOcsOOSXQ= X-Gm-Gg: ASbGnct+UD3grLuiiP2NbmJmajRSLrPhrfJYReN9louElgHos87cyXhnwKnhBJXri1X 0EIieiSiHeRq5Xbn3UgmraGXZnbqmTT2VXL5kI/7QQL4U1nnOok8wwAxP1/tBEAFDS7/SystbcM AavEr5whldOKML05F9xsmmb/9QVV6pDoLuuZ4tbB6XKNF7CSczbOSOQAalXdvkaDCrmK8vjTppV oxi31nbDxtCNTOprcTS7to3gSZe2eJvLmh5OBrpOEPuAQamTKxG+a4FIYkuD23JZCXhZr5G8S9g LXOBjiD2oT9nWEcb6z0NgU5R8maRDeAPpTgGGM0RVtvrNVojnM4mw4zzgh2Xvi+8SJuJlHNwEM1 w96q9Z0TyRGaftYmsomVuXw== X-Google-Smtp-Source: AGHT+IEkgXTCk2sJOs74/1zzhIFRegzigXwVLQh/vGpG3wmqlsyEARN48cwxen3DleajyDV5uKnKgQ== X-Received: by 2002:a05:6a21:6d87:b0:21d:fd1:9be with SMTP id adf61e73a8af0-220a12d79demr12927327637.12.1751152164483; Sat, 28 Jun 2025 16:09:24 -0700 (PDT) Received: from dev-linux (syn-076-088-115-008.res.spectrum.com. [76.88.115.8]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b34e31beab2sm4612049a12.47.2025.06.28.16.09.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Jun 2025 16:09:23 -0700 (PDT) Date: Sat, 28 Jun 2025 16:09:10 -0700 From: Sukrut Bellary To: Andy Shevchenko Cc: Jonathan Cameron , David Lechner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matti Vaittinen , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , Angelo Compagnucci , Nishanth Menon , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/5] iio: adc: ti-adc128s052: Add lower resolution devices support Message-ID: References: <20250614091504.575685-1-sbellary@baylibre.com> <20250614091504.575685-5-sbellary@baylibre.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Jun 14, 2025 at 09:45:43PM +0300, Andy Shevchenko wrote: > On Sat, Jun 14, 2025 at 12:15 PM Sukrut Bellary wrote: > > > > The adcxx communicates with a host processor via an SPI/Microwire Bus > > interface. The device family responds with 12-bit data, of which the LSB bits > > are transmitted by the lower resolution devices as 0. > > The unavailable bits are 0 in LSB. > > Shift is calculated per resolution and used in scaling and raw data read. > > > > Lets reuse the driver to support the family of devices with name > > ADCS, where > > I believe it's incorrect, i.e. it's something like ...S, where > is something you need to clarify, and is definitely a speed > in kSPS. > Thank you for the review. I am not sure about the last s in . It could be TI's silicon spins versioning. I couldn't find any information about it in any of the datasheets. I can drop the last s or mark it as and specify the first two as maximum speed. > > * bb is the resolution in number of bits (8, 10, 12) > > * c is the number of channels (1, 2, 4, 8) > > * sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS > > and 101 for 1 MSPS) > > > > Complete datasheets are available at TI's website here: > > https://www.ti.com/lit/ds/symlink/adcs.pdf > > > > Tested only with ti-adc102s051 on BegalePlay SBC. > > https://www.beagleboard.org/boards/beagleplay > > ... > > > * https://www.ti.com/lit/ds/symlink/adc128s052.pdf > > * https://www.ti.com/lit/ds/symlink/adc122s021.pdf > > * https://www.ti.com/lit/ds/symlink/adc124s021.pdf > > Forgot to sort out in the previous patch? > I will fix this in respin. > -- > With Best Regards, > Andy Shevchenko