From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DBD31DA3D for ; Mon, 30 Jun 2025 01:10:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751245806; cv=none; b=pPSBv910r0/xJJ5LAiYAb+6R043LYtZQmqmrQ+V5Uo479tDyGxIYBWHYPcQJ8YyBOsvOeQBh/8xx3Lc1iwAv/jHRS/512oMZd4lLyuYsDtzGbbAt+UGaHXp28jpOL8cedzCidj8R2Yo4ZbYaeiu3b/RFDWCgV5+t3V0Tagjye3M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751245806; c=relaxed/simple; bh=7ADJAQfR2OvRUJxJ2i5My0GkntSVnVVUhyq6ffxNAtQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m2jF7KjIpGbwx8eImoD3nKQrdhzHz+FZ74gC83hYb3v1z03U0yFX/bOMd1uLh++m+vCcKweIvNII/yM61ALHLO1QirzOK5MCNzWKHT29ikcN9Bi6qg/pFTOSs/isxtrSiHOt8rZuAfjydBdJVqf+lILLtBIqh2Py3yOdwdZ6teE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Vw7XDZY2; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Vw7XDZY2" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2363497cc4dso30247115ad.1 for ; Sun, 29 Jun 2025 18:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1751245804; x=1751850604; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Uv7SvOY2KGW4wtTGtop8K/oyy0HDfxAOlONEn6vtf5c=; b=Vw7XDZY2oNr87RBFNR+RyBJJZ7auBunKxmoYfFVjzC9MJ02HfFWIxJxYV7O6X4QL1m T/r9s/54qM5spCRa44iWY2w2cC3KZ/7cpJiGB+tqiuh5iRis9hNMLDOv9XBDuRbqMK4B iW69zJpAiWjOqUgoxXz+RymAiHgAfvQI1oLF4WkTrJGUS8id11QHLClvXlTFpl1CpN5o 86wgWQLLF1mwnIPymSgYI41mWjetyOwtVX8m3026y20sbxOBY7g5F5l5ppcbuviZcS4f WtZqpvbro+9u5sg1Z8fziHezs/D+VAZxvVQ4Zr1KNRiWX2xeKKLjwE3/IQvF018XKv2f ZZAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751245804; x=1751850604; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Uv7SvOY2KGW4wtTGtop8K/oyy0HDfxAOlONEn6vtf5c=; b=XXNfRFZdQwp7GgJ8VafhGdTBl+BbliJ5jj+PZXwDyF8yShF7QByzSKvUimS9+kd8e1 zoLavuSy9Sr2kqNMkfg815yvvf4UphIvZLZqspwst8b+fgjRlcxAMzMt8ujxAR0EuYo4 mD14kLxwL4pGbWIB/iJ665xOp1Sh53pHqOHcTR1jtL377/LdBw2zjezdhww7ER4I1Cot VsapFS6e4Xnjbcw7rK9uuNbd/jWgQtYchMDrHWFh39N8z16l9u/x8WlEW85Kzs7R4qVH 1erGEe2ENHMLnw/5pT6zDStkS/j58IJCDVSDGurI7V51gGKzmgCGNlR0K1G69J0d9gYO gNQA== X-Forwarded-Encrypted: i=1; AJvYcCXji6zaelGrrLzdsfgPHhxu5Ml27kGLbJlACOJ4eX9M9JU5gvdHlI1DYGXn1fu+f2oy2DDSTg/akKXt@vger.kernel.org X-Gm-Message-State: AOJu0YxTa8BgjaChTQl8HgymgRZmQGlmIHldYkSWwYrC28E+ItHOwUns mhA9CT8vwaSd376MnqbVbIaw/QdSE9icWWQtByCWiD6aecMnbDAz9ekguGEa4mv8XpYsU3HP3b3 Pv7xk X-Gm-Gg: ASbGncsfwpJZvRjomATnrqZNVpPBrYXfILLpvP73VBnny9Lpm/AL2Z4eSThhSDc5mJ6 yiVxIgh/8+IMeTDdQPkBqcFJrd8dD/v4+AL4/gWNW9Yp8FqsAytn7L/ZRVkhmplbsVyu17SDxU0 IcvyAXXfm6cUd6nKcvTWlpj29mo9iB8FlrGGOI1F4s4LeS+82VFTjj+DxFZhBPUecMgHNBmPVPF m8eZSOwFA3oNTB0RVy2POgKCoq9r1hHgwd1fCpBWqWFADzPJMMnsGMhx+ckC6uCxhfw2UnO8BuZ 78upVeFuStMyB8d0QIUSzf4MYhXzrJ3+ZbUwI4iUuXLlR10AKbO9nQVWruu3wGPipRokePt0/GY Dj+ZWBOu1zUbSKSJ0F72/EnlXfs5o7Nr+ X-Google-Smtp-Source: AGHT+IELVrA6xYh6a/9VG+5oY6f82d45viFI7VALj4GsK0dysu6/rXcokuZJ87CxZLgjM/7f+MW7vQ== X-Received: by 2002:a17:902:f745:b0:224:1af1:87f4 with SMTP id d9443c01a7336-23ac3df1e80mr190330525ad.22.1751245804018; Sun, 29 Jun 2025 18:10:04 -0700 (PDT) Received: from dev-linux (syn-076-088-115-008.res.spectrum.com. [76.88.115.8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23acb3b7a47sm68924625ad.166.2025.06.29.18.10.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jun 2025 18:10:03 -0700 (PDT) Date: Sun, 29 Jun 2025 18:10:00 -0700 From: Sukrut Bellary To: Jonathan Cameron Cc: David Lechner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matti Vaittinen , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , Angelo Compagnucci , Nishanth Menon , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/5] iio: adc: ti-adc128s052: Use shift and realbits Message-ID: References: <20250614091504.575685-1-sbellary@baylibre.com> <20250614091504.575685-3-sbellary@baylibre.com> <20250614142743.23ee2203@jic23-huawei> <20250629172655.209e2bd2@jic23-huawei> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250629172655.209e2bd2@jic23-huawei> On Sun, Jun 29, 2025 at 05:26:55PM +0100, Jonathan Cameron wrote: > On Sat, 28 Jun 2025 13:01:53 -0700 > > > > > + .type = IIO_VOLTAGE, \ > > > > + .indexed = 1, \ > > > > + .channel = (num), \ > > > > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \ > > > > + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \ > > > > + .scan_index = (num), \ > > > > + .scan_type = { \ > > > > + .sign = 'u', \ > > > > + .realbits = (real_bits), \ > > > > + .storagebits = 16, \ > > > > + .shift = (12 - real_bits), \ > > > > + }, \ > > > > } > > > > > > > > +#define ADC128_VOLTAGE_CHANNEL(num) _ADC128_VOLTAGE_CHANNEL(num, 12) > > > > > > I wonder if it would be clearer to just have the 12 explicit in each entry > > > and skip this two levels of macro thing? > > > > > Do you mean to pass realbits to > > ADC128_VOLTAGE_CHANNEL/_ADC128_VOLTAGE_CHANNEL as e.g., > > > > static const struct iio_chan_spec adc122s021_channels[] = { > > ADC128_VOLTAGE_CHANNEL(0, 12), > > ADC128_VOLTAGE_CHANNEL(1, 12), > > }; > > > > I think we added 2nd level macros as ADC082_VOLTAGE_CHANNEL, > > ADC102_VOLTAGE_CHANNEL, etc., to have a visual distinction for a different > > part nos. > > I think as we can have lots of parts with each resolution that will > end up confusing. > > > But I am ok if you prefer ADC128_VOLTAGE_CHANNEL with a second parameter > > as real_bits. > > I think that's going to be easier to follow. > Ok, I will change it in v5. > Jonathan >