From: Zixian Zeng <sycamoremoon376@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Chen Wang <unicorn_wang@outlook.com>,
Inochi Amaoto <inochiama@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Longbin Li <looong.bin@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
sophgo@lists.linux.dev, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 1/4] spi: dt-bindings: spi-sg2044-nor: Change SOPHGO SG2042
Date: Mon, 30 Jun 2025 20:12:22 +0800 [thread overview]
Message-ID: <aGJ_JtThs7VpRIwa@calculate> (raw)
In-Reply-To: <4afcef9e-db98-4679-b9c1-40ffcf4861c6@kernel.org>
On Mon, Jun 30, 2025 at 01:55:58PM +0200, Krzysztof Kozlowski wrote:
> On 30/06/2025 13:47, Zixian Zeng wrote:
> > On Mon, Jun 30, 2025 at 09:17:09AM +0200, Krzysztof Kozlowski wrote:
> >> On Sun, Jun 29, 2025 at 04:23:10PM +0800, Zixian Zeng wrote:
> >>> SG2042 is not fully compatiable with SG2044,
> >>
> >> Typo, run spellcheck.
> >>
> > Thanks for spotting that! I will add spellcheck to my patch checking script next.
> >
> >>> So it is necessary to become independent const
> >>
> >> No capital letters after ,.
> >>
> > Ok, thanks
> >
> >> Anyway, explain why it is not fully compatible.
> >>
> > I have asked the technical staff of SOPHGO,
> > the SG2044 and SG2042 are indeed incompatible with each other in some places
> > because of the hardware details, regarding the configuration of the OPT register
> > and FFTrgLvl(fifo trigger level) bit setting.
>
> So when driver binds with sg2044, the device does not work? Or what
> exactly does not work?
>
> All this is supposed to be explained in the commit msg.
>
I got it, I think I had explained this in the driver patch[3/4].
If this reason is acceptable, I would like to ask whether
the explanation should be put in the binding patch commit msg [1/4]
instead of the driver patch commit msg [3/4]? or both?
Thank you.
> Best regards,
> Krzysztof
Best regards,
Zixian
next prev parent reply other threads:[~2025-06-30 12:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 8:23 [PATCH v3 0/4] spi: sophgo: Add SPI NOR controller for SG2042 Zixian Zeng
2025-06-29 8:23 ` [PATCH v3 1/4] spi: dt-bindings: spi-sg2044-nor: Change SOPHGO SG2042 Zixian Zeng
2025-06-29 9:29 ` Rob Herring (Arm)
2025-06-30 7:17 ` Krzysztof Kozlowski
2025-06-30 11:47 ` Zixian Zeng
2025-06-30 11:55 ` Krzysztof Kozlowski
2025-06-30 12:12 ` Zixian Zeng [this message]
2025-06-29 8:23 ` [PATCH v3 2/4] spi: spi-sg2044-nor: Add configurable chip info Zixian Zeng
2025-06-29 8:23 ` [PATCH v3 3/4] spi: spi-sg2044-nor: Fix reading bytes issue on SG2042 Zixian Zeng
2025-06-29 8:23 ` [PATCH v3 4/4] riscv: dts: sophgo: Add SPI NOR node for SG2042 Zixian Zeng
2025-06-29 8:37 ` Zixian Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGJ_JtThs7VpRIwa@calculate \
--to=sycamoremoon376@gmail.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=looong.bin@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=sophgo@lists.linux.dev \
--cc=tudor.ambarus@linaro.org \
--cc=unicorn_wang@outlook.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).