Re: [PATCH v3 1/2] Add bindings for ams Mira220 cmos image sensor

Krzysztof Kozlowski
2025-07-02T07:04:27Z

On Tue, Jul 01, 2025 at 05:12:44PM +0200, philippe baetens wrote:
> Mira220 is a global shutter NIR-enhanced image sensor made by AMS.
> Driver is submitted in the next patch of this series and verified on a raspberry pi.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Please use subject prefixes matching the subsystem. You can get them for
example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

>
> Signed-off-by: philippe baetens <philippebaetens@gmail.com>

Fix your Git, so your identity uses same style. It is "Philippe
Baetens", no?

> ---
> Changes in v3:
> - Improve commit message
> - add mailing list for device tree.
>
> Changes in v2:
> - add maintainers and Documentation.yaml
>

> ---
> .../bindings/media/i2c/ams,mira220.yaml | 125 ++++++++++++++++++
> MAINTAINERS | 6 +
> 2 files changed, 131 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml b/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
> new file mode 100644
> index 000000000..21a55ff07
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
> @@ -0,0 +1,125 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/ams,mira220.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ams 2.2 MP NIR enhanced global shutter image sensor
> +
> +maintainers:
> + - Philippe Baetens <philippebaetens@gmail.com>
> +
> +description: |-
> + 2.2 MP NIR enhanced global shutter image sensor designed for 2D and 3D
> + consumer and industrial machine vision applications.
> + Due to its small size, configurability and high sensitivity both
> + in visual as well as NIR, the Mira220 is well suited for 2D and
> + 3D applications, which include Active Stereo Vision,
> + Structured Light Vision for Robotics and AR/VR.
> +
> +properties:
> + compatible:
> + const: ams,mira220
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + description: Input clock (38.4 MHz)
> + items:
> + - const: inck

Drop clock-names, redundant.

> +
> + vdig-supply:
> + description:
> + Digital I/O voltage supply, 1.35 volts
> +
> + vana1-supply:
> + description:
> + Analog1 voltage supply, 2.8 volts
> +
> + vana2-supply:
> + description:
> + Analog2 voltage supply, 1.8 volts
> +
> + vddl-supply:
> + description:
> + Digital core voltage supply, 1.8 volts
> +
> + reset-gpios:
> + description: Sensor reset (XCLR) GPIO
> + maxItems: 1
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + description: |

Drop |

> + Video output port
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + data-lanes:
> + anyOf:
> + - items:
> + - const: 1
> + - const: 2
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> +
> + link-frequencies: true

Drop, not needed.

> +
> + required:
> + - data-lanes
> + - link-frequencies
> +
> + additionalProperties: false

This goes after $ref

> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - vdig-supply
> + - vana-supply
> + - vddl-supply
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mira220: camera-sensor@1a {
> + compatible = "ams,mira220";
> + reg = <0x54>;

Does not match unit address.

> +
> + clocks = <&cam1_clk>;

Best regards,
Krzysztof