[PATCH] arm64: dts: freescale: imx93-phyboard-nash: Move ADC vref to SoM

[PATCH] arm64: dts: freescale: imx93-phyboard-nash: Move ADC vref to SoM

[Primoz Fiser]

Move configuration for ADC voltage reference from board DTS to a SoM
include file. The SoC ADC reference voltage is connected to a "VDDA_1V8"
voltage node and supplied by the PMIC's BUCK5 regulator. The reference
voltage is thus defined by the SoM and cannot be changed by the carrier
board design and as such belongs into the SoM include file.

Moreover, with this in place, customers designing own carrier boards can
simply include imx93-phycore-som.dtsi and enable adc1 in their own DTS
without the need to define dummy ADC vref regulator themselves anymore.

Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
---
 .../boot/dts/freescale/imx93-phyboard-nash.dts      |  8 --------
 .../arm64/boot/dts/freescale/imx93-phycore-som.dtsi | 13 +++++++++++++
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx93-phyboard-nash.dts b/arch/arm64/boot/dts/freescale/imx93-phyboard-nash.dts
index e1c9aa77c000..475913cf0cb9 100644
--- a/arch/arm64/boot/dts/freescale/imx93-phyboard-nash.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-phyboard-nash.dts
@@ -53,18 +53,10 @@ reg_vcc_1v8: regulator-vcc-1v8 {
 		regulator-max-microvolt = <1800000>;
 		regulator-min-microvolt = <1800000>;
 	};
-
-	reg_vref_1v8: regulator-adc-vref {
-		compatible = "regulator-fixed";
-		regulator-name = "VREF_1V8";
-		regulator-min-microvolt = <1800000>;
-		regulator-max-microvolt = <1800000>;
-	};
 };
 
 /* ADC */
 &adc1 {
-	vref-supply = <&reg_vref_1v8>;
 	status = "okay";
 };
 
diff --git a/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi b/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi
index 0ea61841e591..26bd801a49bb 100644
--- a/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi
@@ -46,6 +46,19 @@ led-0 {
 			linux,default-trigger = "heartbeat";
 		};
 	};
+
+	reg_vdda_1v8: regulator-vdda-1v8 {
+		compatible = "regulator-fixed";
+		regulator-name = "VDDA_1V8";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		vin-supply = <&buck5>;
+	};
+};
+
+/* ADC */
+&adc1 {
+	vref-supply = <&reg_vdda_1v8>;
 };
 
 /* Ethernet */
-- 
2.34.1

Re: [PATCH] arm64: dts: freescale: imx93-phyboard-nash: Move ADC vref to SoM

[Peng Fan]

On Mon, Jun 02, 2025 at 02:52:07PM +0200, Primoz Fiser wrote:
>Move configuration for ADC voltage reference from board DTS to a SoM
>include file. The SoC ADC reference voltage is connected to a "VDDA_1V8"
>voltage node and supplied by the PMIC's BUCK5 regulator. The reference
>voltage is thus defined by the SoM and cannot be changed by the carrier
>board design and as such belongs into the SoM include file.
>
>Moreover, with this in place, customers designing own carrier boards can
>simply include imx93-phycore-som.dtsi and enable adc1 in their own DTS
>without the need to define dummy ADC vref regulator themselves anymore.
>
>Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

Re: [PATCH] arm64: dts: freescale: imx93-phyboard-nash: Move ADC vref to SoM

[Shawn Guo]

On Mon, Jun 02, 2025 at 02:52:07PM +0200, Primoz Fiser wrote:
> Move configuration for ADC voltage reference from board DTS to a SoM
> include file. The SoC ADC reference voltage is connected to a "VDDA_1V8"
> voltage node and supplied by the PMIC's BUCK5 regulator. The reference
> voltage is thus defined by the SoM and cannot be changed by the carrier
> board design and as such belongs into the SoM include file.
> 
> Moreover, with this in place, customers designing own carrier boards can
> simply include imx93-phycore-som.dtsi and enable adc1 in their own DTS
> without the need to define dummy ADC vref regulator themselves anymore.
> 
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>

Applied, thanks!