From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v2 04/11] iio: adc: ad_sigma_delta: use BITS_TO_BYTES() macro
Date: Tue, 1 Jul 2025 16:47:02 +0300 [thread overview]
Message-ID: <aGPm1td5sEqp5R9H@smile.fi.intel.com> (raw)
In-Reply-To: <e4c7296d-6afe-4edb-b26f-44218e660a80@baylibre.com>
On Mon, Jun 30, 2025 at 08:33:59AM -0500, David Lechner wrote:
> On 6/30/25 3:59 AM, Andy Shevchenko wrote:
> > On Sat, Jun 28, 2025 at 03:56:43PM +0100, Jonathan Cameron wrote:
> >> On Fri, 27 Jun 2025 18:40:00 -0500
> >> David Lechner <dlechner@baylibre.com> wrote:
...
> >>> - samples_buf_size = ALIGN(slot * indio_dev->channels[0].scan_type.storagebits / 8, 8);
> >>> + samples_buf_size = ALIGN(slot * BITS_TO_BYTES(scan_type->storagebits), 8);
> >>
> >> Ah. You do it here. Fair enough and no problem wrt to patch 1 then.
> >
> > Hmm... Should the second 8 be something like sizeof(unsigned long lone) for
> > semantic distinguishing with 8-bit bytes?
>
> Yeah, I considered to use sizeof(s64) to match the next line, but it
> it seems like a separate change, so in the end I decided against doing
> it in this patch and it seems too small of a thing for a separate patch.
The problem in not the size of the change, the problem is that semantically
those 8:s are _different_ and code readability will be much better if we make
them so explicitly.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-07-01 13:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 23:39 [PATCH v2 00/11] iio: adc: ad7173: add SPI offload support David Lechner
2025-06-27 23:39 ` [PATCH v2 01/11] iio: adc: ad_sigma_delta: don't overallocate scan buffer David Lechner
2025-06-28 14:55 ` Jonathan Cameron
2025-06-28 15:04 ` Jonathan Cameron
2025-06-27 23:39 ` [PATCH v2 02/11] iio: adc: ad_sigma_delta: sort includes David Lechner
2025-06-27 23:39 ` [PATCH v2 03/11] iio: adc: ad_sigma_delta: use u8 instead of uint8_t David Lechner
2025-06-27 23:40 ` [PATCH v2 04/11] iio: adc: ad_sigma_delta: use BITS_TO_BYTES() macro David Lechner
2025-06-28 14:56 ` Jonathan Cameron
2025-06-30 8:59 ` Andy Shevchenko
2025-06-30 13:33 ` David Lechner
2025-07-01 13:47 ` Andy Shevchenko [this message]
2025-07-01 17:36 ` Jonathan Cameron
2025-06-27 23:40 ` [PATCH v2 05/11] iio: adc: ad_sigma_delta: audit included headers David Lechner
2025-06-30 9:02 ` Andy Shevchenko
2025-06-27 23:40 ` [PATCH v2 06/11] iio: adc: ad_sigma_delta: refactor setting read address David Lechner
2025-06-27 23:40 ` [PATCH v2 07/11] iio: adc: ad_sigma_delta: use spi_optimize_message() David Lechner
2025-06-27 23:40 ` [PATCH v2 08/11] dt-bindings: trigger-source: add ADI Util Sigma-Delta SPI David Lechner
2025-06-27 23:40 ` [PATCH v2 09/11] spi: offload trigger: add ADI Util Sigma-Delta SPI driver David Lechner
2025-06-28 15:02 ` Jonathan Cameron
2025-07-01 20:57 ` David Lechner
2025-06-30 9:05 ` Andy Shevchenko
2025-06-27 23:40 ` [PATCH v2 10/11] iio: adc: ad_sigma_delta: add SPI offload support David Lechner
2025-06-27 23:40 ` [PATCH v2 11/11] iio: adc: ad7173: " David Lechner
2025-07-02 13:27 ` (subset) [PATCH v2 00/11] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGPm1td5sEqp5R9H@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).