From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linus.walleij@linaro.org, brgl@bgdev.pl, broonie@kernel.org,
lgirdwood@gmail.com
Subject: Re: [PATCH v7 00/12] iio: adc: Add support for AD4170 series of ADCs
Date: Wed, 2 Jul 2025 09:00:42 -0300 [thread overview]
Message-ID: <aGUfapky2uh2tsFt@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <aGTpNNaW7cXC18Jt@smile.fi.intel.com>
On 07/02, Andy Shevchenko wrote:
> On Mon, Jun 30, 2025 at 10:57:32AM -0300, Marcelo Schmitt wrote:
> > Hello,
> >
> > AD4170 support v7 comes after testing the driver with even more variations of
> > channel setups. Signal offset and amplification can be tricky to grasp at times.
> >
> > Thank you to all reviewers of previous versions. This intends to comply with all
> > comments and suggestions to v6.
> >
> > Same amount of patches than v6.
>
> ...
>
> > 6 files changed, 3601 insertions(+)
>
> This is weird. At least patches 11 & 12 have '-' lines...
>
Yeah, sorry about that. These ADCs are fancy such that the base driver is about
1500 LoCs due to channel setup handling and support for multiple combinations of
voltage references and channel setups.
About the '-' lines, I will rework ad4170_parse_channel_node() on earlier
patches to avoid 3 line removals in patch 11. Patch 12 is only makes sense
after patch 7 and I think it would lead to '-' lines if coming before patch 10
since both increment the number of IIO channels. Anyway, I'll see how to further
reduce the number of lines being removed.
Best regards,
Marcelo
> --
> With Best Regards,
> Andy Shevchenko
>
>
next prev parent reply other threads:[~2025-07-02 11:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 13:57 [PATCH v7 00/12] iio: adc: Add support for AD4170 series of ADCs Marcelo Schmitt
2025-06-30 13:57 ` [PATCH v7 01/12] dt-bindings: iio: adc: Add AD4170 Marcelo Schmitt
2025-07-06 17:08 ` Jonathan Cameron
2025-06-30 13:58 ` [PATCH v7 02/12] iio: adc: Add basic support for AD4170-4 Marcelo Schmitt
2025-06-30 13:58 ` [PATCH v7 03/12] iio: adc: ad4170-4: Add support for calibration gain Marcelo Schmitt
2025-06-30 13:59 ` [PATCH v7 04/12] iio: adc: ad4170-4: Add support for calibration bias Marcelo Schmitt
2025-06-30 13:59 ` [PATCH v7 05/12] Documentation: ABI: IIO: Add sinc5+avg to the filter_type_available list Marcelo Schmitt
2025-06-30 13:59 ` [PATCH v7 06/12] iio: adc: ad4170-4: Add digital filter and sample frequency config support Marcelo Schmitt
2025-06-30 14:00 ` [PATCH v7 07/12] iio: adc: ad4170-4: Add support for buffered data capture Marcelo Schmitt
2025-06-30 14:00 ` [PATCH v7 08/12] iio: adc: ad4170-4: Add clock provider support Marcelo Schmitt
2025-06-30 14:00 ` [PATCH v7 09/12] iio: adc: ad4170-4: Add GPIO controller support Marcelo Schmitt
2025-06-30 14:01 ` [PATCH v7 10/12] iio: adc: ad4170-4: Add support for internal temperature sensor Marcelo Schmitt
2025-06-30 14:01 ` [PATCH v7 11/12] iio: adc: ad4170-4: Add support for weigh scale and RTD sensors Marcelo Schmitt
2025-06-30 14:01 ` [PATCH v7 12/12] iio: adc: ad4170-4: Add timestamp channel Marcelo Schmitt
2025-07-02 8:09 ` [PATCH v7 00/12] iio: adc: Add support for AD4170 series of ADCs Andy Shevchenko
2025-07-02 12:00 ` Marcelo Schmitt [this message]
2025-07-02 12:15 ` Andy Shevchenko
2025-07-02 18:59 ` Marcelo Schmitt
2025-07-03 14:13 ` Andy Shevchenko
2025-07-03 20:24 ` Marcelo Schmitt
2025-07-06 17:10 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGUfapky2uh2tsFt@debian-BULLSEYE-live-builder-AMD64 \
--to=marcelo.schmitt1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox