devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
	andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, matthias.bgg@gmail.com,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v2 0/6] iio: Add support for MT6363/6373 Auxiliary ADC
Date: Thu, 3 Jul 2025 17:30:18 +0300	[thread overview]
Message-ID: <aGaT-rSmUoukjvR7@smile.fi.intel.com> (raw)
In-Reply-To: <20250703141146.171431-1-angelogioacchino.delregno@collabora.com>

On Thu, Jul 03, 2025 at 04:11:40PM +0200, AngeloGioacchino Del Regno wrote:
> Changes in v2:
>  - Added error checks to all regmap r/w operations
>  - Moved adc_vref addition to different commit
>  - Various other fixes
> 
> This series adds support for the Auxiliary ADC IP found on the new
> MediaTek MT6363 and MT6373 PMICs, found on board designs featuring
> the MT8196 Chromebook SoC or the MT6991 Dimensity 9400 Smartphone SoC.

Overall LGTM, but one nit-pick in one patch.

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2025-07-03 14:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03 14:11 [PATCH v2 0/6] iio: Add support for MT6363/6373 Auxiliary ADC AngeloGioacchino Del Regno
2025-07-03 14:11 ` [PATCH v2 1/6] dt-bindings: iio: adc: mt6359: Add MT6363 PMIC AuxADC AngeloGioacchino Del Regno
2025-07-03 14:11 ` [PATCH v2 2/6] dt-bindings: iio: adc: mt6359: Add MT6373 " AngeloGioacchino Del Regno
2025-07-03 14:11 ` [PATCH v2 3/6] iio: adc: mt6359: Add ready register index and mask to channel data AngeloGioacchino Del Regno
2025-07-03 14:11 ` [PATCH v2 4/6] iio: adc: mt6359: Move reference voltage to platform data AngeloGioacchino Del Regno
2025-07-03 14:28   ` Andy Shevchenko
2025-07-03 14:40     ` AngeloGioacchino Del Regno
2025-07-04  9:14       ` Jonathan Cameron
2025-07-03 14:11 ` [PATCH v2 5/6] iio: adc: mt6359: Add support for MediaTek MT6363 PMIC AUXADC AngeloGioacchino Del Regno
2025-07-03 14:11 ` [PATCH v2 6/6] iio: adc: mt6359: Add support for MediaTek MT6373 " AngeloGioacchino Del Regno
2025-07-03 14:30 ` Andy Shevchenko [this message]
2025-07-04 12:39 ` [PATCH v2 0/6] iio: Add support for MT6363/6373 Auxiliary ADC Nuno Sá
2025-07-06 10:44   ` Jonathan Cameron
2025-07-07 10:44     ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGaT-rSmUoukjvR7@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).