devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tao Ren <rentao.bupt@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@codeconstruct.com.au>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Tao Ren <taoren@meta.com>
Subject: Re: [PATCH 5/5] ARM: dts: aspeed: Add Facebook Darwin (AST2600) BMC
Date: Thu, 3 Jul 2025 15:15:44 -0700	[thread overview]
Message-ID: <aGcBEHMEyQJuzmjj@localhost.localdomain> (raw)
In-Reply-To: <220ac6c2-8373-4742-86fa-f322d6ada624@lunn.ch>

On Thu, Jul 03, 2025 at 09:58:48AM +0200, Andrew Lunn wrote:
> > > How do RGMII delays work? Connections to switches have to be handled
> > > different to PHYs, to avoid double delays. But is there extra long
> > > clock lines? Or are you expecting the switch to add the delays?
> > > 
> > >       Andrew
> > 
> > Hi Andrew,
> > 
> > The delays are introduced in BMC MAC by setting SCU control registers in
> > u-boot. The delays on the switch side are disabled.
> 
> Sorry, but not acceptable. This is something i've been NACKing Aspeed
> DT patches for. You need the MAC driver to interpret the phy-mode and
> program the SCU control register as needed.
> 
> Since you have the MAC introducing the delays, you want phy-mode
> 'rgmii-id'.
> 
> If you want to submit some DT now, drop the ethernet node. This is
> what others have been doing while waiting for Aspeed to fix their MAC
> driver. Having said that, i've not seen any progress from Aspeed, so
> it either needs their customers to apply more pressure, or somebody in
> the community to just fix it and submit patches.
> 
>     Andrew

Hi Andrew,

Got it, and thanks for sharing the context.

I will reach out to ASPEED offline to see if they are actively working
on the MAC fix, or if I have enough knowledge to work out the patch.


Thanks,

Tao

  reply	other threads:[~2025-07-03 22:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02  5:04 [PATCH 0/5] ARM: dts: aspeed: Add Meta Darwin dts rentao.bupt
2025-07-02  5:04 ` [PATCH 1/5] ARM: dts: aspeed: Expand data0 partition in facebook-bmc-flash-layout-128.dtsi rentao.bupt
2025-07-04  0:06   ` Andrew Jeffery
2025-07-04  4:45     ` Tao Ren
2025-07-02  5:04 ` [PATCH 2/5] ARM: dts: aspeed: Remove eMMC from ast2600-facebook-netbmc-common.dtsi rentao.bupt
2025-07-04  0:08   ` Andrew Jeffery
2025-07-04  4:46     ` Tao Ren
2025-07-02  5:04 ` [PATCH 3/5] ARM: dts: aspeed: elbert: Enable eMMC device rentao.bupt
2025-07-02  5:04 ` [PATCH 4/5] ARM: dts: aspeed: fuji: " rentao.bupt
2025-07-02  5:04 ` [PATCH 5/5] ARM: dts: aspeed: Add Facebook Darwin (AST2600) BMC rentao.bupt
2025-07-02  7:40   ` Andrew Lunn
2025-07-02 23:09     ` Tao Ren
2025-07-03  7:58       ` Andrew Lunn
2025-07-03 22:15         ` Tao Ren [this message]
2025-07-04  7:37           ` Andrew Lunn
2025-07-06  4:12             ` Tao Ren
2025-07-02  7:50   ` Krzysztof Kozlowski
2025-07-02 23:13     ` Tao Ren
2025-07-02 15:04 ` [PATCH 0/5] ARM: dts: aspeed: Add Meta Darwin dts Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGcBEHMEyQJuzmjj@localhost.localdomain \
    --to=rentao.bupt@gmail.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=taoren@meta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).