From: Danilo Krummrich <dakr@kernel.org>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: ojeda@kernel.org, alex.gaynor@gmail.com,
gregkh@linuxfoundation.org, rafael@kernel.org, robh@kernel.org,
saravanak@google.com, a.hindborg@kernel.org,
aliceryhl@google.com, bhelgaas@google.com,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com,
david.m.ertman@intel.com, devicetree@vger.kernel.org,
gary@garyguo.net, ira.weiny@intel.com, kwilczynski@kernel.org,
leon@kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, lossin@kernel.org,
netdev@vger.kernel.org, rust-for-linux@vger.kernel.org,
tmgross@umich.edu
Subject: Re: [PATCH v1 1/3] rust: device_id: make DRIVER_DATA_OFFSET optional
Date: Fri, 4 Jul 2025 02:19:34 +0200 [thread overview]
Message-ID: <aGceFtc7MUx9utaj@pollux> (raw)
In-Reply-To: <20250704.084159.887748101305692803.fujita.tomonori@gmail.com>
On Fri, Jul 04, 2025 at 08:41:59AM +0900, FUJITA Tomonori wrote:
> On Fri, 4 Jul 2025 00:15:19 +0200
> Danilo Krummrich <dakr@kernel.org> wrote:
>
> > On 6/23/25 8:09 AM, FUJITA Tomonori wrote:
> >> Enable support for device ID structures that do not contain
> >> context/data field (usually named `driver_data`), making the trait
> >> usable in a wider range of subsystems and buses.
> >> Several such structures are defined in
> >> include/linux/mod_devicetable.h.
> >> This refactoring is a preparation for enabling the PHY abstractions to
> >> use device_id trait.
> >> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
> >
> > Acked-by: Danilo Krummrich <dakr@kernel.org>
>
> Thanks a lot!
>
> Miguel suggested that splitting the RawDeviceId trait might lead to a
> cleaner design, and I also tried that approach [v2]. But just to
> confirm ― do you prefer the original v1 approach instead?
Sorry, I didn't catch v2.
From only looking at patch 1, I indeed prefer v1.
> https://lore.kernel.org/lkml/CANiq72k0sdUoBxVYghgh50+ZRV2gbDkgVjuZgJLtj=4s9852xg@mail.gmail.com/
Looking at this reply to patch 3, I can see why Miguel suggested it though.
Given that, I think splitting the trait is the correct thing to do. I'll reply
to v2.
> [v2]: https://lore.kernel.org/rust-for-linux/20250701141252.600113-1-fujita.tomonori@gmail.com/
>
> Either way works for me.
>
> Sorry Miguel, I forgot to fix the comment typo you pointed out in v1. I'll correct it in v3.
next prev parent reply other threads:[~2025-07-04 0:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 6:09 [PATCH v1 0/3] rust: Build PHY device tables by using module_device_table macro FUJITA Tomonori
2025-06-23 6:09 ` [PATCH v1 1/3] rust: device_id: make DRIVER_DATA_OFFSET optional FUJITA Tomonori
2025-07-03 22:15 ` Danilo Krummrich
2025-07-03 23:41 ` FUJITA Tomonori
2025-07-04 0:19 ` Danilo Krummrich [this message]
2025-06-23 6:09 ` [PATCH v1 2/3] rust: net::phy Represent DeviceId as transparent wrapper over mdio_device_id FUJITA Tomonori
2025-06-23 6:09 ` [PATCH v1 3/3] rust: net::phy Change module_phy_driver macro to use module_device_table macro FUJITA Tomonori
2025-06-23 9:21 ` Miguel Ojeda
2025-06-23 13:02 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGceFtc7MUx9utaj@pollux \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=david.m.ertman@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=kwilczynski@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=saravanak@google.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).