From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11023108.outbound.protection.outlook.com [52.101.127.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66C4914A82; Mon, 7 Jul 2025 02:50:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.108 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751856627; cv=fail; b=QaXFmaFZTyV4LEyqPw7Y+TJ0b3kl3V9rOS/QmhpZZu9ohrzyLlqybd3arXaX9oKPmxlXxRfSgkZDNq9I28RBvR0QpBR6UbXfHlLrfUMcJZevlw8PWaVZ7THyBa9G0WNaL99aQzcEzb8dNjZrVmJbCKCUJmdaruhZFwwRwNrCasM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751856627; c=relaxed/simple; bh=lNo5WGZmM+1B4rt0BkIIEL88NLiL9k6wdwGHOMURMqo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mhP+b7M4Jr4BUAoaX7EWTi9bH3GG9W4lO6lHXSgYp3RHyATK9JORzVUMhcWVIS0SW+9e8bLwiRPnZ7iRfDaFBLMUMXyHcVR4YNhoE3EvtnRR0Ig3heRKfdI9yWLY+O/iMpYu/qS/0HSyrrjmDd3shET6+FeRrCyibvVFfRVLaw0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cixtech.com; spf=pass smtp.mailfrom=cixtech.com; arc=fail smtp.client-ip=52.101.127.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cixtech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cixtech.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oFSSkfAkiTXET31cpKam2GoAhRgSCAY9CTL+i1rhmp4vpg37RUBH+pDYHUf2039YTd2HHpIBUmRMrBPf1VOkFdoeBcAuMBjq2BNScOvk9b9/IzoVEnCu+LKBJoN58ULFsBxdpK7MQ2B5iPiLaE2cCKLjCHJ42pymwIriRImiGPxoq3KM1NyNHVm/JD7Ts4s59girWpi65Bs8aJIx3XYJ+Y6HYFA6f0RLK6kPLJF4OcjoA1jv4r8O5WUuF2zRo0zYMhVAKVKpmVvwhaDcxH/tFv2EjKHNKDKeeMUIeuHEhGbzk7yX+iQ7EUzSAYHMtzj6hdfa1TrAqu2JW7vuPllECw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M9JYl8mIIrPCrvx3F0KP7Ptx4cmDd38dGZuq4n7LLd8=; b=V4mo7LjJx1HdA4UPMl+iFIAFxyKCAgWUBP0wbXOXokpbGZhTlltPuhwDSEJ/ja1Lek3Q46rGX6DyK+L1xWVigoVm/0wP3DFO/jolXlVE2leP9uVTgVWnj3LAudfi4m+HSqOHu2Kh5VpRCwFHOrFCvNdSyvpZunRiHXWGdyYYS/De9kwgTTr25suTyaOTcci/xQThoB3fWWE1joSBcKXJZe8lyAIRmZXQ4jviIKGWjrg+t9G/MosxdtN4KLP+L7g0rmi8FuqAj9+2aTYdK8Ii/JArPOfJVDqYcAnbZ2i7AsXf5wDvr8wMrHPdlSmIlEmlRI3gV+TyYf6dVoUMVM4FmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 222.71.101.198) smtp.rcpttodomain=arm.com smtp.mailfrom=cixtech.com; dmarc=bestguesspass action=none header.from=cixtech.com; dkim=none (message not signed); arc=none (0) Received: from OS7PR01CA0056.jpnprd01.prod.outlook.com (2603:1096:604:254::16) by KU2PPF40E30BD52.apcprd06.prod.outlook.com (2603:1096:d18::490) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.38; Mon, 7 Jul 2025 02:50:18 +0000 Received: from OSA0EPF000000CC.apcprd02.prod.outlook.com (2603:1096:604:254:cafe::3e) by OS7PR01CA0056.outlook.office365.com (2603:1096:604:254::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8901.26 via Frontend Transport; Mon, 7 Jul 2025 02:50:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 222.71.101.198) smtp.mailfrom=cixtech.com; dkim=none (message not signed) header.d=none;dmarc=bestguesspass action=none header.from=cixtech.com; Received-SPF: Pass (protection.outlook.com: domain of cixtech.com designates 222.71.101.198 as permitted sender) receiver=protection.outlook.com; client-ip=222.71.101.198; helo=smtprelay.cixcomputing.com; pr=C Received: from smtprelay.cixcomputing.com (222.71.101.198) by OSA0EPF000000CC.mail.protection.outlook.com (10.167.240.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.20 via Frontend Transport; Mon, 7 Jul 2025 02:50:18 +0000 Received: from nchen-desktop (unknown [172.16.64.25]) by smtprelay.cixcomputing.com (Postfix) with ESMTPSA id 4F17D4160CA0; Mon, 7 Jul 2025 10:50:17 +0800 (CST) Date: Mon, 7 Jul 2025 10:50:11 +0800 From: Peter Chen To: Krzysztof Kozlowski Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, jassisinghbrar@gmail.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com, maz@kernel.org, sudeep.holla@arm.com, kajetan.puchalski@arm.com, eballetb@redhat.com, Guomin Chen , Gary Yang Subject: Re: [PATCH v9 8/9] arm64: dts: cix: Add sky1 base dts initial support Message-ID: References: <20250609031627.1605851-1-peter.chen@cixtech.com> <20250609031627.1605851-9-peter.chen@cixtech.com> <507129db-a84e-489e-aed7-f1f86e6d188b@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <507129db-a84e-489e-aed7-f1f86e6d188b@kernel.org> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSA0EPF000000CC:EE_|KU2PPF40E30BD52:EE_ X-MS-Office365-Filtering-Correlation-Id: 130f3786-a2af-4e86-9f2b-08ddbd010207 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|7416014|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?MOmeQx5qmS8uAKfU56Xf3LBrGWZauyx/6efxTRC2zMW/6KGdcNjAU7RT///O?= =?us-ascii?Q?7ZHY1OFUxgBvPx12uSEI5T0rBpRY10SvOaBqp+h4JpJX5x2YO2oR/jTKpiTt?= =?us-ascii?Q?WH2uwStXc0yQQWD22Ti6O3+gbkS4IiXT7HBU/fETZlBvjc8t7btMeuULJxX4?= =?us-ascii?Q?nA87ijYqtl8nO9G94twGoqIqc7sd4bfJaD5rqyfg8Z0AH9u5/p7eVUqhczYb?= =?us-ascii?Q?PODwegVQdL9LvEB4RUgm7eUJoD3rtRgyT+yiB/nRJXNjfZxjbIsiNiGI899H?= =?us-ascii?Q?qP5ioixsi/PcvexTJ3HjuyW4EoFJB7YCyexz1ehn503gCT073PTEV8Uk/Lps?= =?us-ascii?Q?4rn571M0GcexQv3CIIH9wAtinypBMOenRP9gDmHSyM9h9o12My4vZ+mzVWq9?= =?us-ascii?Q?tqgPN7lRcRbhgOm9vVaCxIBdNN5TUJyVEAwEZ1MNyy/cGPz3A2KCbZLr4LPJ?= =?us-ascii?Q?OXPXuHQ2U/DBCCYi1jWxKDJEtBjywAtsp6bJtQLG77cWd7x7TUtPu1FN6OZh?= =?us-ascii?Q?E0U6ex4iq5BcM2RlqxAHkkKrkfWTW8TH5YQRsdbRqRn6c9RyazjeIxggU+g+?= =?us-ascii?Q?gb+yJ12MjohhqICChW1GkazLY0zc4TjvdsGeW7Z4aTocng4bTs/d/uW/tCVZ?= =?us-ascii?Q?bCZap5qqfTvGYGXP3UNmq0lr+2waCTfqH0kz5he+J/OOAQfkvcPZOslnUt6Q?= =?us-ascii?Q?ickmrf8n+9Ke5Al8/opS0F+jgFjMOCXXrpMXFOHi2aSImTQoHBfbnD83RYMg?= =?us-ascii?Q?2qGW58UyNEciMHPBe1aVghmdhgeYDjczzEv1qPJ3+owcd64ZryhguD3ju465?= =?us-ascii?Q?clVhU9peuOT+Dm61d62ICrVuNqMLYBBsldakMyCtkDZbUihDHuUHZeg/IiBG?= =?us-ascii?Q?YHsKmss6En9rFQmQ1kkcfE/h8Wi/frtz2JbjHrCF2UqkPWQ7JQjy5/SXLuKp?= =?us-ascii?Q?TJAyKwHi8pyKGjMIY+G7HEJdk0K3Mgl9qBBJoAnxMgtKsMUVTFUdsWCYvgb1?= =?us-ascii?Q?E7PU+Q2vvufh5nQpLBeTQdhnfzWWL4xQmtbbxIv5FXw1RYX9MS58xIWQsKhR?= =?us-ascii?Q?5vAd+wR8wdXpHRpedSiWApb9XBI0IYHgkPgIMWzyByj3oMwq7uQ0zIlGwVjf?= =?us-ascii?Q?GWaJe/4jmIXxOjhWyShnW3o0sAqLTCG5Jh9xAjNgfEW4zPcdeXANeeEDnyeT?= =?us-ascii?Q?IXKphy4D6Qrh2SjdqVrVTx4dIIapR5c5xzPSLoaGwrtkdqDj0CoTQKjWAS+l?= =?us-ascii?Q?9mWJYir2x+0LwWd3n4XsHAiq+OB/nmGmEPrXvB2UzpJ2LSo83QuzsNO3g/50?= =?us-ascii?Q?nq0h6w7zB2HvIVukaCSbwlERIxQvAoxsEVhWvnBSBL81lCpd3sVncRxQQUIW?= =?us-ascii?Q?1n+06/hqtGEm8p+ghl4vWIbkX/busCseiHsn6O2b8BylU2CpZGr/WFRPn96A?= =?us-ascii?Q?nJvMixJ6SaSPC9hNZh+8Ep49uDfy5QJ9/3B7+qEG9GBtVQCnXg8VQ8Xcrnfo?= =?us-ascii?Q?+DibPfvbJAfjVUg8ig53m93vTUAkm+NxDmKY?= X-Forefront-Antispam-Report: CIP:222.71.101.198;CTRY:CN;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:smtprelay.cixcomputing.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(7416014)(376014)(82310400026);DIR:OUT;SFP:1102; X-OriginatorOrg: cixtech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2025 02:50:18.1061 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 130f3786-a2af-4e86-9f2b-08ddbd010207 X-MS-Exchange-CrossTenant-Id: 0409f77a-e53d-4d23-943e-ccade7cb4811 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0409f77a-e53d-4d23-943e-ccade7cb4811;Ip=[222.71.101.198];Helo=[smtprelay.cixcomputing.com] X-MS-Exchange-CrossTenant-AuthSource: OSA0EPF000000CC.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: KU2PPF40E30BD52 On 25-07-05 10:20:34, Krzysztof Kozlowski wrote: Thanks, Krzysztof. All below commands will be addressed at next revision patch set. Peter > > On 09/06/2025 05:16, Peter Chen wrote: > > + > > + firmware { > > + ap_to_pm_scmi: scmi { > > + compatible = "arm,scmi"; > > + mbox-names = "tx", "rx"; > > + mboxes = <&mbox_ap2pm 8>, <&mbox_pm2ap 8>; > > + shmem = <&ap2pm_scmi_mem &pm2ap_scmi_mem>; > > These are two entries, so two <>. > > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + scmi_clk: protocol@14 { > > + reg = <0x14>; > > + #clock-cells = <1>; > > + }; > > + > > Drop blank line > > > + }; > > + }; > > + > > + pmu-a520 { > > + compatible = "arm,cortex-a520-pmu"; > > + interrupts = ; > > + }; > > + > > + pmu-a720 { > > + compatible = "arm,cortex-a720-pmu"; > > + interrupts = ; > > + }; > > + > > > ... > > > + > > + mbox_ap2se: mailbox@5060000 { > > + compatible = "cix,sky1-mbox"; > > + reg = <0x0 0x05060000 0x0 0x10000>; > > + interrupts = ; > > + #mbox-cells = <1>; > > + cix,mbox-dir = "tx"; > > + }; > > + > > + mbox_se2ap: mailbox@5070000 { > > + compatible = "cix,sky1-mbox"; > > + reg = <0x0 0x05070000 0x0 0x10000>; > > + interrupts = ; > > + #mbox-cells = <1>; > > + cix,mbox-dir = "rx"; > > + }; > > + > > + ap2pm_scmi_mem: ap2pm-shmem@6590000 { > > This should be just shmem@ > > > + compatible = "arm,scmi-shmem"; > > + reg = <0x0 0x06590000 0x0 0x80>; > > + reg-io-width = <4>; > > + }; > > + > > + mbox_ap2pm: mailbox@6590080 { > > + compatible = "cix,sky1-mbox"; > > + reg = <0x0 0x06590080 0x0 0xff80>; > > + interrupts = ; > > + #mbox-cells = <1>; > > + cix,mbox-dir = "tx"; > > + }; > > + > > + pm2ap_scmi_mem: pm2ap-shmem@65a0000 { > > Same here > > > + compatible = "arm,scmi-shmem"; > > + reg = <0x0 0x065a0000 0x0 0x80>; > > + reg-io-width = <4>; > > + }; > Best regards, > Krzysztof -- Best regards, Peter