Re: [PATCH v5 4/5] media: venus: core: Add qcm2290 DT compatible and resource data

Jorge Ramirez
2025-07-13T08:19:17Z

On 07/07/25 11:19:33, Konrad Dybcio wrote:
> On 7/7/25 11:09 AM, Jorge Ramirez wrote:
> > On 27/06/25 18:46:10, Dikshita Agarwal wrote:
> >>
> >>
> >> On 6/26/2025 7:29 PM, Jorge Ramirez-Ortiz wrote:
> >>> Add a qcm2290 compatible binding to the venus core.
> >>>
> >>> Video encoding support is not exposed until the relevant hardware
> >>> capabilities are enabled.
> >>>
> >>> Co-developed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> >>> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> >>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
> >>> ---
> >>> drivers/media/platform/qcom/venus/core.c | 39 ++++++++++++++++++++++++
> >>> 1 file changed, 39 insertions(+)
> >>>
> >>> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> >>> index 736ef53d988d..f1f211ca1ce2 100644
> >>> --- a/drivers/media/platform/qcom/venus/core.c
> >>> +++ b/drivers/media/platform/qcom/venus/core.c
> >>> @@ -1062,6 +1062,44 @@ static const struct venus_resources sc7280_res = {
> >>> .enc_nodename = "video-encoder",
> >>> };
> >>>
> >>> +static const struct freq_tbl qcm2290_freq_table[] = {
> >>> + { 352800, 240000000 }, /* 1920x1088 @ 30 + 1280x720 @ 30 */
> >>> + { 244800, 133000000 }, /* 1920x1088 @ 30 */
> >>> +};
> >>> +
> >> fix this corner.
> >
> > ok, will wait for Vikash to confirm the other ones.
>
> Actually you can get rid of it now, I think:
>
> https://git.linuxtv.org/media.git/commit/?id=b179234b5e59013f8772da17b273f463f9720bdd
>
> Konrad

yes, thanks!