From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D5731A23A9 for ; Mon, 7 Jul 2025 09:15:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751879757; cv=none; b=sPTooe1ST00N/ABmS47jAohE7vVj9Lits4ifVjD2QfbPvWIq3MFEogOgdKNUKVZ0cKEXvpZzrlgU19taGieqrn5k+8xDPIDjvSvgD85N4lZUXsVQhIFly3y+9fvybdIxpu0VehLCzrviI68/Y7f5anie4WjkPn71Ujt8MGRZiHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751879757; c=relaxed/simple; bh=1xedEVDzsSxxbrLYD+QB7jvQWEPveVoc0Amb9x1OZm4=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VhI1Ve+DZWFNlLaUk1yDg7g11ie0G5aQz1IYvHX8pN3Uba4R/03jzIwHpvjNNZiBJf7ljE0S3D4o3wyGigjk6u5ktulxXxD5hGukznKGtoBhT33u+/4Fm+zi2GcCU6CnWNTn2ktU/YIQa/XQpRo+sUyHW/AT3xK7yEZQHLgUCD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Swleq3Ic; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Swleq3Ic" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 566MJIco000498 for ; Mon, 7 Jul 2025 09:15:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=EaUOc8gZnCaiHfxMVU/rdhzj ZBI8Ckok1Y/QujtjMx8=; b=Swleq3IcdpUXqWzYole/NGaH1CtisoWQwetpdhsX dIfw6VYNhJEYSN7CRc9ABwpPZHfAaEbtz6+MgIcjTIaJkIuDWkOJeGYTrTM9Zx2D D+t0UADw6/+NFSVebUP8zRVcyT4hI6jYxHK3ghUKmSXKqxhU87OyTBxnOMOhyGU9 KoHR4CEKxmq4Ofu1aRTBHwvF6G6SfLOFViHfgV4Xaknqq0YPTro+mSSi0KX72Sen hn3XnI6gihWOK6rMxIEtgHxjkus9hB1IxyTDvR4Ww8PmP01kgXKaa7awga67v0in 6mfv2Pp7NlH66i5k86SGzQnkTgBCcTELjsABVJdwG3xlZQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47pun2btuy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 07 Jul 2025 09:15:54 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4a44c8e11efso99536091cf.0 for ; Mon, 07 Jul 2025 02:15:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751879754; x=1752484554; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EaUOc8gZnCaiHfxMVU/rdhzjZBI8Ckok1Y/QujtjMx8=; b=ntAuT2Nwg+68aCYrVsUtn6ZzxVa9NpDYI6kmhRQbDyr3GlZVOUh4nEhmKUggaDVFqD 6S2lZFyPp8/CAWnDlULbEopPaFRZKFlAr4etg0D+YI8yUG8xyHqja/KSc1yWR+I9fN8V a88fQIlWYyaAJ/9zFHZFg8nng58W03Zj6GhfaKTKPE7PQSD3LBcASWuypSsBlTDlB2e2 iImuEELydlfeFdAqhvujaTMPitJdY06b7rGmvzSapW5eQcx319FmA6h34wpY++Pbs/hS zG8xM9ElcRXsSNfP2MXB36nWslNaHeKpnlvhRVsWO/EXzPS8QBBolPfT4OIe26vUYxj8 fJHQ== X-Forwarded-Encrypted: i=1; AJvYcCWzK/njWQnTJ1IdihScOhUK7iwh64yRV6LKjTGk136PUqLh8v84x0ESxGOhlYeOHfu87AQ7BEGMiAG6@vger.kernel.org X-Gm-Message-State: AOJu0Yw9u6pL9K34ymZT2N7hBMo864IZRljyT2LjNh+FTiBLa5SOz9Mu D02W88pXd2aBRwWvAm4yErRnU3bfAmby22EDEQR53dObOjNL2cqlz4SAMTTki6q3hN0GliAA4P5 PdEZPlagSp69+F1pYJTkgTNHsOgBzt/EizUgSjz/v7Db8NIVk0LAN3Al8ha61wtJJ X-Gm-Gg: ASbGncvYXeZWP8NYMfpAozrgfrio38zc2T/XoRp403N2P/rMdNSmf8IkueKrjwKSjWF A144dQtKOtuO/3XY55I0eWqWUQvZb8ZMiOyfhVCnDIWV76y/x0auaoAsb5wpa4cZ0F/D3XEJKwS 3abplbfNa1qj93kBN7ZT8rWIaTS+DiTeT6VbRaYTnzDxqEfnY6kHdkMtW4u/ndJ3CJYrrr7izqB oBDZGTIT1hZQC9vhw4TXmTXnbGlElhSIFrKnotK36sjNake1/4H4OIfWaLcg29JQ/rOssV/4WwX KZM39EFZ5NhTycAVnPeh9YYk3/+6ukf6n5Eu5Bn12CR3DIlc0LHqByQ= X-Received: by 2002:a05:620a:1aa7:b0:7d4:57a5:9742 with SMTP id af79cd13be357-7d5dcd0783amr1550595385a.39.1751879754058; Mon, 07 Jul 2025 02:15:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVADocE7bXOXurJZ6dv/hL0nI9aX9Csz55eF2TfSxS1UBR2Q2notThFEzW/XQxmcaZfbwOTg== X-Received: by 2002:a05:620a:1aa7:b0:7d4:57a5:9742 with SMTP id af79cd13be357-7d5dcd0783amr1550592085a.39.1751879753422; Mon, 07 Jul 2025 02:15:53 -0700 (PDT) Received: from trex (97.red-79-144-186.dynamicip.rima-tde.net. [79.144.186.97]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a9bcebf7sm136453855e9.21.2025.07.07.02.15.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 02:15:52 -0700 (PDT) From: Jorge Ramirez X-Google-Original-From: Jorge Ramirez Date: Mon, 7 Jul 2025 11:15:51 +0200 To: Konrad Dybcio Cc: Vikash Garodia , Jorge Ramirez , krzk+dt@kernel.org, bryan.odonoghue@linaro.org, quic_dikshita@quicinc.com, mchehab@kernel.org, robh@kernel.org, conor+dt@kernel.org, konradybcio@kernel.org, andersson@kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 5/5] arm64: dts: qcom: qcm2290: Add venus video node Message-ID: References: <20250626135931.700937-1-jorge.ramirez@oss.qualcomm.com> <20250626135931.700937-6-jorge.ramirez@oss.qualcomm.com> <6e330e8f-5856-ef8e-5fe3-52bd61b59e02@quicinc.com> <2722e70a-1080-c9f3-eb56-4a6e79084bdc@quicinc.com> <7df8a438-364e-431e-8424-209ad7482efc@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7df8a438-364e-431e-8424-209ad7482efc@oss.qualcomm.com> X-Proofpoint-GUID: 6hcKvaD-xkanhrf-5iAR0C5X7ELjp7m0 X-Authority-Analysis: v=2.4 cv=GdUXnRXL c=1 sm=1 tr=0 ts=686b904a cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=oX6B8lV6/A+qF9mARCc04Q==:17 a=kj9zAlcOel0A:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=g0UWXt2G9gbouz_zptwA:9 a=CjuIK1q_8ugA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: 6hcKvaD-xkanhrf-5iAR0C5X7ELjp7m0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzA3MDA1MyBTYWx0ZWRfX4B7r6nlE/0MG RlxweBPjV0c5yBkw9x1VDpN9gAQnAVOHab5cua2aVStI6qDIQlv7PpALSANPNoKu6I0WHKghN8c ch4UDqYxT9I3IomKHAy+STQ4ytsLJirvCpmsyX68AZeVlQcIlcMn9F0fEZIPTLkiFUqslE9gg79 r2p45oF5yyXvKut6kCQ5f0pY7Fjc2zwAE9+jPjR8xy308D+N5t2kgV4kOTWoAsx5R9VACLq3noF e4muGgIJDybMCwMZh8iM+YXAnjPyqL6D1hs773shAYo9bOOAPe79pP3aKfdzo4rib3aUtXscat6 mdGZDmG5aWdZ9AFxxCU4lv4ExrxDSEQwrveepMi45lmJX2zyya1vmB3F8rF1CknskZQbBejJdXC hCGwcSGiqa98IpJO3EMH11CiVl9T+F9Jsz3eUcV3d0M7Vz3CGXR42NbCgnzAkrqvpXYlDkgR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-07_01,2025-07-07_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 malwarescore=0 mlxscore=0 phishscore=0 impostorscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507070053 On 27/06/25 17:27:04, Konrad Dybcio wrote: > On 6/27/25 5:23 PM, Vikash Garodia wrote: > > > > On 6/27/2025 8:50 PM, Konrad Dybcio wrote: > >> On 6/27/25 5:12 PM, Vikash Garodia wrote: > >>> > >>> On 6/27/2025 8:38 PM, Jorge Ramirez wrote: > >>>> On 27/06/25 20:28:29, Vikash Garodia wrote: > >>>>> > >>>>> On 6/27/2025 6:03 PM, Jorge Ramirez wrote: > >>>>>> On 27/06/25 17:40:19, Vikash Garodia wrote: > >>>>>>> > >>>>>>> On 6/26/2025 7:29 PM, Jorge Ramirez-Ortiz wrote: > >>>>>>>> Add DT entries for the qcm2290 venus encoder/decoder. > >>>>>>>> > >>>>>>>> Co-developed-by: Loic Poulain > >>>>>>>> Signed-off-by: Loic Poulain > >>>>>>>> Signed-off-by: Jorge Ramirez-Ortiz > >>>>>>>> --- > >>>>>>>> arch/arm64/boot/dts/qcom/qcm2290.dtsi | 57 +++++++++++++++++++++++++++ > >>>>>>>> 1 file changed, 57 insertions(+) > >>>>>>>> > >>>>>>>> diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi > >>>>>>>> index f49ac1c1f8a3..5326c91a0ff0 100644 > >>>>>>>> --- a/arch/arm64/boot/dts/qcom/qcm2290.dtsi > >>>>>>>> +++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi > >>>>>>>> @@ -1628,6 +1628,63 @@ adreno_smmu: iommu@59a0000 { > >>>>>>>> #iommu-cells = <2>; > >>>>>>>> }; > >>>>>>>> > >>>>>>>> + venus: video-codec@5a00000 { > >>>>>>>> + compatible = "qcom,qcm2290-venus"; > >>>>>>>> + reg = <0 0x5a00000 0 0xf0000>; > >>>>>>>> + interrupts = ; > >>>>>>>> + > >>>>>>>> + power-domains = <&gcc GCC_VENUS_GDSC>, > >>>>>>>> + <&gcc GCC_VCODEC0_GDSC>, > >>>>>>>> + <&rpmpd QCM2290_VDDCX>; > >>>>>>>> + power-domain-names = "venus", > >>>>>>>> + "vcodec0", > >>>>>>>> + "cx"; > >>>>>>>> + operating-points-v2 = <&venus_opp_table>; > >>>>>>>> + > >>>>>>>> + clocks = <&gcc GCC_VIDEO_VENUS_CTL_CLK>, > >>>>>>>> + <&gcc GCC_VIDEO_AHB_CLK>, > >>>>>>>> + <&gcc GCC_VENUS_CTL_AXI_CLK>, > >>>>>>>> + <&gcc GCC_VIDEO_THROTTLE_CORE_CLK>, > >>>>>>>> + <&gcc GCC_VIDEO_VCODEC0_SYS_CLK>, > >>>>>>>> + <&gcc GCC_VCODEC0_AXI_CLK>; > >>>>>>>> + clock-names = "core", > >>>>>>>> + "iface", > >>>>>>>> + "bus", > >>>>>>>> + "throttle", > >>>>>>>> + "vcodec0_core", > >>>>>>>> + "vcodec0_bus"; > >>>>>>>> + > >>>>>>>> + memory-region = <&pil_video_mem>; > >>>>>>>> + iommus = <&apps_smmu 0x860 0x0>, > >>>>>>>> + <&apps_smmu 0x880 0x0>, > >>>>>>>> + <&apps_smmu 0x861 0x04>, > >>>>>>>> + <&apps_smmu 0x863 0x0>, > >>>>>>>> + <&apps_smmu 0x804 0xe0>; > >>>>>>> keep only the non secure ones. > >>>>>> > >>>>>> ok > >>>>>> > >>>>>>>> + > >>>>>>>> + interconnects = <&mmnrt_virt MASTER_VIDEO_P0 RPM_ALWAYS_TAG > >>>>>>>> + &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>, > >>>>>>>> + <&bimc MASTER_APPSS_PROC RPM_ACTIVE_TAG > >>>>>>>> + &config_noc SLAVE_VENUS_CFG RPM_ACTIVE_TAG>; > >>>>>>>> + interconnect-names = "video-mem", > >>>>>>>> + "cpu-cfg"; > >>>>>>>> + > >>>>>>>> + status = "okay"; > >>>>>>>> + > >>>>>>>> + venus_opp_table: opp-table { > >>>>>>>> + compatible = "operating-points-v2"; > >>>>>>>> + > >>>>>>>> + opp-133000000 { > >>>>>>>> + opp-hz = /bits/ 64 <133000000>; > >>>>>>>> + required-opps = <&rpmpd_opp_low_svs>; > >>>>>>>> + }; > >>>>>>> Fix the corner freq value > >>>>>> > >>>>>> can you add some reference please? > >>>>>> > >>>>>> I took this data from an internal document - not sure why the downstream > >>>>>> driver supports different values or where those were taken from (AFAIK > >>>>>> they are not supported) > >>>>> Most likely you have referred incorrect downstream file. Refer scuba-vidc.dtsi. > >>>> > >>>> I took them from actual documents (which might or might not be obsolete, > >>>> hard to say but they were the latest version and as such, they > >>>> contradict the downstream dtsi). > >>>> > >>>> So I'd rather not use downstream - could you point me to the reference > >>>> you used please - I wonder if the fix is required downstream instead of here? > >>> > >>> You can look for this file gcc-scuba.c and refer gcc_video_venus_clk_src which > >>> is the src for different venus clocks. > >> > >> This is not a good source in general, GCC often has more rates defined > >> than the consumer is supposed to finally run at (because they were deemed > >> power-inefficient or similar, you can pretty much set any rate you want > >> on the clocks fwiw) > > Count wise, i agree. Value-wise, afaik, corners should match OR are you saying > > client scaling request for 133.0 MHz is ok when src is generating 133.33 MHz ? > > I *think* we're running a closest-match in there.. but I'd love to > have the clock and consumer drivers agree on the rate exactly > (which in this case would be 133333333 - and the clock plan in > our docs agrees) > ok, will use this instead > Konrad