Re: [PATCH 1/5] pinctrl: sunxi: Fix a100 emac pin function name

Paul Kocialkowski
2025-07-07T13:20:13Z

[-- Attachment #1: Type: text/plain, Size: 16399 bytes --]

Hi,

Le Mon 07 Jul 25, 13:38, Andre Przywara a écrit :
> On Mon, 7 Jul 2025 12:40:46 +0200
> Paul Kocialkowski <paulk@sys-base.io> wrote:
>
> > Chen-Yu,
> >
> > > > > The block is the same, but the integration is slightly different, as
> > > > > the register for the RGMII clock delays and other stuff is at a different
> > > > > offset in the system controller. The BSP handles this by directly
> > > > > including the register in the "reg" property.
> > > >
> > > > Ah I see, I forgot about the syscon register. However it doesn't seem like a
> > > > very good approach to have a different compatible to express the idea that an
> > > > external resource is different. Just like we do for clocks, resets and other
> > > > things, we should probably find a way to express the offset via some dedicated
> > > > property instead of spinning a different compatible each time it changes.
> > > >
> > > > > So yes, you do need a separate compatible string, if only to deal with
> > > > > the slight difference in the integration layer.
> > > >
> > > > So maybe an additional allwinner,syscon-offset property or a new
> > >
> > > If you can get that accepted, I think that works?
> > >
> > > > allwinner,syscon that takes the syscon phandle first and the offset second?
> > >
> > > I would prefer to avoid any changes to the syscon reference that would
> > > require more custom code. I only just recently found that we could use
> > > the standard syscon code with the provider registering the syscon. We
> > > could drop the of_parse_phandle() + find device + dev_get_regmap() bits.
> > > This is partially covered in my GMAC200 series.
> >
> > There is already syscon_regmap_lookup_by_phandle_args which supports generic
> > extra arguments to a syscon node. It just requires a custom syscon property.
> >
> > I personally find this cleaner than adding a property just for the offset.
>
> Well, I proposed that already for the H616, where the second EMAC has the
> same problem with the syscon at 0x34 instead of 0x30:
>
> https://lore.kernel.org/linux-sunxi/20210615110636.23403-10-andre.przywara@arm.com/
>
> I don't remember the details, but it got eventually dropped, partly
> because the 2nd EMAC isn't supported yet due to missing AC200/AC300
> support.
> My plan was to let <&syscon> be the same as <&syscon 0>, which would
> preserve compatibility.

Well the syscon property is already defined in the binding as a single phandle
so I'm not sure we could just extend it. It looks like other consumers that
require an extra argument typically have a vendor prefix.

> Though I am not sure the fallback compatible is
> then correct, because it typically means that older driver can cope with
> those devices, which isn't really the case here.
>
> But we could postpone this issue as well for the A133, to the day when
> there will be a device using this 2nd MAC.

Yes as long as this opens a way to support both EMACs with the same compatible
it sounds good to me. No need to implement this right now.

So with the sunxi device-tree patches out I think we're only looking at the
pinctrl tree. I can see the patches were pushed on the repo now, so I should
probably better send a revert at this point.

All the best,

Paul

> Cheers,
> Andre
>
>
> >
> > Paul
> >
> > > ChenYu
> > >
> > > > It seems that various other platforms are doing similar things (e.g.
> > > > ti,syscon-pcie-mode).
> > > >
> > > > Thanks
> > > >
> > > > Paul
> > > >
> > > > >
> > > > > ChenYu
> > > > >
> > > > > > [0]: https://github.com/engSinteck/A133_Image/blob/main/longan/kernel/linux-4.9/arch/arm64/boot/dts/sunxi/sun50iw10p1.dtsi#L2016
> > > > > > [1]: https://github.com/engSinteck/A133_Image/blob/main/longan/kernel/linux-4.9/drivers/net/ethernet/allwinner/sunxi-gmac.c
> > > > > >
> > > > > > All the best,
> > > > > >
> > > > > > Paul
> > > > > >
> > > > > > >
> > > > > > > ChenYu
> > > > > > >
> > > > > > >
> > > > > > > > Cheers,
> > > > > > > >
> > > > > > > > Paul
> > > > > > > >
> > > > > > > > > Cheers,
> > > > > > > > > Andre.
> > > > > > > > >
> > > > > > > > > > [1]
> > > > > > > > > > https://github.com/qiaoweibiao/T507_Kernel/blob/main/arch/arm64/boot/dts/sunxi/sun50iw10p1.dtsi
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > Fixes: 473436e7647d ("pinctrl: sunxi: add support for the Allwinner A100 pin controller")
> > > > > > > > > > > Signed-off-by: Paul Kocialkowski <paulk@sys-base.io>
> > > > > > > > > > > ---
> > > > > > > > > > > drivers/pinctrl/sunxi/pinctrl-sun50i-a100.c | 32 ++++++++++-----------
> > > > > > > > > > > 1 file changed, 16 insertions(+), 16 deletions(-)
> > > > > > > > > > >
> > > > > > > > > > > diff --git a/drivers/pinctrl/sunxi/pinctrl-sun50i-a100.c b/drivers/pinctrl/sunxi/pinctrl-sun50i-a100.c
> > > > > > > > > > > index b97de80ae2f3..95b764ee1c0d 100644
> > > > > > > > > > > --- a/drivers/pinctrl/sunxi/pinctrl-sun50i-a100.c
> > > > > > > > > > > +++ b/drivers/pinctrl/sunxi/pinctrl-sun50i-a100.c
> > > > > > > > > > > @@ -546,33 +546,33 @@ static const struct sunxi_desc_pin a100_pins[] = {
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > SUNXI_FUNCTION(0x1, "gpio_out"),
> > > > > > > > > > > SUNXI_FUNCTION(0x2, "i2c0"), /* SCK */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* RXD1 */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* RXD1 */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 0)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 1),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > SUNXI_FUNCTION(0x1, "gpio_out"),
> > > > > > > > > > > SUNXI_FUNCTION(0x2, "i2c0"), /* SDA */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* RXD0 */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* RXD0 */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 1)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 2),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > SUNXI_FUNCTION(0x1, "gpio_out"),
> > > > > > > > > > > SUNXI_FUNCTION(0x2, "i2c1"), /* SCK */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* RXCTL */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* RXCTL */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 2)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 3),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > SUNXI_FUNCTION(0x1, "gpio_out"),
> > > > > > > > > > > SUNXI_FUNCTION(0x2, "i2c1"), /* SDA */
> > > > > > > > > > > SUNXI_FUNCTION(0x3, "cir0"), /* OUT */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* CLKIN */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* CLKIN */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 3)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 4),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > SUNXI_FUNCTION(0x1, "gpio_out"),
> > > > > > > > > > > SUNXI_FUNCTION(0x2, "uart3"), /* TX */
> > > > > > > > > > > SUNXI_FUNCTION(0x3, "spi1"), /* CS */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* TXD1 */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* TXD1 */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 4)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 5),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > @@ -580,14 +580,14 @@ static const struct sunxi_desc_pin a100_pins[] = {
> > > > > > > > > > > SUNXI_FUNCTION(0x2, "uart3"), /* RX */
> > > > > > > > > > > SUNXI_FUNCTION(0x3, "spi1"), /* CLK */
> > > > > > > > > > > SUNXI_FUNCTION(0x4, "ledc"),
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* TXD0 */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* TXD0 */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 5)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 6),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > SUNXI_FUNCTION(0x1, "gpio_out"),
> > > > > > > > > > > SUNXI_FUNCTION(0x2, "uart3"), /* RTS */
> > > > > > > > > > > SUNXI_FUNCTION(0x3, "spi1"), /* MOSI */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* TXCK */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* TXCK */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 6)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 7),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > @@ -595,7 +595,7 @@ static const struct sunxi_desc_pin a100_pins[] = {
> > > > > > > > > > > SUNXI_FUNCTION(0x2, "uart3"), /* CTS */
> > > > > > > > > > > SUNXI_FUNCTION(0x3, "spi1"), /* MISO */
> > > > > > > > > > > SUNXI_FUNCTION(0x4, "spdif"), /* OUT */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* TXCTL */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* TXCTL */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 7)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 8),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > @@ -611,7 +611,7 @@ static const struct sunxi_desc_pin a100_pins[] = {
> > > > > > > > > > > SUNXI_FUNCTION(0x2, "dmic"), /* DATA0 */
> > > > > > > > > > > SUNXI_FUNCTION(0x3, "spi2"), /* CLK */
> > > > > > > > > > > SUNXI_FUNCTION(0x4, "i2s2"), /* BCLK */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* MDC */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* MDC */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 9)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 10),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > @@ -619,7 +619,7 @@ static const struct sunxi_desc_pin a100_pins[] = {
> > > > > > > > > > > SUNXI_FUNCTION(0x2, "dmic"), /* DATA1 */
> > > > > > > > > > > SUNXI_FUNCTION(0x3, "spi2"), /* MOSI */
> > > > > > > > > > > SUNXI_FUNCTION(0x4, "i2s2"), /* LRCK */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* MDIO */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* MDIO */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 10)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 11),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > @@ -642,33 +642,33 @@ static const struct sunxi_desc_pin a100_pins[] = {
> > > > > > > > > > > SUNXI_FUNCTION(0x1, "gpio_out"),
> > > > > > > > > > > SUNXI_FUNCTION(0x3, "i2c3"), /* SCK */
> > > > > > > > > > > SUNXI_FUNCTION(0x4, "i2s3"), /* MCLK */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* EPHY */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* EPHY */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 13)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 14),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > SUNXI_FUNCTION(0x1, "gpio_out"),
> > > > > > > > > > > SUNXI_FUNCTION(0x4, "i2s3"), /* BCLK */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* RXD3 */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* RXD3 */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 14)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 15),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > SUNXI_FUNCTION(0x1, "gpio_out"),
> > > > > > > > > > > SUNXI_FUNCTION(0x4, "i2s3"), /* LRCK */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* RXD2 */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* RXD2 */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 15)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 16),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > SUNXI_FUNCTION(0x1, "gpio_out"),
> > > > > > > > > > > SUNXI_FUNCTION(0x3, "i2s3_dout0"), /* DOUT0 */
> > > > > > > > > > > SUNXI_FUNCTION(0x4, "i2s3_din1"), /* DIN1 */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* RXCK */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* RXCK */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 16)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 17),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > SUNXI_FUNCTION(0x1, "gpio_out"),
> > > > > > > > > > > SUNXI_FUNCTION(0x3, "i2s3_dout1"), /* DOUT1 */
> > > > > > > > > > > SUNXI_FUNCTION(0x4, "i2s3_din0"), /* DIN0 */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* TXD3 */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* TXD3 */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 17)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 18),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > > > @@ -676,7 +676,7 @@ static const struct sunxi_desc_pin a100_pins[] = {
> > > > > > > > > > > SUNXI_FUNCTION(0x2, "cir0"), /* OUT */
> > > > > > > > > > > SUNXI_FUNCTION(0x3, "i2s3_dout2"), /* DOUT2 */
> > > > > > > > > > > SUNXI_FUNCTION(0x4, "i2s3_din2"), /* DIN2 */
> > > > > > > > > > > - SUNXI_FUNCTION(0x5, "emac0"), /* TXD2 */
> > > > > > > > > > > + SUNXI_FUNCTION(0x5, "emac"), /* TXD2 */
> > > > > > > > > > > SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 18)),
> > > > > > > > > > > SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 19),
> > > > > > > > > > > SUNXI_FUNCTION(0x0, "gpio_in"),
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Paul Kocialkowski,
> > > > > > > >
> > > > > > > > Independent contractor - sys-base - https://www.sys-base.io/
> > > > > > > > Free software developer - https://www.paulk.fr/
> > > > > > > >
> > > > > > > > Expert in multimedia, graphics and embedded hardware support with Linux.
> > > > > >
> > > > > > --
> > > > > > Paul Kocialkowski,
> > > > > >
> > > > > > Independent contractor - sys-base - https://www.sys-base.io/
> > > > > > Free software developer - https://www.paulk.fr/
> > > > > >
> > > > > > Expert in multimedia, graphics and embedded hardware support with Linux.
> > > >
> > > > --
> > > > Paul Kocialkowski,
> > > >
> > > > Independent contractor - sys-base - https://www.sys-base.io/
> > > > Free software developer - https://www.paulk.fr/
> > > >
> > > > Expert in multimedia, graphics and embedded hardware support with Linux.
> >
>

--
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]