From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D97F611E; Fri, 11 Jul 2025 02:31:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752201089; cv=none; b=JEGcFPn6olruuVk4m1NuNfKSZWjg2hJ2kjecJx2wDQ04GZH8dm8woWRy3aCXdzuKV+uRkgOWi7JTZ2HJhEuWTB9s3UFUObaYX9G+OML3aVtp36Vx4nbkcpaXS8rkBwQxaY/P4BN+rjGUy92D2cRc2VEH209XdydqFIqMbiiSj4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752201089; c=relaxed/simple; bh=1H7MhhPsRYIi3B2WvPg7/QFrezoDYvrrBJBrddaWH/A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=vBm//efczSDBE8n2QCeJYgiijxeQ/bqkIvTe6Tdu/2L74z6KmAjB+QKmURs981PYAGkinvYlwvr8ZE/4PX8e942fpNRHGLDV9nDJPqs+o87AC1hZ3XYwukAblNBAhZXtszRqlJGkKgweBhUo7mR6bas/ys38VkBWaOtyrc5yrVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=e65/0Cdq; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="e65/0Cdq" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A796B207A3; Fri, 11 Jul 2025 04:31:23 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id nd2XZagNVK2w; Fri, 11 Jul 2025 04:31:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1752201082; bh=1H7MhhPsRYIi3B2WvPg7/QFrezoDYvrrBJBrddaWH/A=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=e65/0CdqgXBqH3SXxJ+7OS9YEV2xg+rDLMIRey+xXyVv6EHaA+T14aue9BeiEIBi8 uoGa7TyaiUR8IcPQVeGGHZFtuJiyyGL7S1m9DQVcPo81uV0ZEgAFWEly/3sTI0k53i v8/5PquQTmb82voUxyrnoYxf0H53FfNdzUUNAMreVowKw7qaK9kK6YwC8tPUerbub3 uvSagapy8Gy33k63uVANzdDSiju5rr4gRAZ1qTzo1Q0pAN7qVC9plxLPPiYZelnhkd BQKoiViszZYTS37UsY1w3cpZKty5JBM0m9eS2jt3LsCJZVegL/YGJ56pLHyhE1W7mz KqsgN3jYbJI6w== Date: Fri, 11 Jul 2025 02:31:07 +0000 From: Yao Zi To: Krzysztof Kozlowski Cc: Yinbo Zhu , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Huacai Chen , WANG Xuerui , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, Mingcong Bai , Kexy Biscuit Subject: Re: [PATCH v2 1/8] dt-bindings: clock: loongson2: Add Loongson 2K0300 compatible Message-ID: References: <20250617162426.12629-1-ziyao@disroot.org> <20250617162426.12629-2-ziyao@disroot.org> <20250627-gay-sepia-reindeer-2fde2a@krzk-bin> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jun 27, 2025 at 11:52:41AM +0000, Yao Zi wrote: > On Fri, Jun 27, 2025 at 10:03:53AM +0200, Krzysztof Kozlowski wrote: > > On Tue, Jun 17, 2025 at 04:24:19PM +0000, Yao Zi wrote: > > > Document the clock controller shipped in Loongson 2K0300 SoC, which > > > generates various clock signals for SoC peripherals. > > > > > > Differing from previous generations of SoCs, 2K0300 requires a 120MHz > > > external clock input, and a separate dt-binding header is used for > > > cleanness. > > > > > > Signed-off-by: Yao Zi > > > --- > > > .../bindings/clock/loongson,ls2k-clk.yaml | 26 ++++++--- > > > MAINTAINERS | 1 + > > > .../dt-bindings/clock/loongson,ls2k0300-clk.h | 54 +++++++++++++++++++ > > > 3 files changed, 75 insertions(+), 6 deletions(-) > > > create mode 100644 include/dt-bindings/clock/loongson,ls2k0300-clk.h > > > > > > diff --git a/Documentation/devicetree/bindings/clock/loongson,ls2k-clk.yaml b/Documentation/devicetree/bindings/clock/loongson,ls2k-clk.yaml > > > index 4f79cdb417ab..3e0a894cfb2f 100644 > > > --- a/Documentation/devicetree/bindings/clock/loongson,ls2k-clk.yaml > > > +++ b/Documentation/devicetree/bindings/clock/loongson,ls2k-clk.yaml > > > @@ -16,6 +16,7 @@ description: | > > > properties: > > > compatible: > > > enum: > > > + - loongson,ls2k0300-clk > > > - loongson,ls2k0500-clk > > > - loongson,ls2k-clk # This is for Loongson-2K1000 > > > - loongson,ls2k2000-clk > > > @@ -24,19 +25,32 @@ properties: > > > maxItems: 1 > > > > > > clocks: > > > - items: > > > - - description: 100m ref > > > + maxItems: 1 > > > > > > - clock-names: > > > - items: > > > - - const: ref_100m > > > + clock-names: true > > > > No. How does this implement my comment? Hi Krzysztof, > I'm sorry that I forgot about the suggestion of dropping clock-names for > the new compatible. > > Is it acceptable to remove the description of clocks property, keep > clock-names property as-is, and use an allOf block to disallow > clocks-names for the new 2K0300 compatible? Thanks for your explanation. Could you please provide some further comments on this? The schema will look like, clocks: maxItems: 1 clock-names: items: - const: ref_100m ... allOf: - if: properties: compatible: contains: const: loongson,ls2k0300-clk then: properties: clock-names: false else: required: - clock-names Thanks for your time and suggestion. > > It makes no sense, why 100m even appeared here. I already objected last > > time! > > > > > > > > '#clock-cells': > > > const: 1 > > > description: > > > The clock consumer should specify the desired clock by having the clock > > > ID in its "clocks" phandle cell. See include/dt-bindings/clock/loongson,ls2k-clk.h > > > - for the full list of Loongson-2 SoC clock IDs. > > > + and include/dt-bindings/clock/loongson,ls2k0300-clk.h for the full list of > > > + Loongson-2 SoC clock IDs. > > > + > > > +allOf: > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + const: loongson,ls2k0300-clk > > > + then: > > > + properties: > > > + clock-names: > > > + const: ref_120m > > > > NAK, stop doing this pattern. You already got comment on this. > > Oops, I missed the comment about dropping the frequency (or the full > clock-names property) from clock-names when writing v2, and I've decided > to drop the clock-names property completely for the 2K0300 compatible. > > Sorry again for my mistake. > > > Best regards, > > Krzysztof > > > > > > Best regards, > Yao Zi > Regards, Yao Zi