Re: [PATCH v7 4/6] arm64: dts: imx8mp: convert 'aips5' to 'aipstz5'

Laurentiu Mihalcea
2025-07-07T23:49:24Z

On 7/7/2025 8:11 AM, Alexander Stein wrote:
> Hi,
>
> Am Mittwoch, 2. Juli 2025, 21:54:09 CEST schrieb Laurentiu Mihalcea:
>> On 7/2/2025 9:49 PM, Mark Brown wrote:
>>> On Tue, Jun 10, 2025 at 12:01:50PM -0400, Laurentiu Mihalcea wrote:
>>>> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>>>>
>>>> AIPS5 is actually AIPSTZ5 as it offers some security-related
>>>> configurations. Since these configurations need to be applied before
>>>> accessing any of the peripherals on the bus, it's better to make AIPSTZ5
>>>> be their parent instead of keeping AIPS5 and adding a child node for
>>>> AIPSTZ5. Also, because of the security configurations, the address space
>>>> of the bus has to be changed to that of the configuration registers.
>>>>
>>>> Finally, since AIPSTZ5 belongs to the AUDIOMIX power domain, add the
>>>> missing 'power-domains' property. The domain needs to be powered on before
>>>> attempting to configure the security-related registers.
>>> I'm seeing failures to probe the audio devices on the i.MX8MP Verdin
>>> system in -next which seem to bisect down to this commit, I'm seeing
>>> separate boot failures on the EVK so haven't been able to confirm the
>>> status there. There's no obvious logging, the dt selftest shows:
>>>
>>> # not ok 141 /sound
>>> # not ok 142 /sound-hdmi
>>>
>>> Full log at:
>>>
>>> https://lava.sirena.org.uk/scheduler/job/1530197#L5119
>> Hi Mark,
>>
>> Thanks for catching this!
>>
>> After browsing through the provided logs it would seem like no device under the
>> AIPSTZ bus gets probed. Right now, my guess is that the AIPSTZ driver is not being
>> compiled since CONFIG_IMX_AIPSTZ might be set to 'n'.
>>
>> Which defconfig is the CI using? Is it arch/arm64/configs/defconfig?
> I'm also seeing audio problems starting with this commit. In my case I get
> the following error:
> fsl-asoc-card sound: failed to find CPU DAI device
> fsl-asoc-card sound: probe with driver fsl-asoc-card failed with error -22
>
> DAI device is sai5 aka /soc@0/bus@30df0000/spba-bus@30c00000/sai@30c50000.
> It turns out that the module snd_soc_fsl_sai is not even autoloaded. Loading
> manually doesn't have any effect. So I assume starting from this commit
> the subnodes (at least sai5) are not even populated.
> Reverting this commit fixes my setup.
> I've set CONFIG_IMX_AIPSTZ to both 'y' or 'm' and doesn't change anything.

ACK. Would you mind giving [1] a try and letting me know if that fixes the issue for you?

[1]: https://lore.kernel.org/lkml/20250707234628.164151-2-laurentiumihalcea111@gmail.com/

Thanks!