Re: [PATCH 2/2] dt-bindings: iio: magnetometer: document Infineon TLV493D 3D Magnetic sensor

Krzysztof Kozlowski
2025-07-27T09:23:09Z

On 26/07/2025 11:37, Dixit Parmar wrote:
> Document the bindings for Infineon TLV493D Low-Power 3D Magnetic Sensor
> controlled by I2C interface. Main applications includes joysticks, control
> elements (white goods, multifunction knops), or electric meters (anti
> tampering).

You are duplicating existing binding, need to remove it as well.

>
> The device can be configured in to different operating modes by optional
> device-tree "mode" property. Also, the temperature sensing part requires
> raw offset captured at 25°C and that can be specified by "temp-offset"
> optional device-tree property.
>
> Datasheet: https://www.infineon.com/assets/row/public/documents/24/49/infineon-tlv493d-a1b6-datasheet-en.pdf
>
> Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com>
> ---
> .../iio/magnetometer/infineon,tlv493d.yaml | 57 ++++++++++++++++++++++
> 1 file changed, 57 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml
> new file mode 100644
> index 000000000000..0442cf41503b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/magnetometer/infineon,tlv493d.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Infineon Technologies TLV493D Low-Power 3D Magnetic Sensor
> +
> +maintainers:
> + - Dixit Parmar <dixitparmar19@gmail.com>
> +
> +properties:
> + $nodename:
> + pattern: '^magnetometer@[0-9a-f]+$'
> +
> + compatible:
> + const: infineon,tlv493d-a1b6
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply:
> + description: 2.8V to 3.5V supply
> +
> + mode:
> + description: Sensor operating mode. Must be one of the defined enum values.

Why is this board level property? I imagine you want to change it runtime.

> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # Power Down Mode. No measurement.
> + - 1 # Fast Mode
> + - 2 # Low-Power Mode
> + - 3 # Ultra Low-Power Mode
> + - 4 # Master Controlled Mode
> + default: 4
> +
> + temp-offset:
> + description: Raw temperature offset at 25°C to apply before applying scale and correction.

Does not look wrapped according to Linux coding style.

> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: 340

Missing vendor prefix, missing unit suffix. I am also not sure what is
the board design choice to offset it.

> +
> +required:
> + - compatible
> + - reg

Missing supplies.

Best regards,
Krzysztof