devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zixian Zeng <sycamoremoon376@gmail.com>
To: Chen Wang <unicorn_wang@outlook.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Inochi Amaoto <inochiama@gmail.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>
Cc: devicetree@vger.kernel.org, sophgo@lists.linux.dev,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	Han Gao <rabenda.cn@gmail.com>
Subject: Re: [PATCH 4/4] riscv: dts: sophgo: Enable SPI NOR node for SG2042_EVB_V2
Date: Fri, 15 Aug 2025 14:17:10 +0800	[thread overview]
Message-ID: <aJ7Q5tQ3oa8DBpfO@calculate> (raw)
In-Reply-To: <MAUPR01MB11072CB6BD1EC94B752AA1F8BFE34A@MAUPR01MB11072.INDPRD01.PROD.OUTLOOK.COM>

On Fri, Aug 15, 2025 at 11:56:22AM +0800, Chen Wang wrote:
> 
> On 8/13/2025 4:33 PM, Zixian Zeng wrote:
> > Enable SPI NOR node for SG2042_EVB_V2 device tree
> >
> > Signed-off-by: Han Gao <rabenda.cn@gmail.com>
> > Signed-off-by: Zixian Zeng <sycamoremoon376@gmail.com>
> > ---
> >   arch/riscv/boot/dts/sophgo/sg2042-evb-v2.dts | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/sophgo/sg2042-evb-v2.dts b/arch/riscv/boot/dts/sophgo/sg2042-evb-v2.dts
> > index 46980e41b886ce17dacce791fa5f2cef14cfa214..7001d8ffdc3e04c5a5cd5da85a4fb1c0351eb9a5 100644
> > --- a/arch/riscv/boot/dts/sophgo/sg2042-evb-v2.dts
> > +++ b/arch/riscv/boot/dts/sophgo/sg2042-evb-v2.dts
> > @@ -226,6 +226,18 @@ &sd {
> >   	status = "okay";
> >   };
> >   
> > +&spifmc1 {
> > +	status = "okay";
> > +
> > +	flash@0 {
> > +		compatible = "jedec,spi-nor";
> > +		reg = <0>;
> > +		spi-max-frequency = <100000000>;
> > +		spi-tx-bus-width = <4>;
> > +		spi-rx-bus-width = <4>;
> > +	};
> > +};
> > +
> 
> Only spifmc1 on EVB_V2? What about spifmc0?
> 
Yes, EVB_V2 has only one spifmc1.
I have checked schematics which can be opened by OrCAD:
https://github.com/sophgo/sophgo-hardware/blob/master/SG2042/SG2042-x4-EVB/sch/SG2042_EVB_V2_20230302A_BOM.DSN
https://github.com/sophgo/sophgo-hardware/blob/master/SG2042/SG2042-x8-EVB/SG2042_EVB_V11_20220902_BOM.DSN

For your convenience, I have exported them to PDF:
https://github.com/sycamoremoon/linux-riscv/tree/schematic
> Otherwise:
> 
> Reviewed-by: Chen Wang <unicorn_wang@outlook.com>

Thanks for your reviewing.

Best Regards,
Zixian

  reply	other threads:[~2025-08-15  6:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13  8:33 [PATCH 0/4] Add SPI NOR DTS node for SG2042 SoC and boards using it Zixian Zeng
2025-08-13  8:33 ` [PATCH 1/4] riscv: dts: sophgo: Add SPI NOR node for SG2042 Zixian Zeng
2025-08-13  8:33 ` [PATCH 2/4] riscv: dts: sophgo: Enable SPI NOR node for PioneerBox Zixian Zeng
2025-08-13  8:33 ` [PATCH 3/4] riscv: dts: sophgo: Enable SPI NOR node for SG2042_EVB_V1 Zixian Zeng
2025-08-15  3:57   ` Chen Wang
2025-08-13  8:33 ` [PATCH 4/4] riscv: dts: sophgo: Enable SPI NOR node for SG2042_EVB_V2 Zixian Zeng
2025-08-15  3:56   ` Chen Wang
2025-08-15  6:17     ` Zixian Zeng [this message]
2025-08-21  1:35       ` Troy Mitchell
2025-08-13  9:16 ` [PATCH 0/4] Add SPI NOR DTS node for SG2042 SoC and boards using it Chen Wang
2025-09-01  6:20 ` Inochi Amaoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJ7Q5tQ3oa8DBpfO@calculate \
    --to=sycamoremoon376@gmail.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=inochiama@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=rabenda.cn@gmail.com \
    --cc=robh@kernel.org \
    --cc=sophgo@lists.linux.dev \
    --cc=unicorn_wang@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).