From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C3D8246769 for ; Mon, 4 Aug 2025 11:08:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754305687; cv=none; b=gSrPdjoi+g5DCEOa/K7bUoo7sksJFc6qtW/VMx7+HgOjeTVoD0dcM25uU9TA77zmbfPiH+1A8V/wzu9Ra5ywTpX/ze/QDzOk433fu88gqqfxcSz/BbTakO6GA18hHHa6XUP4xW0/pdj74GPseZZ+mLY42ph2rSKTJ4AuH4MCogw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754305687; c=relaxed/simple; bh=7qhyH/PU8NTXMb07r6bgr29blza+kLWRP/cKMCl7M4w=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kbXAtnJGYc8YqOvSu51OJBSUz4YojhvOeWkk1lTlwXI0KFAN+Zix0cC8EKaBmHajY9vR/bhaTNdj2M0DvBJ6H515DjTukbICefjVaJQB90vZG67OYlsKKGlvbDcptYthdHBaRQnsO/vmwPafqJpS6W54s7VQ/8sHOEJPuV/1Aa4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=earNJcF8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="earNJcF8" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5748VRrB027684 for ; Mon, 4 Aug 2025 11:08:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /quFVpXGaSR9+jFTg65KdPNzkiQfbcpVWaZyCBq0GDY=; b=earNJcF87v6maYZ+ 3Edr7gGXrDDQC/tXRPm7w/MLWf/UlPLNThSm/WS8FImrvWFo8hVgvlJKxermNpvk IUjnA/fbiFT4xPl1t3UeRHhgNHnAI5BoXjxWcstXu/0KULfA4eztREzvqL7F8FoR p5d2v6IcRk63oouvsICt0UhHjuRw2/da2tlCP3bAgvmcwyOMcqCBEwXw/1m4Olp/ mXWdDBCr/+K1k81yBqcaI6L+2IqA4JR+aS2vQBsy3Qdju2S++Ql51gh4PwUY12Bb 7XoUQsNdxA8y0GJyqOSZoiHPQeCeONirBNcR5JCvhOCTYKnz0Ei19T8GKTS3s2AO gxV4Tg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 489buqmm8r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 04 Aug 2025 11:08:05 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4af156a27b1so67495691cf.3 for ; Mon, 04 Aug 2025 04:08:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754305684; x=1754910484; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/quFVpXGaSR9+jFTg65KdPNzkiQfbcpVWaZyCBq0GDY=; b=XyGZ72YT8bToPdQK4lBDxPMCziwwitOMI4b8wV9yzjmYSpvqDSylDVgYi+IePUKRN5 0ZITzArz1KdGCXKznzXeN8n/y+2luMs7IFK2x5eHxS9WINisBcMS1JnXzTn87Xxgbifm yaWMbAdSmBCjCv6Y83EjHBob/VP6zK9EngOT/hWERGH5bYYWM+niCHIsBHowTqj1fFjo tytg27QZ4981QLLv3Q6HmOCdXNVd33lpWvmv4PVHgoH9Ul52unnU4E+EL39GdFHwFTww W0QT/090PW/werMCVNxVTYt3RTlWl4BH+RQQyDNcalxUKX5fWxSbHXlYsS61kYj3l/yh r+BA== X-Forwarded-Encrypted: i=1; AJvYcCU9T04e2/RKFerKnKoFXYoB+JCn4Xc30XkCHwJV+pDKAfMuFCsjPDl9XOIvCGlGhdNmgWSrgvp/TcOZ@vger.kernel.org X-Gm-Message-State: AOJu0YwAm7CgpNpFIlPwHlO1xxySBHf714RSWgxdiLvNxi60kp54gY0q mXaKeAsniMSYAQthT9V+3RuRD4pGu5cjeCIKyKXFTzaadR24z9jU+Tvys2fmg69Szfo+E+FLkKg q8sU7KWi2rtyJy9s66FOPzs4mZhzqXHJZ8Mp6axyiLumeLudj33ObhZDBJHZecekp X-Gm-Gg: ASbGnct/CQqQng3k17q9UZ8JlPDal5Jay4abIm3WUC/UjBDlkZ7vVtr24DvKgRUUo6g rdUnDgqemlewZ6bbQAqf92x53g8mcfqZHBSZGcpFdkUMgfLVoyNCN3q06qEeGKwGJaxLNutKEeK 9r4wfF+hDCZqtlkZxYdFHJ22EZwN4w56XcBGzotSItuOEgm/by8Jj7Db05V3MgfCLieoZ9ApKkR EsRH3cT1/O1Fc8/pYMVX19GFj12oShSt0aJzRinUoTOcQBZeOgN3h6ahN+R6TGtBpg1mGC+tgxG jzi/voAFqR4GHKKUU41qzGVWmijrYVw0f0MVLt3ulcCrpcMPDSZOPK7jsgjShLdWlVU+dQ== X-Received: by 2002:ac8:7dc6:0:b0:4ab:1a4a:1cfc with SMTP id d75a77b69052e-4af109e1692mr120452121cf.22.1754305684131; Mon, 04 Aug 2025 04:08:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGbFNrQOAHiSqeoYZPfVBZx5TLgseXs8R9ww0pxzX0zAUXdnmmDqsXaerx5Ls2XGk0BTwzwQ== X-Received: by 2002:ac8:7dc6:0:b0:4ab:1a4a:1cfc with SMTP id d75a77b69052e-4af109e1692mr120451671cf.22.1754305683506; Mon, 04 Aug 2025 04:08:03 -0700 (PDT) Received: from trex (205.red-83-60-94.dynamicip.rima-tde.net. [83.60.94.205]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459ded356b9sm11743785e9.12.2025.08.04.04.08.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Aug 2025 04:08:02 -0700 (PDT) From: Jorge Ramirez X-Google-Original-From: Jorge Ramirez Date: Mon, 4 Aug 2025 13:08:01 +0200 To: Bryan O'Donoghue Cc: Krzysztof Kozlowski , Konrad Dybcio , Jorge Ramirez , quic_vgarodia@quicinc.com, quic_dikshita@quicinc.com, krzk+dt@kernel.org, konradybcio@kernel.org, mchehab@kernel.org, andersson@kernel.org, conor+dt@kernel.org, amit.kucheria@oss.qualcomm.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/7] media: dt-bindings: venus: Add qcm2290 dt schema Message-ID: References: <20250715204749.2189875-2-jorge.ramirez@oss.qualcomm.com> <8a63f517-a443-48e4-9b9c-0c4b362f59f8@linaro.org> <0bb2867a-393b-46f9-ad6f-1aeee5a3a9d4@kernel.org> <5afbaf46-bbb1-47d8-84aa-29b18987564f@kernel.org> <18d013e5-352e-457b-ba96-3dd19f1cbaed@oss.qualcomm.com> <56d4e911-5bec-458e-acd1-3594a6d8b91d@kernel.org> <1402a52f-639c-4872-a153-b549603c13a7@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1402a52f-639c-4872-a153-b549603c13a7@linaro.org> X-Proofpoint-GUID: 2geFJhpeXdnptsdnhxrqI2qdO0XnPn0C X-Authority-Analysis: v=2.4 cv=VZT3PEp9 c=1 sm=1 tr=0 ts=68909495 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=Rr2dNH5/fcnoRoBmcVUeRg==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=CUqL58EqNT68S6E0SegA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA0MDA2MCBTYWx0ZWRfX4qqyT6+gL86f RCozXhsj56kVWZsysoyPCnhsM+WvkR53oQToDD/I5RV1Uh8IXTZw4TZt62rznJsK2RmSPsNALz0 zlH2CGlY9VS1I6z/GBr4fzOhtxOW1z062vDp5HY7FU1+as9+BF/uveAnM8EsKHiCV7zHG3vQsqO 4Tzylsypm502Nvttxwt/Y2bjpzo8B6VnIYlNvF1JFOMZyMyhCeKWFRgdRJfAh7CqnKVqyySwLkU lPfF+og4vDqupTe/UHrdAqTQgsDm6cychBUfwzng4iGS2h4POG7K+0dnJjyT3OdhkwRbhQ0k+Hp jzM5o8K5X4Qv5tsBWr8gGxg3pryZC+bUrp/f/oi4xsTowRgnz0SjJzH+XpfbsVB5+syxPn40u+k f91zo/+7W23ytVbtJOu+sJbo5kmoxMBAiiQF5XNYf0d2EH9nASCs759kehzJEV2D4CEQOVYw X-Proofpoint-ORIG-GUID: 2geFJhpeXdnptsdnhxrqI2qdO0XnPn0C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-04_04,2025-08-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=771 malwarescore=0 bulkscore=0 phishscore=0 spamscore=0 mlxscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508040060 On 18/07/25 11:21:07, Bryan O'Donoghue wrote: > On 18/07/2025 11:04, Krzysztof Kozlowski wrote: > > On 18/07/2025 12:02, Konrad Dybcio wrote: > > > On 7/18/25 8:27 AM, Krzysztof Kozlowski wrote: > > > > On 17/07/2025 19:00, Jorge Ramirez wrote: > > > > > On 17/07/25 13:16:31, Jorge Ramirez wrote: > > > > > > Not sure if I’ve shared this before, but following an internal > > > > > discussion, I think it’s worth highlighting a functional dependency in > > > > > the current kernel: > > > > > > > > > > - the driver only works if the first two IOMMUs in the list — the > > > > > non-secure ones — are placed at the beginning. Reordering them breaks > > > > > functionality, which introduces unexpected fragility. > > > > > > > > > > Regardless, this seems like a valid concern to me — a driver shouldn't > > > > > rely on the order of phandles — and I just wanted to make sure you're > > > > > aware of it before I post a v8 (likely sometime next week or the > > > > > following, as I’ll be taking a short break soon). > > > > > > > > > > > > Hm? Order of lists is strictly defined. That's actually an overlook that > > > > we never do it for iommus, but the core rule stays. > > > > > > (FWIW "items:" is an ordered list, "enum:" is unordered) > > > > enum is not a list, but enumeration, meaning one item of multiple values. > > > > Best regards, > > Krzysztof > > As Krzysztof says the ordering is strict. > > I think the right-thing-to-do is to document in the commit log the > dependency. > > The final three entries are secure entries and the ordering is important. sure, will do that > > --- > bod